[SRU][OEM-OSP1/E/unstable][PATCH 0/1] change kconfig of the soundwire bus driver from y to m

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1/E/unstable][PATCH 0/1] change kconfig of the soundwire bus driver from y to m

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1855685

[Impact]
We just got a Dell laptop which has soundwire codec on it, and let
us change the soundwire bus from y to m, then the kernel image size
will be reduced and it is easy for us to use dkms to replace this
driver.

And Intel released a sound wire audio driver to us, but it is based
on the 5.4-rc7, we couldn't backport 150+ patches to our oem-osp1
kernel, and we plan to use dkms on this machine. To use dkms, we
need to change this driver to a kernel module.

[Fix]
Change the kernel config from y to m.

[Test Case]
We tested this patch on osp1 kernel, it worked very well with soundwire
audio dkms.

[Regression Risk]
Low, just change a driver from y to m.


Hui Wang (1):
  UBUNTU: [config]: SOUNDWIRE=m

 debian.master/config/annotations          | 3 ++-
 debian.master/config/config.common.ubuntu | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1][PATCH 1/1] UBUNTU: [config]: SOUNDWIRE=m

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1855685

This can reduce the kernel size, and it is easy to replace the
soundwire bus driver with dkms.

Signed-off-by: Hui Wang <[hidden email]>
---
 debian.oem-osp1/config/annotations          | 3 ++-
 debian.oem-osp1/config/config.common.ubuntu | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/debian.oem-osp1/config/annotations b/debian.oem-osp1/config/annotations
index f1a45643e502..8afd07793266 100644
--- a/debian.oem-osp1/config/annotations
+++ b/debian.oem-osp1/config/annotations
@@ -7975,7 +7975,8 @@ CONFIG_SND_X86                                  policy<{'amd64': 'y', 'i386': 'y
 CONFIG_HDMI_LPE_AUDIO                           policy<{'amd64': 'm', 'i386': 'm'}>
 
 # Menu: Device Drivers >> SoundWire support
-CONFIG_SOUNDWIRE                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
+CONFIG_SOUNDWIRE                                mark<ENFORCED> note<LP:1855685>
+CONFIG_SOUNDWIRE                                policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_SOUNDWIRE_INTEL                          policy<{'amd64': 'm', 'i386': 'm'}>
 
 # Menu: Device Drivers >> Staging drivers
diff --git a/debian.oem-osp1/config/config.common.ubuntu b/debian.oem-osp1/config/config.common.ubuntu
index 18edb714030c..0b476b1023d0 100644
--- a/debian.oem-osp1/config/config.common.ubuntu
+++ b/debian.oem-osp1/config/config.common.ubuntu
@@ -7043,7 +7043,7 @@ CONFIG_SONYPI_COMPAT=y
 CONFIG_SONY_FF=y
 CONFIG_SONY_LAPTOP=m
 CONFIG_SOUND=m
-CONFIG_SOUNDWIRE=y
+CONFIG_SOUNDWIRE=m
 CONFIG_SOUNDWIRE_CADENCE=m
 CONFIG_SOUNDWIRE_INTEL=m
 CONFIG_SOUND_OSS_CORE=y
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][E][PATCH 1/1] UBUNTU: [config]: SOUNDWIRE=m

Hui Wang
In reply to this post by Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1855685

This can reduce the kernel size, and it is easy to replace the
soundwire bus driver with dkms.

Signed-off-by: Hui Wang <[hidden email]>
---
 debian.master/config/annotations          | 3 ++-
 debian.master/config/config.common.ubuntu | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 1ed5721be391..bfb28c0ed1b3 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -8257,7 +8257,8 @@ CONFIG_SND_X86                                  policy<{'amd64': 'y', 'i386': 'y
 CONFIG_HDMI_LPE_AUDIO                           policy<{'amd64': 'm', 'i386': 'm'}>
 
 # Menu: Device Drivers >> SoundWire support
-CONFIG_SOUNDWIRE                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
+CONFIG_SOUNDWIRE                                mark<ENFORCED> note<LP:1855685>
+CONFIG_SOUNDWIRE                                policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm', 's390x': 'm'}>
 CONFIG_SOUNDWIRE_INTEL                          policy<{'amd64': 'm', 'i386': 'm'}>
 
 # Menu: Device Drivers >> Staging drivers
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 16d16787bb2c..4aa11a069719 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -9457,7 +9457,7 @@ CONFIG_SONYPI=m
 CONFIG_SONYPI_COMPAT=y
 CONFIG_SONY_FF=y
 CONFIG_SONY_LAPTOP=m
-CONFIG_SOUNDWIRE=y
+CONFIG_SOUNDWIRE=m
 CONFIG_SOUNDWIRE_CADENCE=m
 CONFIG_SOUNDWIRE_INTEL=m
 CONFIG_SOUND_OSS_CORE=y
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][unstable][PATCH 1/1] UBUNTU: [config]: SOUNDWIRE=m

Hui Wang
In reply to this post by Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1855685

This can reduce the kernel size, and it is easy to replace the
soundwire bus driver with dkms.

Signed-off-by: Hui Wang <[hidden email]>
---
 debian.master/config/annotations          | 3 ++-
 debian.master/config/config.common.ubuntu | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 2a1d944e0f1b..d3f0063cbb0b 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -8355,7 +8355,8 @@ CONFIG_SND_X86                                  policy<{'amd64': 'y', 'i386': 'y
 CONFIG_HDMI_LPE_AUDIO                           policy<{'amd64': 'm', 'i386': 'm'}>
 
 # Menu: Device Drivers >> SoundWire support
-CONFIG_SOUNDWIRE                                policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y'}>
+CONFIG_SOUNDWIRE                                mark<ENFORCED> note<LP:1855685>
+CONFIG_SOUNDWIRE                                policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'i386': 'm', 'ppc64el': 'm'}>
 CONFIG_SOUNDWIRE_INTEL                          policy<{'amd64': 'm', 'i386': 'm'}>
 
 # Menu: Device Drivers >> Staging drivers
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index bd22613c4eed..dcfe741c7471 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -9570,7 +9570,7 @@ CONFIG_SONYPI=m
 CONFIG_SONYPI_COMPAT=y
 CONFIG_SONY_FF=y
 CONFIG_SONY_LAPTOP=m
-CONFIG_SOUNDWIRE=y
+CONFIG_SOUNDWIRE=m
 CONFIG_SOUNDWIRE_CADENCE=m
 CONFIG_SOUNDWIRE_INTEL=m
 CONFIG_SOUND_OSS_CORE=y
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [OEM-OSP1-B] Re: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] change kconfig of the soundwire bus driver from y to m

Timo Aaltonen-6
In reply to this post by Hui Wang
On 9.12.2019 12.42, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1855685
>
> [Impact]
> We just got a Dell laptop which has soundwire codec on it, and let
> us change the soundwire bus from y to m, then the kernel image size
> will be reduced and it is easy for us to use dkms to replace this
> driver.
>
> And Intel released a sound wire audio driver to us, but it is based
> on the 5.4-rc7, we couldn't backport 150+ patches to our oem-osp1
> kernel, and we plan to use dkms on this machine. To use dkms, we
> need to change this driver to a kernel module.
>
> [Fix]
> Change the kernel config from y to m.
>
> [Test Case]
> We tested this patch on osp1 kernel, it worked very well with soundwire
> audio dkms.
>
> [Regression Risk]
> Low, just change a driver from y to m.
>
>
> Hui Wang (1):
>   UBUNTU: [config]: SOUNDWIRE=m
>
>  debian.master/config/annotations          | 3 ++-
>  debian.master/config/config.common.ubuntu | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>

applied to osp1 oem-next, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[F/Unstable]: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] change kconfig of the soundwire bus driver from y to m

Seth Forshee
In reply to this post by Hui Wang
On Mon, Dec 09, 2019 at 06:42:22PM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1855685
>
> [Impact]
> We just got a Dell laptop which has soundwire codec on it, and let
> us change the soundwire bus from y to m, then the kernel image size
> will be reduced and it is easy for us to use dkms to replace this
> driver.
>
> And Intel released a sound wire audio driver to us, but it is based
> on the 5.4-rc7, we couldn't backport 150+ patches to our oem-osp1
> kernel, and we plan to use dkms on this machine. To use dkms, we
> need to change this driver to a kernel module.
>
> [Fix]
> Change the kernel config from y to m.
>
> [Test Case]
> We tested this patch on osp1 kernel, it worked very well with soundwire
> audio dkms.

Looking at the history, this option was originally a bool which I'm sure
is the only reason it wasn't enabled as a module originally.

Acked-by: Seth Forshee <[hidden email]>

Applied to focal/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] change kconfig of the soundwire bus driver from y to m

Kleber Souza
In reply to this post by Hui Wang
On 2019-12-09 11:42, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1855685
>
> [Impact]
> We just got a Dell laptop which has soundwire codec on it, and let
> us change the soundwire bus from y to m, then the kernel image size
> will be reduced and it is easy for us to use dkms to replace this
> driver.
>
> And Intel released a sound wire audio driver to us, but it is based
> on the 5.4-rc7, we couldn't backport 150+ patches to our oem-osp1
> kernel, and we plan to use dkms on this machine. To use dkms, we
> need to change this driver to a kernel module.
>
> [Fix]
> Change the kernel config from y to m.
>
> [Test Case]
> We tested this patch on osp1 kernel, it worked very well with soundwire
> audio dkms.
>
> [Regression Risk]
> Low, just change a driver from y to m.
>
>
> Hui Wang (1):
>   UBUNTU: [config]: SOUNDWIRE=m
>
>  debian.master/config/annotations          | 3 ++-
>  debian.master/config/config.common.ubuntu | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[E]/Cmnt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] change kconfig of the soundwire bus driver from y to m

Kleber Souza
In reply to this post by Hui Wang
On 2019-12-09 11:42, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1855685
>
> [Impact]
> We just got a Dell laptop which has soundwire codec on it, and let
> us change the soundwire bus from y to m, then the kernel image size
> will be reduced and it is easy for us to use dkms to replace this
> driver.
>
> And Intel released a sound wire audio driver to us, but it is based
> on the 5.4-rc7, we couldn't backport 150+ patches to our oem-osp1
> kernel, and we plan to use dkms on this machine. To use dkms, we
> need to change this driver to a kernel module.
>
> [Fix]
> Change the kernel config from y to m.
>
> [Test Case]
> We tested this patch on osp1 kernel, it worked very well with soundwire
> audio dkms.
>
> [Regression Risk]
> Low, just change a driver from y to m.
>
>
> Hui Wang (1):
>   UBUNTU: [config]: SOUNDWIRE=m
>
>  debian.master/config/annotations          | 3 ++-
>  debian.master/config/config.common.ubuntu | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>

Applied to eoan/master-next branch and also added the nomination to Eoan
on the bug report.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team