[SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1846539

[Impact]
With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
is set to Y, then it will make the legacy intel soc driver fail, and
moreover the current sof driver can't support broadwell well, as a
result, many broadwell computers with I2S codec can't support sound anymore.

[Fix]
Intel submitted a patch, it will make those two kconfig options exclusive,
and the legacy soc's option has higher priority, if both of them are
enabled, sof's option will be disabled.

[Test Case]
Build the kernel and check the debian/build/$buidling_dir/.config,  the
SND_SOC_SOF_BROADWELL_SUPPORT is disabled.

[Regression Risk]
Low, so far, the sof driver can't support broadwell machine well, so
there is no machine use this driver yet.


Pierre-Louis Bossart (1):
  UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
    with legacy driver

 sound/soc/intel/Kconfig     |  3 +++
 sound/soc/sof/intel/Kconfig | 10 +++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion with legacy driver

Hui Wang
From: Pierre-Louis Bossart <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846539

Some distros select all options blindly, which leads to confusion and
bug reports. SOF does not fully support Broadwell due to firmware
dependencies, the machine drivers can only support one option, and
UCM/topology files are still being propagated to downstream distros,
so make SOF on Broadwell an opt-in option that first require distros
to opt-out of existing defaults.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204237
Fixes: f35bf70f61d3 ('ASoC: Intel: Make sure BDW based machine drivers build for SOF')
Signed-off-by: Pierre-Louis Bossart <[hidden email]>
Link: https://lore.kernel.org/r/20191101173045.27099-3-pierre-louis.bossart@...
Signed-off-by: Mark Brown <[hidden email]>
(cherry picked from commit a6955fe0e2309feeab5ec71e4b0dcbe498f4f497
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/soc/intel/Kconfig     |  3 +++
 sound/soc/sof/intel/Kconfig | 10 +++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 7846eb894991..c037a81b25e9 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -58,6 +58,9 @@ config SND_SOC_INTEL_HASWELL
   If you have a Intel Haswell or Broadwell platform connected to
   an I2S codec, then enable this option by saying Y or m. This is
   typically used for Chromebooks. This is a recommended option.
+  This option is mutually exclusive with the SOF support on
+  Broadwell. If you want to enable SOF on Broadwell, you need to
+  deselect this option first.
 
 config SND_SOC_INTEL_BAYTRAIL
  tristate "Baytrail (legacy) Platforms"
diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index 5c1a06e57f5a..16906725fb98 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -92,10 +92,18 @@ config SND_SOC_SOF_HASWELL
 
 config SND_SOC_SOF_BROADWELL_SUPPORT
  bool "SOF support for Broadwell"
+ depends on SND_SOC_INTEL_HASWELL=n
  help
   This adds support for Sound Open Firmware for Intel(R) platforms
   using the Broadwell processors.
-  Say Y if you have such a device.
+  This option is mutually exclusive with the Haswell/Broadwell legacy
+  driver. If you want to enable SOF on Broadwell you need to deselect
+  the legacy driver first.
+  SOF does fully support Broadwell yet, so this option is not
+  recommended for distros. At some point all legacy drivers will be
+  deprecated but not before all userspace firmware/topology/UCM files
+  are made available to downstream distros.
+  Say Y if you want to enable SOF on Broadwell
   If unsure select "N".
 
 config SND_SOC_SOF_BROADWELL
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][OEM-OSP1/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion with legacy driver

Stefan Bader-2
On 20.11.19 04:04, Hui Wang wrote:

> From: Pierre-Louis Bossart <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1846539
>
> Some distros select all options blindly, which leads to confusion and
> bug reports. SOF does not fully support Broadwell due to firmware
> dependencies, the machine drivers can only support one option, and
> UCM/topology files are still being propagated to downstream distros,
> so make SOF on Broadwell an opt-in option that first require distros
> to opt-out of existing defaults.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204237
> Fixes: f35bf70f61d3 ('ASoC: Intel: Make sure BDW based machine drivers build for SOF')
> Signed-off-by: Pierre-Louis Bossart <[hidden email]>
> Link: https://lore.kernel.org/r/20191101173045.27099-3-pierre-louis.bossart@...
> Signed-off-by: Mark Brown <[hidden email]>
> (cherry picked from commit a6955fe0e2309feeab5ec71e4b0dcbe498f4f497
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Hui Wang <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  sound/soc/intel/Kconfig     |  3 +++
>  sound/soc/sof/intel/Kconfig | 10 +++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 7846eb894991..c037a81b25e9 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -58,6 +58,9 @@ config SND_SOC_INTEL_HASWELL
>    If you have a Intel Haswell or Broadwell platform connected to
>    an I2S codec, then enable this option by saying Y or m. This is
>    typically used for Chromebooks. This is a recommended option.
> +  This option is mutually exclusive with the SOF support on
> +  Broadwell. If you want to enable SOF on Broadwell, you need to
> +  deselect this option first.
>  
>  config SND_SOC_INTEL_BAYTRAIL
>   tristate "Baytrail (legacy) Platforms"
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index 5c1a06e57f5a..16906725fb98 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -92,10 +92,18 @@ config SND_SOC_SOF_HASWELL
>  
>  config SND_SOC_SOF_BROADWELL_SUPPORT
>   bool "SOF support for Broadwell"
> + depends on SND_SOC_INTEL_HASWELL=n
>   help
>    This adds support for Sound Open Firmware for Intel(R) platforms
>    using the Broadwell processors.
> -  Say Y if you have such a device.
> +  This option is mutually exclusive with the Haswell/Broadwell legacy
> +  driver. If you want to enable SOF on Broadwell you need to deselect
> +  the legacy driver first.
> +  SOF does fully support Broadwell yet, so this option is not
> +  recommended for distros. At some point all legacy drivers will be
> +  deprecated but not before all userspace firmware/topology/UCM files
> +  are made available to downstream distros.
> +  Say Y if you want to enable SOF on Broadwell
>    If unsure select "N".
>  
>  config SND_SOC_SOF_BROADWELL
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][OEM-OSP1/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion with legacy driver

Kleber Souza
In reply to this post by Hui Wang
On 20.11.19 04:04, Hui Wang wrote:

> From: Pierre-Louis Bossart <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1846539
>
> Some distros select all options blindly, which leads to confusion and
> bug reports. SOF does not fully support Broadwell due to firmware
> dependencies, the machine drivers can only support one option, and
> UCM/topology files are still being propagated to downstream distros,
> so make SOF on Broadwell an opt-in option that first require distros
> to opt-out of existing defaults.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204237
> Fixes: f35bf70f61d3 ('ASoC: Intel: Make sure BDW based machine drivers build for SOF')
> Signed-off-by: Pierre-Louis Bossart <[hidden email]>
> Link: https://lore.kernel.org/r/20191101173045.27099-3-pierre-louis.bossart@...
> Signed-off-by: Mark Brown <[hidden email]>
> (cherry picked from commit a6955fe0e2309feeab5ec71e4b0dcbe498f4f497
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Hui Wang <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  sound/soc/intel/Kconfig     |  3 +++
>  sound/soc/sof/intel/Kconfig | 10 +++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> index 7846eb894991..c037a81b25e9 100644
> --- a/sound/soc/intel/Kconfig
> +++ b/sound/soc/intel/Kconfig
> @@ -58,6 +58,9 @@ config SND_SOC_INTEL_HASWELL
>    If you have a Intel Haswell or Broadwell platform connected to
>    an I2S codec, then enable this option by saying Y or m. This is
>    typically used for Chromebooks. This is a recommended option.
> +  This option is mutually exclusive with the SOF support on
> +  Broadwell. If you want to enable SOF on Broadwell, you need to
> +  deselect this option first.
>  
>  config SND_SOC_INTEL_BAYTRAIL
>   tristate "Baytrail (legacy) Platforms"
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index 5c1a06e57f5a..16906725fb98 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -92,10 +92,18 @@ config SND_SOC_SOF_HASWELL
>  
>  config SND_SOC_SOF_BROADWELL_SUPPORT
>   bool "SOF support for Broadwell"
> + depends on SND_SOC_INTEL_HASWELL=n
>   help
>    This adds support for Sound Open Firmware for Intel(R) platforms
>    using the Broadwell processors.
> -  Say Y if you have such a device.
> +  This option is mutually exclusive with the Haswell/Broadwell legacy
> +  driver. If you want to enable SOF on Broadwell you need to deselect
> +  the legacy driver first.
> +  SOF does fully support Broadwell yet, so this option is not
> +  recommended for distros. At some point all legacy drivers will be
> +  deprecated but not before all userspace firmware/topology/UCM files
> +  are made available to downstream distros.
> +  Say Y if you want to enable SOF on Broadwell
>    If unsure select "N".
>  
>  config SND_SOC_SOF_BROADWELL
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(E)/cmt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Khaled Elmously
In reply to this post by Hui Wang
The bug is not targeted to Eoan - and I'm unable to target it myself for some reason.

On 2019-11-20 11:04:22 , Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846539
>
> [Impact]
> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
> is set to Y, then it will make the legacy intel soc driver fail, and
> moreover the current sof driver can't support broadwell well, as a
> result, many broadwell computers with I2S codec can't support sound anymore.
>
> [Fix]
> Intel submitted a patch, it will make those two kconfig options exclusive,
> and the legacy soc's option has higher priority, if both of them are
> enabled, sof's option will be disabled.
>
> [Test Case]
> Build the kernel and check the debian/build/$buidling_dir/.config,  the
> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>
> [Regression Risk]
> Low, so far, the sof driver can't support broadwell machine well, so
> there is no machine use this driver yet.
>
>
> Pierre-Louis Bossart (1):
>   UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>     with legacy driver
>
>  sound/soc/intel/Kconfig     |  3 +++
>  sound/soc/sof/intel/Kconfig | 10 +++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED(E)/cmt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Stefan Bader-2
On 02.12.19 09:06, Khaled Elmously wrote:
> The bug is not targeted to Eoan - and I'm unable to target it myself for some reason.

The default project is not the kernel. One has to expand the "linux (Ubuntu)"
task and do a save which does not change anything. Then the default (yellow
background) becomes this and you should be able to nominate.

>
> On 2019-11-20 11:04:22 , Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1846539
>>
>> [Impact]
>> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
>> is set to Y, then it will make the legacy intel soc driver fail, and
>> moreover the current sof driver can't support broadwell well, as a
>> result, many broadwell computers with I2S codec can't support sound anymore.
>>
>> [Fix]
>> Intel submitted a patch, it will make those two kconfig options exclusive,
>> and the legacy soc's option has higher priority, if both of them are
>> enabled, sof's option will be disabled.
>>
>> [Test Case]
>> Build the kernel and check the debian/build/$buidling_dir/.config,  the
>> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>>
>> [Regression Risk]
>> Low, so far, the sof driver can't support broadwell machine well, so
>> there is no machine use this driver yet.
>>
>>
>> Pierre-Louis Bossart (1):
>>   UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>>     with legacy driver
>>
>>  sound/soc/intel/Kconfig     |  3 +++
>>  sound/soc/sof/intel/Kconfig | 10 +++++++++-
>>  2 files changed, 12 insertions(+), 1 deletion(-)
>>
>> --
>> 2.17.1
>>
>>
>> --
>> kernel-team mailing list
>> [hidden email]
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[OEM-OSP1-B] Re: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Timo Aaltonen-6
In reply to this post by Hui Wang
On 20.11.2019 5.04, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846539
>
> [Impact]
> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
> is set to Y, then it will make the legacy intel soc driver fail, and
> moreover the current sof driver can't support broadwell well, as a
> result, many broadwell computers with I2S codec can't support sound anymore.
>
> [Fix]
> Intel submitted a patch, it will make those two kconfig options exclusive,
> and the legacy soc's option has higher priority, if both of them are
> enabled, sof's option will be disabled.
>
> [Test Case]
> Build the kernel and check the debian/build/$buidling_dir/.config,  the
> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>
> [Regression Risk]
> Low, so far, the sof driver can't support broadwell machine well, so
> there is no machine use this driver yet.
>
>
> Pierre-Louis Bossart (1):
>   UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>     with legacy driver
>
>  sound/soc/intel/Kconfig     |  3 +++
>  sound/soc/sof/intel/Kconfig | 10 +++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
>

applied to osp1 oem-next, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED(E)/cmt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Stefan Bader-2
In reply to this post by Khaled Elmously
On 02.12.19 09:06, Khaled Elmously wrote:
> The bug is not targeted to Eoan - and I'm unable to target it myself for some reason.

Also note, that by not testing this change it caused build failures because:
1) The config get adjusted to no longer build snd-sof-intel-bdw, including
   this change in a config update patch also clarifies that this is what is
   meant to happen. This part does not cause the build to fail but it will
   delay creating a kernel for the cycle. Here it is a problem because without
   going into details it is unclear which of the two drivers should be kept.
2) The module _must_ be removed from the ABI modules list, otherwise the
   build will fail (this change can go with the config update). The annoying
   part here is that this happens rather late in the build process, so one
   can loose a lot of time.

For now I added this change but it could happen that patches causing build
failures just get unapplied and will miss a cycle.

-Stefan

>
> On 2019-11-20 11:04:22 , Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1846539
>>
>> [Impact]
>> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
>> is set to Y, then it will make the legacy intel soc driver fail, and
>> moreover the current sof driver can't support broadwell well, as a
>> result, many broadwell computers with I2S codec can't support sound anymore.
>>
>> [Fix]
>> Intel submitted a patch, it will make those two kconfig options exclusive,
>> and the legacy soc's option has higher priority, if both of them are
>> enabled, sof's option will be disabled.
>>
>> [Test Case]
>> Build the kernel and check the debian/build/$buidling_dir/.config,  the
>> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>>
>> [Regression Risk]
>> Low, so far, the sof driver can't support broadwell machine well, so
>> there is no machine use this driver yet.
>>
>>
>> Pierre-Louis Bossart (1):
>>   UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>>     with legacy driver
>>
>>  sound/soc/intel/Kconfig     |  3 +++
>>  sound/soc/sof/intel/Kconfig | 10 +++++++++-
>>  2 files changed, 12 insertions(+), 1 deletion(-)
>>
>> --
>> 2.17.1
>>
>>
>> --
>> kernel-team mailing list
>> [hidden email]
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED(E)/cmt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Hui Wang

On 2019/12/4 下午6:39, Stefan Bader wrote:

> On 02.12.19 09:06, Khaled Elmously wrote:
>> The bug is not targeted to Eoan - and I'm unable to target it myself for some reason.
> Also note, that by not testing this change it caused build failures because:
> 1) The config get adjusted to no longer build snd-sof-intel-bdw, including
>     this change in a config update patch also clarifies that this is what is
>     meant to happen. This part does not cause the build to fail but it will
>     delay creating a kernel for the cycle. Here it is a problem because without
>     going into details it is unclear which of the two drivers should be kept.
> 2) The module _must_ be removed from the ABI modules list, otherwise the
>     build will fail (this change can go with the config update). The annoying
>     part here is that this happens rather late in the build process, so one
>     can loose a lot of time.

Oh, I never thought that. If it couldn't be merged into this cycle, I
will prepare the abi patch for the next cycle.

I always build the kernel with "skipabi=true skipconfig=true
skipmodule=true skipretpoline=true", so this problem didn't expose.


Thanks,

Hui.


> For now I added this change but it could happen that patches causing build
> failures just get unapplied and will miss a cycle.
>
> -Stefan
>
>> On 2019-11-20 11:04:22 , Hui Wang wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1846539
>>>
>>> [Impact]
>>> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
>>> is set to Y, then it will make the legacy intel soc driver fail, and
>>> moreover the current sof driver can't support broadwell well, as a
>>> result, many broadwell computers with I2S codec can't support sound anymore.
>>>
>>> [Fix]
>>> Intel submitted a patch, it will make those two kconfig options exclusive,
>>> and the legacy soc's option has higher priority, if both of them are
>>> enabled, sof's option will be disabled.
>>>
>>> [Test Case]
>>> Build the kernel and check the debian/build/$buidling_dir/.config,  the
>>> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>>>
>>> [Regression Risk]
>>> Low, so far, the sof driver can't support broadwell machine well, so
>>> there is no machine use this driver yet.
>>>
>>>
>>> Pierre-Louis Bossart (1):
>>>    UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>>>      with legacy driver
>>>
>>>   sound/soc/intel/Kconfig     |  3 +++
>>>   sound/soc/sof/intel/Kconfig | 10 +++++++++-
>>>   2 files changed, 12 insertions(+), 1 deletion(-)
>>>
>>> --
>>> 2.17.1
>>>
>>>
>>> --
>>> kernel-team mailing list
>>> [hidden email]
>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED(E)/cmt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Stefan Bader-2
On 04.12.19 15:17, Hui Wang wrote:

>
> On 2019/12/4 下午6:39, Stefan Bader wrote:
>> On 02.12.19 09:06, Khaled Elmously wrote:
>>> The bug is not targeted to Eoan - and I'm unable to target it myself for some
>>> reason.
>> Also note, that by not testing this change it caused build failures because:
>> 1) The config get adjusted to no longer build snd-sof-intel-bdw, including
>>     this change in a config update patch also clarifies that this is what is
>>     meant to happen. This part does not cause the build to fail but it will
>>     delay creating a kernel for the cycle. Here it is a problem because without
>>     going into details it is unclear which of the two drivers should be kept.
>> 2) The module _must_ be removed from the ABI modules list, otherwise the
>>     build will fail (this change can go with the config update). The annoying
>>     part here is that this happens rather late in the build process, so one
>>     can loose a lot of time.
>
> Oh, I never thought that. If it couldn't be merged into this cycle, I will
> prepare the abi patch for the next cycle.
>
> I always build the kernel with "skipabi=true skipconfig=true skipmodule=true
> skipretpoline=true", so this problem didn't expose.

There I would strongly suggest using cranky-test-build or at least never use
those options to check for being ready for submitting. I don't think it saves
you time but instead hides all problems which a change might introduce.

>
>
> Thanks,
>
> Hui.
>
>
>> For now I added this change but it could happen that patches causing build
>> failures just get unapplied and will miss a cycle.
>>
>> -Stefan
>>
>>> On 2019-11-20 11:04:22 , Hui Wang wrote:
>>>> BugLink: https://bugs.launchpad.net/bugs/1846539
>>>>
>>>> [Impact]
>>>> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
>>>> is set to Y, then it will make the legacy intel soc driver fail, and
>>>> moreover the current sof driver can't support broadwell well, as a
>>>> result, many broadwell computers with I2S codec can't support sound anymore.
>>>>
>>>> [Fix]
>>>> Intel submitted a patch, it will make those two kconfig options exclusive,
>>>> and the legacy soc's option has higher priority, if both of them are
>>>> enabled, sof's option will be disabled.
>>>>
>>>> [Test Case]
>>>> Build the kernel and check the debian/build/$buidling_dir/.config,  the
>>>> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>>>>
>>>> [Regression Risk]
>>>> Low, so far, the sof driver can't support broadwell machine well, so
>>>> there is no machine use this driver yet.
>>>>
>>>>
>>>> Pierre-Louis Bossart (1):
>>>>    UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>>>>      with legacy driver
>>>>
>>>>   sound/soc/intel/Kconfig     |  3 +++
>>>>   sound/soc/sof/intel/Kconfig | 10 +++++++++-
>>>>   2 files changed, 12 insertions(+), 1 deletion(-)
>>>>
>>>> -- 
>>>> 2.17.1
>>>>
>>>>
>>>> -- 
>>>> kernel-team mailing list
>>>> [hidden email]
>>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED(E)/cmt: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Hui Wang

On 2019/12/4 下午11:28, Stefan Bader wrote:

> On 04.12.19 15:17, Hui Wang wrote:
>> On 2019/12/4 下午6:39, Stefan Bader wrote:
>>> On 02.12.19 09:06, Khaled Elmously wrote:
>>>> The bug is not targeted to Eoan - and I'm unable to target it myself for some
>>>> reason.
>>> Also note, that by not testing this change it caused build failures because:
>>> 1) The config get adjusted to no longer build snd-sof-intel-bdw, including
>>>      this change in a config update patch also clarifies that this is what is
>>>      meant to happen. This part does not cause the build to fail but it will
>>>      delay creating a kernel for the cycle. Here it is a problem because without
>>>      going into details it is unclear which of the two drivers should be kept.
>>> 2) The module _must_ be removed from the ABI modules list, otherwise the
>>>      build will fail (this change can go with the config update). The annoying
>>>      part here is that this happens rather late in the build process, so one
>>>      can loose a lot of time.
>> Oh, I never thought that. If it couldn't be merged into this cycle, I will
>> prepare the abi patch for the next cycle.
>>
>> I always build the kernel with "skipabi=true skipconfig=true skipmodule=true
>> skipretpoline=true", so this problem didn't expose.
>
> There I would strongly suggest using cranky-test-build or at least never use
> those options to check for being ready for submitting. I don't think it saves
> you time but instead hides all problems which a change might introduce.

OK, got it. thx.


>
>>
>> Thanks,
>>
>> Hui.
>>
>>
>>> For now I added this change but it could happen that patches causing build
>>> failures just get unapplied and will miss a cycle.
>>>
>>> -Stefan
>>>
>>>> On 2019-11-20 11:04:22 , Hui Wang wrote:
>>>>> BugLink: https://bugs.launchpad.net/bugs/1846539
>>>>>
>>>>> [Impact]
>>>>> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
>>>>> is set to Y, then it will make the legacy intel soc driver fail, and
>>>>> moreover the current sof driver can't support broadwell well, as a
>>>>> result, many broadwell computers with I2S codec can't support sound anymore.
>>>>>
>>>>> [Fix]
>>>>> Intel submitted a patch, it will make those two kconfig options exclusive,
>>>>> and the legacy soc's option has higher priority, if both of them are
>>>>> enabled, sof's option will be disabled.
>>>>>
>>>>> [Test Case]
>>>>> Build the kernel and check the debian/build/$buidling_dir/.config,  the
>>>>> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>>>>>
>>>>> [Regression Risk]
>>>>> Low, so far, the sof driver can't support broadwell machine well, so
>>>>> there is no machine use this driver yet.
>>>>>
>>>>>
>>>>> Pierre-Louis Bossart (1):
>>>>>     UBUNTU: SAUCE: ASoC: SOF: Intel: Broadwell: clarify mutual exclusion
>>>>>       with legacy driver
>>>>>
>>>>>    sound/soc/intel/Kconfig     |  3 +++
>>>>>    sound/soc/sof/intel/Kconfig | 10 +++++++++-
>>>>>    2 files changed, 12 insertions(+), 1 deletion(-)
>>>>>
>>>>> --
>>>>> 2.17.1
>>>>>
>>>>>
>>>>> --
>>>>> kernel-team mailing list
>>>>> [hidden email]
>>>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[Unstable]: [SRU][OEM-OSP1/E/unstable][PATCH 0/1] make the SND_SOC_SOF_BROADWELL_SUPPORT exclusive with SND_SOC_INTEL_HASWELL

Seth Forshee
In reply to this post by Hui Wang
On Wed, Nov 20, 2019 at 11:04:22AM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1846539
>
> [Impact]
> With the current default kernel config, the SND_SOC_SOF_BROADWELL_SUPPORT
> is set to Y, then it will make the legacy intel soc driver fail, and
> moreover the current sof driver can't support broadwell well, as a
> result, many broadwell computers with I2S codec can't support sound anymore.
>
> [Fix]
> Intel submitted a patch, it will make those two kconfig options exclusive,
> and the legacy soc's option has higher priority, if both of them are
> enabled, sof's option will be disabled.
>
> [Test Case]
> Build the kernel and check the debian/build/$buidling_dir/.config,  the
> SND_SOC_SOF_BROADWELL_SUPPORT is disabled.
>
> [Regression Risk]
> Low, so far, the sof driver can't support broadwell machine well, so
> there is no machine use this driver yet.

Applied with config/annotations updates, and adding snd-sof-intel-bdw to
modules.ignore. Thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team