[SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

Aaron Ma
Buglink: https://bugs.launchpad.net/bugs/1753347

[Impact]
Mic mute hotkey (F1) is not working due to the delay answer when reading EC VPC.
The ideapad_laptop module didn't wait enough time to read VPC.

[Fix]
Add more time to wait for reading EC VPC, the correct data will be got.
Hotkey works well then.

[Test Case]
Tested on Lenovo E41, hotkey works well with this patch.

[Regression Potential]
No regression is expected.

Aaron Ma (1):
  platform/x86: ideapad-laptop: Increase timeout to wait for EC answer

 drivers/platform/x86/ideapad-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH] platform/x86: ideapad-laptop: Increase timeout to wait for EC answer

Aaron Ma
Buglink: https://bugs.launchpad.net/bugs/1753347

Lenovo E41-20 needs more time than 100ms to read VPC,
the funtion keys always failed responding.
Increase timeout to get the value from VPC, then
the funtion keys like mic mute key work well.

Signed-off-by: Aaron Ma <[hidden email]>
Signed-off-by: Andy Shevchenko <[hidden email]>
(cherry picked from commit ed5b9ba7bef7f277cbdf315e385b44e0e3b1a9ab)
Signed-off-by: Aaron Ma <[hidden email]>
---
 drivers/platform/x86/ideapad-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 603fc60..d8bd04c 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -106,7 +106,7 @@ MODULE_PARM_DESC(no_bt_rfkill, "No rfkill for bluetooth.");
 /*
  * ACPI Helpers
  */
-#define IDEAPAD_EC_TIMEOUT (100) /* in ms */
+#define IDEAPAD_EC_TIMEOUT (200) /* in ms */
 
 static int read_method_int(acpi_handle handle, const char *method, int *val)
 {
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

Hui Wang
In reply to this post by Aaron Ma
Acked-by: Hui Wang <[hidden email]>


On 2018年03月05日 10:28, Aaron Ma wrote:

> Buglink: https://bugs.launchpad.net/bugs/1753347
>
> [Impact]
> Mic mute hotkey (F1) is not working due to the delay answer when reading EC VPC.
> The ideapad_laptop module didn't wait enough time to read VPC.
>
> [Fix]
> Add more time to wait for reading EC VPC, the correct data will be got.
> Hotkey works well then.
>
> [Test Case]
> Tested on Lenovo E41, hotkey works well with this patch.
>
> [Regression Potential]
> No regression is expected.
>
> Aaron Ma (1):
>    platform/x86: ideapad-laptop: Increase timeout to wait for EC answer
>
>   drivers/platform/x86/ideapad-laptop.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[B]: [SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

Seth Forshee
In reply to this post by Aaron Ma
On Mon, Mar 05, 2018 at 10:28:48AM +0800, Aaron Ma wrote:

> Buglink: https://bugs.launchpad.net/bugs/1753347
>
> [Impact]
> Mic mute hotkey (F1) is not working due to the delay answer when reading EC VPC.
> The ideapad_laptop module didn't wait enough time to read VPC.
>
> [Fix]
> Add more time to wait for reading EC VPC, the correct data will be got.
> Hotkey works well then.
>
> [Test Case]
> Tested on Lenovo E41, hotkey works well with this patch.
>
> [Regression Potential]
> No regression is expected.

Acked-by: Seth Forshee <[hidden email]>

Applied to bionic/master-next, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

Po-Hsu Lin (Sam)
In reply to this post by Aaron Ma
Clean cherry-pick with positive test result:
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/linux-oem Re: [SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

Timo Aaltonen-6
In reply to this post by Aaron Ma
On 05.03.2018 04:28, Aaron Ma wrote:

> Buglink: https://bugs.launchpad.net/bugs/1753347
>
> [Impact]
> Mic mute hotkey (F1) is not working due to the delay answer when reading EC VPC.
> The ideapad_laptop module didn't wait enough time to read VPC.
>
> [Fix]
> Add more time to wait for reading EC VPC, the correct data will be got.
> Hotkey works well then.
>
> [Test Case]
> Tested on Lenovo E41, hotkey works well with this patch.
>
> [Regression Potential]
> No regression is expected.
>
> Aaron Ma (1):
>   platform/x86: ideapad-laptop: Increase timeout to wait for EC answer
>
>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

thanks, applied to oem-next

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[Artful/backlog]: [SRU][PATCH][A/B/OEM] Fix Lenovo E41 Micmute hotkey issue

Kleber Souza
In reply to this post by Aaron Ma
On 03/05/18 03:28, Aaron Ma wrote:

> Buglink: https://bugs.launchpad.net/bugs/1753347
>
> [Impact]
> Mic mute hotkey (F1) is not working due to the delay answer when reading EC VPC.
> The ideapad_laptop module didn't wait enough time to read VPC.
>
> [Fix]
> Add more time to wait for reading EC VPC, the correct data will be got.
> Hotkey works well then.
>
> [Test Case]
> Tested on Lenovo E41, hotkey works well with this patch.
>
> [Regression Potential]
> No regression is expected.
>
> Aaron Ma (1):
>   platform/x86: ideapad-laptop: Increase timeout to wait for EC answer
>
>  drivers/platform/x86/ideapad-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied to artful/master-next-backlog branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team