[SRU][U][PATCH 0/3] Add New device id's for CMP-H

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][U][PATCH 0/3] Add New device id's for CMP-H

You-Sheng Yang
From: You-Sheng Yang <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846335

[Impact]
On new CML PCH-H platforms, many devices are not correctly probed,
inclusive of touchpad.

[Fix]
New device IDs for CML PCH-H are landed in v5.4-rc1 and linux-next. So
far the known list are:
* 8f05eee67c14: "mmc: sdhci-pci: Add another Id for Intel CML"
* 07f047e3fe33: "i2c: i801: Add support for Intel Comet Lake PCH-H"
* 5a0feb6287e3: "mtd: spi-nor: intel-spi: Add support for Intel Comet
  Lake-H SPI serial flash"
* dd047dce3a6f: "mfd: intel-lpss: Add Intel Comet Lake PCH-H PCI IDs"

The first one has been included in v5.4-rc1, while the rest are
currently in linux-next.

[Test Case]
Verify built kernel on platforms with CML PCH-H. Check if intel-lpss
module is loaded, i2c-hid is probed, and so on.

[Regression Potential]
Low. These patches add only new device IDs of previously not probed
devices.

[Other Info]
There 4 patches for OEM-OSP1-B/D/E and only 3 for U because 8f05eee67c14
is already included in U.

Andy Shevchenko (1):
  mfd: intel-lpss: Add Intel Comet Lake PCH-H PCI IDs

Jarkko Nikula (1):
  i2c: i801: Add support for Intel Comet Lake PCH-H

Mika Westerberg (1):
  mtd: spi-nor: intel-spi: Add support for Intel Comet Lake-H SPI serial
    flash

 drivers/i2c/busses/i2c-i801.c       |  4 ++++
 drivers/mfd/intel-lpss-pci.c        | 13 ++++++++++++-
 drivers/mtd/spi-nor/intel-spi-pci.c |  1 +
 3 files changed, 17 insertions(+), 1 deletion(-)

--
2.24.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][U][PATCH 1/3] i2c: i801: Add support for Intel Comet Lake PCH-H

You-Sheng Yang
From: Jarkko Nikula <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846335

Add support for another Intel Comet Lake variant.

Signed-off-by: Jarkko Nikula <[hidden email]>
Reviewed-by: Jean Delvare <[hidden email]>
Signed-off-by: Wolfram Sang <[hidden email]>
(cherry picked from commit 07f047e3fe33aefa44c34ed797b79f0415244202)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/i2c/busses/i2c-i801.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index f1c714acc280..eab632a60eb9 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -64,6 +64,7 @@
  * Cedar Fork (PCH) 0x18df 32 hard yes yes yes
  * Ice Lake-LP (PCH) 0x34a3 32 hard yes yes yes
  * Comet Lake (PCH) 0x02a3 32 hard yes yes yes
+ * Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes
  * Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes
  * Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes
  *
@@ -205,6 +206,7 @@
 
 /* Older devices have their ID defined in <linux/pci_ids.h> */
 #define PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS 0x02a3
+#define PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS 0x06a3
 #define PCI_DEVICE_ID_INTEL_BAYTRAIL_SMBUS 0x0f12
 #define PCI_DEVICE_ID_INTEL_CDF_SMBUS 0x18df
 #define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
@@ -1069,6 +1071,7 @@ static const struct pci_device_id i801_ids[] = {
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CANNONLAKE_LP_SMBUS) },
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS) },
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS) },
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS) },
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS) },
  { 0, }
@@ -1750,6 +1753,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
  case PCI_DEVICE_ID_INTEL_CDF_SMBUS:
  case PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS:
  case PCI_DEVICE_ID_INTEL_COMETLAKE_SMBUS:
+ case PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS:
  case PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS:
  case PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS:
  priv->features |= FEATURE_BLOCK_PROC;
--
2.24.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][U][PATCH 2/3] mtd: spi-nor: intel-spi: Add support for Intel Comet Lake-H SPI serial flash

You-Sheng Yang
In reply to this post by You-Sheng Yang
From: Mika Westerberg <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846335

Intel Comet Lake-H PCH has the same SPI serial flash controller as Comet
Lake-LP. Add Comet Lake-H PCI ID to the driver list of supported devices.

Signed-off-by: Mika Westerberg <[hidden email]>
Signed-off-by: Tudor Ambarus <[hidden email]>
(cherry picked from commit 5a0feb6287e37018af4cbd7754786522ae712980
linux-next)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
index 3cda8e7a68f8..266e5efc1771 100644
--- a/drivers/mtd/spi-nor/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/intel-spi-pci.c
@@ -61,6 +61,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
 
 static const struct pci_device_id intel_spi_pci_ids[] = {
  { PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
+ { PCI_VDEVICE(INTEL, 0x06a4), (unsigned long)&bxt_info },
  { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
  { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
  { PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
--
2.24.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][U][PATCH 3/3] mfd: intel-lpss: Add Intel Comet Lake PCH-H PCI IDs

You-Sheng Yang
In reply to this post by You-Sheng Yang
From: Andy Shevchenko <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1846335

Intel Comet Lake PCH-H has the same LPSS than Intel Cannon Lake.
Add the new IDs to the list of supported devices.

Signed-off-by: Andy Shevchenko <[hidden email]>
Signed-off-by: Lee Jones <[hidden email]>
(cherry picked from commit dd047dce3a6f5233b98e792e2287cc549da35879
linux-next)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/mfd/intel-lpss-pci.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 9355db29d2f9..6a7bfa2ab06d 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -128,7 +128,7 @@ static const struct intel_lpss_platform_info cnl_i2c_info = {
 };
 
 static const struct pci_device_id intel_lpss_pci_ids[] = {
- /* CML */
+ /* CML-LP */
  { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info },
  { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info },
  { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info },
@@ -141,6 +141,17 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
  { PCI_VDEVICE(INTEL, 0x02ea), (kernel_ulong_t)&cnl_i2c_info },
  { PCI_VDEVICE(INTEL, 0x02eb), (kernel_ulong_t)&cnl_i2c_info },
  { PCI_VDEVICE(INTEL, 0x02fb), (kernel_ulong_t)&spt_info },
+ /* CML-H */
+ { PCI_VDEVICE(INTEL, 0x06a8), (kernel_ulong_t)&spt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x06a9), (kernel_ulong_t)&spt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x06aa), (kernel_ulong_t)&spt_info },
+ { PCI_VDEVICE(INTEL, 0x06ab), (kernel_ulong_t)&spt_info },
+ { PCI_VDEVICE(INTEL, 0x06c7), (kernel_ulong_t)&spt_uart_info },
+ { PCI_VDEVICE(INTEL, 0x06e8), (kernel_ulong_t)&cnl_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x06e9), (kernel_ulong_t)&cnl_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x06ea), (kernel_ulong_t)&cnl_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x06eb), (kernel_ulong_t)&cnl_i2c_info },
+ { PCI_VDEVICE(INTEL, 0x06fb), (kernel_ulong_t)&spt_info },
  /* BXT A-Step */
  { PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info },
  { PCI_VDEVICE(INTEL, 0x0aae), (kernel_ulong_t)&bxt_i2c_info },
--
2.24.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][U][PATCH 0/3] Add New device id's for CMP-H

Seth Forshee
In reply to this post by You-Sheng Yang
On Thu, Nov 14, 2019 at 11:11:44PM +0800, You-Sheng Yang wrote:

> From: You-Sheng Yang <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1846335
>
> [Impact]
> On new CML PCH-H platforms, many devices are not correctly probed,
> inclusive of touchpad.
>
> [Fix]
> New device IDs for CML PCH-H are landed in v5.4-rc1 and linux-next. So
> far the known list are:
> * 8f05eee67c14: "mmc: sdhci-pci: Add another Id for Intel CML"
> * 07f047e3fe33: "i2c: i801: Add support for Intel Comet Lake PCH-H"
> * 5a0feb6287e3: "mtd: spi-nor: intel-spi: Add support for Intel Comet
>   Lake-H SPI serial flash"
> * dd047dce3a6f: "mfd: intel-lpss: Add Intel Comet Lake PCH-H PCI IDs"
>
> The first one has been included in v5.4-rc1, while the rest are
> currently in linux-next.
>
> [Test Case]
> Verify built kernel on platforms with CML PCH-H. Check if intel-lpss
> module is loaded, i2c-hid is probed, and so on.
>
> [Regression Potential]
> Low. These patches add only new device IDs of previously not probed
> devices.
>
> [Other Info]
> There 4 patches for OEM-OSP1-B/D/E and only 3 for U because 8f05eee67c14
> is already included in U.

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team