[SRU] UBUNTU: [Packaging]: Stop building nvidia

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] UBUNTU: [Packaging]: Stop building nvidia

Thadeu Lima de Souza Cascardo-3
[Impact]
Building these modules wastes build time, and also may potentially lead to
unnecessary updates.

[Fix]
Set do_dkms_nvidia = false on amd64.mk.

[Test case]
Build test the kernel.

[Potential regression]
Missing signed bits for these modules, in case users use them without LRMs.



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU bionic/linux-gke-5.0] UBUNTU: [Packaging]: Stop building nvidia dkms

Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1910749

There is no linux-restricted-modules for this kernel, hence, building those
modules only wastes build time.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.gke/rules.d/amd64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.gke/rules.d/amd64.mk b/debian.gke/rules.d/amd64.mk
index 2e367260f21a..8208d164a53e 100644
--- a/debian.gke/rules.d/amd64.mk
+++ b/debian.gke/rules.d/amd64.mk
@@ -24,4 +24,4 @@ do_doc_package = false
 do_source_package = false
 do_dtbs = false
 do_common_headers_indep = false
-do_dkms_nvidia  = true
+do_dkms_nvidia  = false
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU bionic/linux-hwe-5.0] UBUNTU: [Packaging]: Stop building nvidia dkms

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1910749

There is no linux-restricted-modules for this kernel, hence, building those
modules only wastes build time.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.hwe/rules.d/amd64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.hwe/rules.d/amd64.mk b/debian.hwe/rules.d/amd64.mk
index ec06674d1123..213339281f85 100644
--- a/debian.hwe/rules.d/amd64.mk
+++ b/debian.hwe/rules.d/amd64.mk
@@ -21,4 +21,4 @@ do_extras_package = true
 do_tools_common = true
 do_tools_acpidbg = true
 do_zfs = true
-do_dkms_nvidia  = true
+do_dkms_nvidia  = false
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU bionic/linux-kvm] UBUNTU: [Packaging]: Stop building nvidia dkms

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1910749

There is no linux-restricted-modules for this kernel, hence, building those
modules only wastes build time.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.kvm/rules.d/amd64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.kvm/rules.d/amd64.mk b/debian.kvm/rules.d/amd64.mk
index a5dd7e9cc16b..da6e3ac931ea 100644
--- a/debian.kvm/rules.d/amd64.mk
+++ b/debian.kvm/rules.d/amd64.mk
@@ -17,7 +17,7 @@ do_tools_hyperv = false
 do_extras_package = false
 do_tools_common = false
 do_zfs = true
-do_dkms_nvidia  = true
+do_dkms_nvidia  = false
 do_dkms_wireguard = true
 do_libc_dev_package = false
 disable_d_i = true
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU xenial/linux-azure] UBUNTU: [Packaging]: Stop building nvidia dkms

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1910749

There is no linux-restricted-modules for this kernel, hence, building those
modules only wastes build time.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.azure/rules.d/amd64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.azure/rules.d/amd64.mk b/debian.azure/rules.d/amd64.mk
index 63dd5fd7cd14..f542336255ff 100644
--- a/debian.azure/rules.d/amd64.mk
+++ b/debian.azure/rules.d/amd64.mk
@@ -22,5 +22,5 @@ do_libc_dev_package=false
 disable_d_i=true
 do_source_package = false
 do_doc_package  = false
-do_dkms_nvidia  = true
+do_dkms_nvidia  = false
 do_dkms_wireguard = true
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU xenial/linux-hwe] UBUNTU: [Packaging]: Stop building nvidia dkms

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1910749

There is no linux-restricted-modules for this kernel, hence, building those
modules only wastes build time.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.hwe/rules.d/amd64.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.hwe/rules.d/amd64.mk b/debian.hwe/rules.d/amd64.mk
index 6515b13314ca..58d7e2e70261 100644
--- a/debian.hwe/rules.d/amd64.mk
+++ b/debian.hwe/rules.d/amd64.mk
@@ -22,6 +22,6 @@ do_extras_package = true
 do_tools_common = true
 do_tools_acpidbg = true
 do_zfs = true
-do_dkms_nvidia  = true
-do_dkms_nvidia_server = true
+do_dkms_nvidia  = false
+do_dkms_nvidia_server = false
 do_dkms_wireguard = true
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU xenial/linux-oracle] UBUNTU: [Packaging]: Stop building nvidia dkms

Thadeu Lima de Souza Cascardo-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
BugLink: https://bugs.launchpad.net/bugs/1910749

There is no linux-restricted-modules for this kernel, hence, building those
modules only wastes build time.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.oracle-xenial/rules.d/amd64.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.oracle-xenial/rules.d/amd64.mk b/debian.oracle-xenial/rules.d/amd64.mk
index 0600dad7f51a..21b48c8e6c0c 100644
--- a/debian.oracle-xenial/rules.d/amd64.mk
+++ b/debian.oracle-xenial/rules.d/amd64.mk
@@ -20,7 +20,7 @@ do_extras_package = true
 do_tools_common = false
 do_tools_acpidbg = true
 do_zfs = true
-do_dkms_nvidia = true
+do_dkms_nvidia = false
 do_dkms_wireguard = true
 do_libc_dev_package = false
 disable_d_i = true
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] UBUNTU: [Packaging]: Stop building nvidia

Kamal Mostafa-2
In reply to this post by Thadeu Lima de Souza Cascardo-3
LGTM.

Acked-by: Kamal Mostafa <[hidden email]>

 -Kamal

On Fri, Jan 08, 2021 at 10:47:09AM -0300, Thadeu Lima de Souza Cascardo wrote:

> [Impact]
> Building these modules wastes build time, and also may potentially lead to
> unnecessary updates.
>
> [Fix]
> Set do_dkms_nvidia = false on amd64.mk.
>
> [Test case]
> Build test the kernel.
>
> [Potential regression]
> Missing signed bits for these modules, in case users use them without LRMs.
>
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] UBUNTU: [Packaging]: Stop building nvidia

Colin Ian King-2
In reply to this post by Thadeu Lima de Souza Cascardo-3
On 08/01/2021 13:47, Thadeu Lima de Souza Cascardo wrote:

> [Impact]
> Building these modules wastes build time, and also may potentially lead to
> unnecessary updates.
>
> [Fix]
> Set do_dkms_nvidia = false on amd64.mk.
>
> [Test case]
> Build test the kernel.
>
> [Potential regression]
> Missing signed bits for these modules, in case users use them without LRMs.
>
>
>
Yup, make sense.

Acked-by: Colin Ian King <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team