[SRU][X][B][F][PATCH 0/1] Change NET_IPIP and IPV6_SIT to modules

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][X][B][F][PATCH 0/1] Change NET_IPIP and IPV6_SIT to modules

Khalid Elmously
BugLink: https://bugs.launchpad.net/bugs/1899832

There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.


Khalid Elmously (1):
  Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m

 debian.kvm/config/config.common.ubuntu | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B][PATCH 1/1] Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m

Khalid Elmously
BugLink: https://bugs.launchpad.net/bugs/1899832

There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.

Signed-off-by: Khalid Elmously <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 6648bd51a4f19..fb0f7dc2e5437 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1054,7 +1054,7 @@ CONFIG_INET_ESP_OFFLOAD=m
 CONFIG_INET_IPCOMP=m
 # CONFIG_INET_RAW_DIAG is not set
 CONFIG_INET_TCP_DIAG=y
-CONFIG_INET_TUNNEL=y
+CONFIG_INET_TUNNEL=m
 # CONFIG_INET_UDP_DIAG is not set
 CONFIG_INET_XFRM_MODE_BEET=y
 CONFIG_INET_XFRM_MODE_TRANSPORT=y
@@ -1154,7 +1154,7 @@ CONFIG_IPV6_NDISC_NODETYPE=y
 # CONFIG_IPV6_ROUTER_PREF is not set
 # CONFIG_IPV6_SEG6_HMAC is not set
 # CONFIG_IPV6_SEG6_LWTUNNEL is not set
-CONFIG_IPV6_SIT=y
+CONFIG_IPV6_SIT=m
 # CONFIG_IPV6_SIT_6RD is not set
 CONFIG_IPV6_SUBTREES=y
 # CONFIG_IPV6_TUNNEL is not set
@@ -1580,9 +1580,9 @@ CONFIG_NET_FLOW_LIMIT=y
 # CONFIG_NET_IFE is not set
 CONFIG_NET_INGRESS=y
 # CONFIG_NET_IPGRE_DEMUX is not set
-CONFIG_NET_IPIP=y
+CONFIG_NET_IPIP=m
 # CONFIG_NET_IPVTI is not set
-CONFIG_NET_IP_TUNNEL=y
+CONFIG_NET_IP_TUNNEL=m
 CONFIG_NET_KEY=m
 # CONFIG_NET_KEY_MIGRATE is not set
 # CONFIG_NET_L3_MASTER_DEV is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][F][PATCH 1/1] Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m

Khalid Elmously
In reply to this post by Khalid Elmously
BugLink: https://bugs.launchpad.net/bugs/1899832

There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.

Signed-off-by: Khalid Elmously <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 9bf9be9eb4bd..ecad0df5219f 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1140,7 +1140,7 @@ CONFIG_INET_ESP_OFFLOAD=m
 CONFIG_INET_IPCOMP=m
 # CONFIG_INET_RAW_DIAG is not set
 CONFIG_INET_TCP_DIAG=y
-CONFIG_INET_TUNNEL=y
+CONFIG_INET_TUNNEL=m
 # CONFIG_INET_UDP_DIAG is not set
 CONFIG_INET_XFRM_TUNNEL=m
 # CONFIG_INFINIBAND is not set
@@ -1231,7 +1231,7 @@ CONFIG_IPV6_NDISC_NODETYPE=y
 # CONFIG_IPV6_ROUTER_PREF is not set
 # CONFIG_IPV6_SEG6_HMAC is not set
 # CONFIG_IPV6_SEG6_LWTUNNEL is not set
-CONFIG_IPV6_SIT=y
+CONFIG_IPV6_SIT=m
 # CONFIG_IPV6_SIT_6RD is not set
 CONFIG_IPV6_SUBTREES=y
 # CONFIG_IPV6_TUNNEL is not set
@@ -1661,9 +1661,9 @@ CONFIG_NET_FLOW_LIMIT=y
 # CONFIG_NET_IFE is not set
 CONFIG_NET_INGRESS=y
 # CONFIG_NET_IPGRE_DEMUX is not set
-CONFIG_NET_IPIP=y
+CONFIG_NET_IPIP=m
 # CONFIG_NET_IPVTI is not set
-CONFIG_NET_IP_TUNNEL=y
+CONFIG_NET_IP_TUNNEL=m
 CONFIG_NET_KEY=m
 # CONFIG_NET_KEY_MIGRATE is not set
 CONFIG_NET_L3_MASTER_DEV=y
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][X][PATCH 1/1] Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m

Khalid Elmously
In reply to this post by Khalid Elmously
BugLink: https://bugs.launchpad.net/bugs/1899832

There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.

Signed-off-by: Khalid Elmously <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index db405d7ce72d6..f5d48d9f154b2 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -880,7 +880,7 @@ CONFIG_INET_AH=m
 CONFIG_INET_ESP=m
 CONFIG_INET_IPCOMP=m
 # CONFIG_INET_LRO is not set
-CONFIG_INET_TUNNEL=y
+CONFIG_INET_TUNNEL=m
 CONFIG_INET_XFRM_MODE_BEET=m
 CONFIG_INET_XFRM_MODE_TRANSPORT=m
 CONFIG_INET_XFRM_MODE_TUNNEL=m
@@ -976,7 +976,7 @@ CONFIG_IPV6_MULTIPLE_TABLES=y
 CONFIG_IPV6_NDISC_NODETYPE=y
 # CONFIG_IPV6_OPTIMISTIC_DAD is not set
 # CONFIG_IPV6_ROUTER_PREF is not set
-CONFIG_IPV6_SIT=y
+CONFIG_IPV6_SIT=m
 # CONFIG_IPV6_SIT_6RD is not set
 CONFIG_IPV6_SUBTREES=y
 # CONFIG_IPV6_TUNNEL is not set
@@ -1415,9 +1415,9 @@ CONFIG_NET_FLOW_LIMIT=y
 # CONFIG_NET_FOU_IP_TUNNELS is not set
 CONFIG_NET_INGRESS=y
 # CONFIG_NET_IPGRE_DEMUX is not set
-CONFIG_NET_IPIP=y
+CONFIG_NET_IPIP=m
 CONFIG_NET_IPVTI=m
-CONFIG_NET_IP_TUNNEL=y
+CONFIG_NET_IP_TUNNEL=m
 CONFIG_NET_KEY=m
 # CONFIG_NET_KEY_MIGRATE is not set
 # CONFIG_NET_L3_MASTER_DEV is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][X][B][F][PATCH 0/1] Change NET_IPIP and IPV6_SIT to modules

Seth Forshee
In reply to this post by Khalid Elmously
On Wed, Oct 14, 2020 at 10:18:21PM -0400, Khalid Elmously wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899832
>
> There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.

Shouldn't this go to groovy/unstable too?

>
>
> Khalid Elmously (1):
>   Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m
>
>  debian.kvm/config/config.common.ubuntu | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK/Cmnt: [SRU][X][B][F][PATCH 0/1] Change NET_IPIP and IPV6_SIT to modules

Stefan Bader-2
In reply to this post by Khalid Elmously
On 15.10.20 04:18, Khalid Elmously wrote:

> BugLink: https://bugs.launchpad.net/bugs/1899832
>
> There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.
>
>
> Khalid Elmously (1):
>   Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m
>
>  debian.kvm/config/config.common.ubuntu | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
The subject line is confusingly written as if the patches were for the primary
kernels. And there is a Groovy/linux-kvm which should be checked and fixed as
well. So subject should be "[SRU G,F,B,X/linux-kvm] ...". Also the bug report
does not contain a complete SRU justification template and the regression
potential should rather be something like "Early boot code might have been
depending on the net devices being present, however that can be mitigated by
probing for those". And speaking of that, did we check that the packaging of kvm
kernels automatically picks those modules up and into linux-modules?
[also the bug report could be nominated for all the series this should be
considered for]

-Stefan


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment