[SRU][Xenial][PATCH 0/1] Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[SRU][Xenial][PATCH 0/1] Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1667323

== SRU Justification ==
This bug is a regression in Xenial.  The backlight control does not work
and there are no entries in /sys/class/backlight.  A bisect was done.  It was
found that commit 6276e53fa8c0 introduced this regression.  Commit 6276e53fa8c0
has already been reverted in mainline by commit fd25ea29093e275195d0ae8b2573021a1c98959f.

This revert landed in mainline in 4.10-rc6 and was cc'd to stable.  
However, it has not been applied to upstream stable 4.4.y.

This SRU request is to have commit fd25ea29093e275195d0ae8b2573021a1c98959f added
to Xenail.  I will contact upstream to also request it in 4.4.y stable.

== Fix ==
commit fd25ea29093e275195d0ae8b2573021a1c98959f
Author: Hans de Goede <[hidden email]>
Date:   Sun Jan 22 13:24:05 2017 +0100

    Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.



Hans de Goede (1):
  Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

 drivers/acpi/video_detect.c | 11 -----------
 1 file changed, 11 deletions(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[SRU][Xenial][PATCH 1/1] Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

Joseph Salisbury-3
From: Hans de Goede <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1667323

Revert commit 6276e53fa8c0 (ACPI / video: Add force_native quirk for
HP Pavilion dv6).

In the commit message for the quirk this revert removes I wrote:

"Note that there are quite a few HP Pavilion dv6 variants, some
woth ATI and some with NVIDIA hybrid gfx, both seem to need this
quirk to have working backlight control. There are also some versions
with only Intel integrated gfx, these may not need this quirk, but it
should not hurt there."

Unfortunately that seems wrong, I've already received 2 reports of
this commit causing regressions on some dv6 variants (at least one
of which actually has a nvidia GPU). So it seems that HP has made a
mess here by using the same model-name both in marketing and in the
DMI data for many different variants. Some of which need
acpi_backlight=native for functional backlight control (as the
quirk this commit reverts was doing), where as others are broken by
it. So lets get back to the old sitation so as to avoid regressing
on models which used to work without any kernel cmdline arguments
before.

Fixes: 6276e53fa8c0 (ACPI / video: Add force_native quirk for HP Pavilion dv6)
Signed-off-by: Hans de Goede <[hidden email]>
Signed-off-by: Rafael J. Wysocki <[hidden email]>
(cherry picked from commit fd25ea29093e275195d0ae8b2573021a1c98959f)
Signed-off-by: Joseph Salisbury <[hidden email]>
---
 drivers/acpi/video_detect.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index b48ecbf..5e5e1ee 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -280,17 +280,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
  DMI_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L702X"),
  },
  },
- {
- /* https://bugzilla.redhat.com/show_bug.cgi?id=1204476 */
- /* https://bugs.launchpad.net/ubuntu/+source/linux-lts-trusty/+bug/1416940 */
- .callback = video_detect_force_native,
- .ident = "HP Pavilion dv6",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
- DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
- },
- },
-
  { },
 };
 
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [SRU][Xenial][PATCH 1/1] Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

Colin Ian King-2
On 10/04/17 13:37, Joseph Salisbury wrote:

> From: Hans de Goede <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1667323
>
> Revert commit 6276e53fa8c0 (ACPI / video: Add force_native quirk for
> HP Pavilion dv6).
>
> In the commit message for the quirk this revert removes I wrote:
>
> "Note that there are quite a few HP Pavilion dv6 variants, some
> woth ATI and some with NVIDIA hybrid gfx, both seem to need this
> quirk to have working backlight control. There are also some versions
> with only Intel integrated gfx, these may not need this quirk, but it
> should not hurt there."
>
> Unfortunately that seems wrong, I've already received 2 reports of
> this commit causing regressions on some dv6 variants (at least one
> of which actually has a nvidia GPU). So it seems that HP has made a
> mess here by using the same model-name both in marketing and in the
> DMI data for many different variants. Some of which need
> acpi_backlight=native for functional backlight control (as the
> quirk this commit reverts was doing), where as others are broken by
> it. So lets get back to the old sitation so as to avoid regressing
> on models which used to work without any kernel cmdline arguments
> before.
>
> Fixes: 6276e53fa8c0 (ACPI / video: Add force_native quirk for HP Pavilion dv6)
> Signed-off-by: Hans de Goede <[hidden email]>
> Signed-off-by: Rafael J. Wysocki <[hidden email]>
> (cherry picked from commit fd25ea29093e275195d0ae8b2573021a1c98959f)
> Signed-off-by: Joseph Salisbury <[hidden email]>
> ---
>  drivers/acpi/video_detect.c | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_det`ect.c
> index b48ecbf..5e5e1ee 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -280,17 +280,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>   DMI_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L702X"),
>   },
>   },
> - {
> - /* https://bugzilla.redhat.com/show_bug.cgi?id=1204476 */
> - /* https://bugs.launchpad.net/ubuntu/+source/linux-lts-trusty/+bug/1416940 */
> - .callback = video_detect_force_native,
> - .ident = "HP Pavilion dv6",
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion dv6 Notebook PC"),
> - },
> - },
> -
>   { },
>  };
>  
>
Sane looking bisect results, limited regression potential to just one
device and is an upstream fix, so:

Acked-by: Colin Ian King <[hidden email]>

Thanks Joe.


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [SRU][Xenial][PATCH 1/1] Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

Marcelo Cerri
In reply to this post by Joseph Salisbury-3
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

APPLIED[X/master-next]: [SRU][Xenial][PATCH 1/1] Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"

Stefan Bader-2
In reply to this post by Joseph Salisbury-3



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Loading...