[SRU] [Xenial] [PATCH 0/1] Support UVC1.5 Camera for Xenial

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Xenial] [PATCH 0/1] Support UVC1.5 Camera for Xenial

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1773905

===SRU Justification===
[Impact]
UVC1.5 USB class is not in UVC driver's device ID, so the driver doesn't
get loaded.

[Test]
See if the uvcvideo module is loaded for UVC1.5 camera.
I can confirm with this commit, uvcvideo.ko is loaded. In addition,
cheese can use the webcam without issue.

[Fix]
Apparently I forgot to SRU this commit for LP: #1763748 to support
UVC1.5 camera for Xenial.
Add UVC1.5 device id to uvcvideo.

[Regression Potential]
Low. The short control message is already fixed by another commit.

Laurent Pinchart (1):
  [media] uvcvideo: Enable UVC 1.5 device detection

 drivers/media/usb/uvc/uvc_driver.c | 3 ++-
 include/uapi/linux/usb/video.h     | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU] [Xenial] [PATCH 1/1] [media] uvcvideo: Enable UVC 1.5 device detection

Kai-Heng Feng
From: Laurent Pinchart <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1773905

UVC 1.5 devices report a bInterfaceProtocol value set to 1 in their
interface descriptors. The uvcvideo driver only matches on
bInterfaceProtocol 0, preventing those devices from being detected.

More changes to the driver are needed for full UVC 1.5 compatibility.
However, at least the UVC 1.5 Microsoft Surface Pro 3 cameras have been
reported to work out of the box with the driver with an updated match
table.

Enable UVC 1.5 support in the match table to support the devices that
can work with the current driver implementation. Devices that can't will
fail, but that's hardly a regression as they're currently not detected
at all anyway.

Signed-off-by: Laurent Pinchart <[hidden email]>
Signed-off-by: Mauro Carvalho Chehab <[hidden email]>
(cherry picked from commit 8afe97be37fad85b1ad7d4ab5d6b06f6fc04a274)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/media/usb/uvc/uvc_driver.c | 3 ++-
 include/uapi/linux/usb/video.h     | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 9b8ac20f1c1a..4a075356e6af 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2675,7 +2675,8 @@ static struct usb_device_id uvc_ids[] = {
   .bInterfaceProtocol = 0,
   .driver_info = UVC_QUIRK_FORCE_Y8 },
  /* Generic USB Video Class */
- { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, 0) },
+ { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_UNDEFINED) },
+ { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_15) },
  {}
 };
 
diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h
index 3b3b95e01f71..69ab695fad2e 100644
--- a/include/uapi/linux/usb/video.h
+++ b/include/uapi/linux/usb/video.h
@@ -28,6 +28,7 @@
 
 /* A.3. Video Interface Protocol Codes */
 #define UVC_PC_PROTOCOL_UNDEFINED 0x00
+#define UVC_PC_PROTOCOL_15 0x01
 
 /* A.5. Video Class-Specific VC Interface Descriptor Subtypes */
 #define UVC_VC_DESCRIPTOR_UNDEFINED 0x00
--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Xenial] [PATCH 0/1] Support UVC1.5 Camera for Xenial

AceLan Kao
In reply to this post by Kai-Heng Feng
Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Xenial] [PATCH 0/1] Support UVC1.5 Camera for Xenial

Kleber Souza
In reply to this post by Kai-Heng Feng
On 05/28/18 23:29, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1773905
>
> ===SRU Justification===
> [Impact]
> UVC1.5 USB class is not in UVC driver's device ID, so the driver doesn't
> get loaded.
>
> [Test]
> See if the uvcvideo module is loaded for UVC1.5 camera.
> I can confirm with this commit, uvcvideo.ko is loaded. In addition,
> cheese can use the webcam without issue.
>
> [Fix]
> Apparently I forgot to SRU this commit for LP: #1763748 to support
> UVC1.5 camera for Xenial.
> Add UVC1.5 device id to uvcvideo.
>
> [Regression Potential]
> Low. The short control message is already fixed by another commit.
>
> Laurent Pinchart (1):
>   [media] uvcvideo: Enable UVC 1.5 device detection
>
>  drivers/media/usb/uvc/uvc_driver.c | 3 ++-
>  include/uapi/linux/usb/video.h     | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU] [Xenial] [PATCH 0/1] Support UVC1.5 Camera for Xenial

Juerg Haefliger
In reply to this post by Kai-Heng Feng
Applied to xenial/master-next.

...Juerg

On 05/29/2018 08:29 AM, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1773905
>
> ===SRU Justification===
> [Impact]
> UVC1.5 USB class is not in UVC driver's device ID, so the driver doesn't
> get loaded.
>
> [Test]
> See if the uvcvideo module is loaded for UVC1.5 camera.
> I can confirm with this commit, uvcvideo.ko is loaded. In addition,
> cheese can use the webcam without issue.
>
> [Fix]
> Apparently I forgot to SRU this commit for LP: #1763748 to support
> UVC1.5 camera for Xenial.
> Add UVC1.5 device id to uvcvideo.
>
> [Regression Potential]
> Low. The short control message is already fixed by another commit.
>
> Laurent Pinchart (1):
>   [media] uvcvideo: Enable UVC 1.5 device detection
>
>  drivers/media/usb/uvc/uvc_driver.c | 3 ++-
>  include/uapi/linux/usb/video.h     | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment