[SRU][Xenial][PATCH 0/1] UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][PATCH 0/1] UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1741934

== SRU Justification ==
A regression was introduced when upstream 4.4 stable commit 20cbe9a3aa2 was
back ported to Xenial.  The back port failed to remove a call to kfree() in
release_ds_buffer().  This was causing a kernel oops on many different systems.

This commit removes the kfree() like it should have been in the original commit.  

== Fix ==
Author: Joseph Salisbury <[hidden email]>
Date:   Mon Jan 8 17:18:32 2018 +0000
    UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

== Regression Potential ==
Low.  This patch is fixing a current regression.  It is just doing
what the original commit meant to do.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.


Joseph Salisbury (1):
  Test kernel for lp1741934

 arch/x86/events/intel/ds.c | 1 -
 1 file changed, 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][PATCH 1/1] UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1741934

There was a back port of upstream 4.4 stable commit 20cbe9a3aa2e341824da57ce0ac6d52cbffaa570
to Xenial which failed remove a kfree() from release_ds_buffer().    

This commit does only that.  It removes this extra kfree().  This left over
kfree was causing a kernel trace on many systems as reported in the bug.

This commit removes the kfree() like it should have been in the original commit.  


Signed-off-by: Joseph Salisbury <[hidden email]>
---
 arch/x86/events/intel/ds.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/events/intel/ds.c b/arch/x86/events/intel/ds.c
index c236f3d..6eca9fb 100644
--- a/arch/x86/events/intel/ds.c
+++ b/arch/x86/events/intel/ds.c
@@ -415,7 +415,6 @@ static void release_ds_buffer(int cpu)
  return;
 
  per_cpu(cpu_hw_events, cpu).ds = NULL;
- kfree(ds);
 }
 
 void release_ds_buffers(void)
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Xenial][PATCH 1/1] UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

brad.figg
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Xenial][PATCH 1/1] UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

Marcelo Henrique Cerri
In reply to this post by Joseph Salisbury-3
Acked-by: Marcelo Henrique Cerri <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Xenial][PATCH 1/1] UBUNTU: SAUCE: kaiser: fix perf crashes - fix to original commit

Marcelo Henrique Cerri
In reply to this post by Joseph Salisbury-3
--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (484 bytes) Download Attachment