[SRU][Xenial][PATCH 0/1] tty/hvc: Use opal irqchip interface if available

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][PATCH 0/1] tty/hvc: Use opal irqchip interface if available

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1728098

== SRU Justification ==
This bug is fixed by commit 00dab8187e18.  The commit updates the hvc
driver to use the OPAL irqchip if made available by the running firmware.
If it is not present, the driver falls back to the existing OPAL event number.  

Commit 00dab8187e18 was added to mainline is v4.8-rc1, so it is not needed in
releases newer than Xenial.  The commit is a clean cherry pick in Xenial.

 
== Fix ==
commit 00dab8187e182da41122f66c207707b192509df4
Author: Sam Mendoza-Jonas <[hidden email]>
Date:   Mon Jul 11 13:38:58 2016 +1000

    tty/hvc: Use opal irqchip interface if available


== Regression Potential ==
This change is specific to the hvc driver and has been in mainline since v4.8-rc1
without any issues reported.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.
Sam Mendoza-Jonas (1):
  tty/hvc: Use opal irqchip interface if available

 drivers/tty/hvc/hvc_opal.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][PATCH 1/1] tty/hvc: Use opal irqchip interface if available

Joseph Salisbury-3
From: Sam Mendoza-Jonas <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1728098

Update the hvc driver to use the OPAL irqchip if made available by the
running firmware. If it is not present, the driver falls back to the
existing OPAL event number.

Signed-off-by: Samuel Mendoza-Jonas <[hidden email]>
Signed-off-by: Michael Ellerman <[hidden email]>
(cherry picked from commit 00dab8187e182da41122f66c207707b192509df4)
Signed-off-by: Joseph Salisbury <[hidden email]>
---
 drivers/tty/hvc/hvc_opal.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index b7cd0ae..5107993 100644
--- a/drivers/tty/hvc/hvc_opal.c
+++ b/drivers/tty/hvc/hvc_opal.c
@@ -214,7 +214,13 @@ static int hvc_opal_probe(struct platform_device *dev)
  dev->dev.of_node->full_name,
  boot ? " (boot console)" : "");
 
- irq = opal_event_request(ilog2(OPAL_EVENT_CONSOLE_INPUT));
+ irq = irq_of_parse_and_map(dev->dev.of_node, 0);
+ if (!irq) {
+ pr_info("hvc%d: No interrupts property, using OPAL event\n",
+ termno);
+ irq = opal_event_request(ilog2(OPAL_EVENT_CONSOLE_INPUT));
+ }
+
  if (!irq) {
  pr_err("hvc_opal: Unable to map interrupt for device %s\n",
  dev->dev.of_node->full_name);
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Xenial][PATCH 0/1] tty/hvc: Use opal irqchip interface if available

Kamal Mostafa-2
In reply to this post by Joseph Salisbury-3
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Xenial][PATCH 1/1] tty/hvc: Use opal irqchip interface if available

Stefan Bader-2
In reply to this post by Joseph Salisbury-3
On 08.11.2017 22:02, Joseph Salisbury wrote:

> From: Sam Mendoza-Jonas <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1728098
>
> Update the hvc driver to use the OPAL irqchip if made available by the
> running firmware. If it is not present, the driver falls back to the
> existing OPAL event number.
>
> Signed-off-by: Samuel Mendoza-Jonas <[hidden email]>
> Signed-off-by: Michael Ellerman <[hidden email]>
> (cherry picked from commit 00dab8187e182da41122f66c207707b192509df4)
> Signed-off-by: Joseph Salisbury <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  drivers/tty/hvc/hvc_opal.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
> index b7cd0ae..5107993 100644
> --- a/drivers/tty/hvc/hvc_opal.c
> +++ b/drivers/tty/hvc/hvc_opal.c
> @@ -214,7 +214,13 @@ static int hvc_opal_probe(struct platform_device *dev)
>   dev->dev.of_node->full_name,
>   boot ? " (boot console)" : "");
>  
> - irq = opal_event_request(ilog2(OPAL_EVENT_CONSOLE_INPUT));
> + irq = irq_of_parse_and_map(dev->dev.of_node, 0);
> + if (!irq) {
> + pr_info("hvc%d: No interrupts property, using OPAL event\n",
> + termno);
> + irq = opal_event_request(ilog2(OPAL_EVENT_CONSOLE_INPUT));
> + }
> +
>   if (!irq) {
>   pr_err("hvc_opal: Unable to map interrupt for device %s\n",
>   dev->dev.of_node->full_name);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Xenial][PATCH 0/1] tty/hvc: Use opal irqchip interface if available

Stefan Bader-2
In reply to this post by Joseph Salisbury-3
On 08.11.2017 22:02, Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1728098
>
> == SRU Justification ==
> This bug is fixed by commit 00dab8187e18.  The commit updates the hvc
> driver to use the OPAL irqchip if made available by the running firmware.
> If it is not present, the driver falls back to the existing OPAL event number.  
>
> Commit 00dab8187e18 was added to mainline is v4.8-rc1, so it is not needed in
> releases newer than Xenial.  The commit is a clean cherry pick in Xenial.
>
>  
> == Fix ==
> commit 00dab8187e182da41122f66c207707b192509df4
> Author: Sam Mendoza-Jonas <[hidden email]>
> Date:   Mon Jul 11 13:38:58 2016 +1000
>
>     tty/hvc: Use opal irqchip interface if available
>
>
> == Regression Potential ==
> This change is specific to the hvc driver and has been in mainline since v4.8-rc1
> without any issues reported.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> Sam Mendoza-Jonas (1):
>   tty/hvc: Use opal irqchip interface if available
>
>  drivers/tty/hvc/hvc_opal.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
Applied to Xenial master-next. Thanks.


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment