[SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

Seth Forshee
BugLink: http://bugs.launchpad.net/bugs/1752536

We ship this firmware but it fails to load because it is not
present in the initrd. Add a MODULE_FIRMWARE statement to fix
this.

Signed-off-by: Seth Forshee <[hidden email]>
---
 ubuntu/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
index 91eb151242a1..2b3b428d9cd2 100644
--- a/ubuntu/i915/intel_csr.c
+++ b/ubuntu/i915/intel_csr.c
@@ -42,6 +42,7 @@
  */
 
 #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
+MODULE_FIRMWARE(I915_CSR_KBL);
 #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 1)
 
 #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

Juerg Haefliger
On 04/24/2018 06:18 PM, Seth Forshee wrote:

> BugLink: http://bugs.launchpad.net/bugs/1752536
>
> We ship this firmware but it fails to load because it is not
> present in the initrd. Add a MODULE_FIRMWARE statement to fix
> this.
>
> Signed-off-by: Seth Forshee <[hidden email]>
> ---
>  ubuntu/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
> index 91eb151242a1..2b3b428d9cd2 100644
> --- a/ubuntu/i915/intel_csr.c
> +++ b/ubuntu/i915/intel_csr.c
> @@ -42,6 +42,7 @@
>   */
>  
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
> +MODULE_FIRMWARE(I915_CSR_KBL);
>  #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 1)
Acked-by: Juerg Haefliger <[hidden email]>

but hat firmware blob seems to missing in linux-firmware in Xenial. Or
am I looking in the wrong place?

...Juerg



>  #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

Seth Forshee
On Wed, Apr 25, 2018 at 08:44:24AM +0200, Juerg Haefliger wrote:

> On 04/24/2018 06:18 PM, Seth Forshee wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1752536
> >
> > We ship this firmware but it fails to load because it is not
> > present in the initrd. Add a MODULE_FIRMWARE statement to fix
> > this.
> >
> > Signed-off-by: Seth Forshee <[hidden email]>
> > ---
> >  ubuntu/i915/intel_csr.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
> > index 91eb151242a1..2b3b428d9cd2 100644
> > --- a/ubuntu/i915/intel_csr.c
> > +++ b/ubuntu/i915/intel_csr.c
> > @@ -42,6 +42,7 @@
> >   */
> >  
> >  #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
> > +MODULE_FIRMWARE(I915_CSR_KBL);
> >  #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 1)
>
> Acked-by: Juerg Haefliger <[hidden email]>
>
> but hat firmware blob seems to missing in linux-firmware in Xenial. Or
> am I looking in the wrong place?

It looks like it's there to me (albeit as a symlink), should be in
/lib/firmware/i915.

Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

Juerg Haefliger
On 04/25/2018 02:53 PM, Seth Forshee wrote:

> On Wed, Apr 25, 2018 at 08:44:24AM +0200, Juerg Haefliger wrote:
>> On 04/24/2018 06:18 PM, Seth Forshee wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1752536
>>>
>>> We ship this firmware but it fails to load because it is not
>>> present in the initrd. Add a MODULE_FIRMWARE statement to fix
>>> this.
>>>
>>> Signed-off-by: Seth Forshee <[hidden email]>
>>> ---
>>>  ubuntu/i915/intel_csr.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
>>> index 91eb151242a1..2b3b428d9cd2 100644
>>> --- a/ubuntu/i915/intel_csr.c
>>> +++ b/ubuntu/i915/intel_csr.c
>>> @@ -42,6 +42,7 @@
>>>   */
>>>  
>>>  #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
>>> +MODULE_FIRMWARE(I915_CSR_KBL);
>>>  #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 1)
>>
>> Acked-by: Juerg Haefliger <[hidden email]>
>>
>> but hat firmware blob seems to missing in linux-firmware in Xenial. Or
>> am I looking in the wrong place?
>
> It looks like it's there to me (albeit as a symlink), should be in
> /lib/firmware/i915.
It sure is there. Should have looked at the file list in the -updates
package :-(

Sorry for the noise.

...Juerg

> Seth
>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

Kleber Souza
In reply to this post by Seth Forshee
On 04/24/18 18:18, Seth Forshee wrote:
> BugLink: http://bugs.launchpad.net/bugs/1752536
>
> We ship this firmware but it fails to load because it is not
> present in the initrd. Add a MODULE_FIRMWARE statement to fix
> this.
>
> Signed-off-by: Seth Forshee <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  ubuntu/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
> index 91eb151242a1..2b3b428d9cd2 100644
> --- a/ubuntu/i915/intel_csr.c
> +++ b/ubuntu/i915/intel_csr.c
> @@ -42,6 +42,7 @@
>   */
>  
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
> +MODULE_FIRMWARE(I915_CSR_KBL);
>  #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 1)
>  
>  #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Xenial][PATCH] UBUNTU: ubuntu: i915_bpo - Add MODULE_FIRMWARE for Geminilake's DMC

Kleber Souza
In reply to this post by Seth Forshee
On 04/24/18 18:18, Seth Forshee wrote:

> BugLink: http://bugs.launchpad.net/bugs/1752536
>
> We ship this firmware but it fails to load because it is not
> present in the initrd. Add a MODULE_FIRMWARE statement to fix
> this.
>
> Signed-off-by: Seth Forshee <[hidden email]>
> ---
>  ubuntu/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ubuntu/i915/intel_csr.c b/ubuntu/i915/intel_csr.c
> index 91eb151242a1..2b3b428d9cd2 100644
> --- a/ubuntu/i915/intel_csr.c
> +++ b/ubuntu/i915/intel_csr.c
> @@ -42,6 +42,7 @@
>   */
>  
>  #define I915_CSR_KBL "i915/kbl_dmc_ver1.bin"
> +MODULE_FIRMWARE(I915_CSR_KBL);
>  #define KBL_CSR_VERSION_REQUIRED CSR_VERSION(1, 1)
>  
>  #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
>

Applied to xenial/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team