[SRU][Xenial][Yakkety][Zesty][Artful][PATCH 0/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][Yakkety][Zesty][Artful][PATCH 0/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1684971

== SRU Justification ==
This patch fixes a problem introduced by mainline commit 4a9b0933bdfc.
Some drivers were expecting a u16 instead of
a u32 for PCI device serial numbers, as observed by Oops and hangs in
Azure on NC and NV GPU instances.

This patch has been submitted upstream, but is not in mainline or -next
yet, which is why I'm submitting it as SAUCE.

Upstream thread:
https://lkml.org/lkml/2017/4/20/729

== Fix ==
Author: Haiyang Zhang <[hidden email]>
Date:   Thu Apr 20 13:54:14 2017 -0400

        pci-hyperv: Use only 16 bit integer for PCI domain

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.



Haiyang Zhang (1):
  This patch uses the lower 16 bits of the serial number as PCI    
    domain, otherwise some drivers may not be able to handle it.

 drivers/pci/host/pci-hyperv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial][Yakkety][Zesty][Artful][PATCH 1/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Joseph Salisbury-3
From: Haiyang Zhang <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1684971

Signed-off-by: Haiyang Zhang <[hidden email]>
Signed-off-by: Joseph Salisbury <[hidden email]>

---
 drivers/pci/host/pci-hyperv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index ada9856..5dcc0aef 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -1326,9 +1326,11 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
  * can have shorter names than based on the bus instance UUID.
  * Only the first device serial number is used for domain, so the
  * domain number will not change after the first device is added.
+ * The lower 16 bits of the serial number is used, otherwise some
+ * drivers may not be able to handle it.
  */
  if (list_empty(&hbus->children))
- hbus->sysdata.domain = desc->ser;
+ hbus->sysdata.domain = desc->ser & 0xFFFF;
  list_add_tail(&hpdev->list_entry, &hbus->children);
  spin_unlock_irqrestore(&hbus->device_list_lock, flags);
  return hpdev;
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Xenial][Yakkety][Zesty][Artful][PATCH 0/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Brad Figg-2
In reply to this post by Joseph Salisbury-3
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU][Xenial][Yakkety][Zesty][Artful][PATCH 0/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Stefan Bader-2
In reply to this post by Joseph Salisbury-3
On 25.04.2017 01:38, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1684971
>
> == SRU Justification ==
> This patch fixes a problem introduced by mainline commit 4a9b0933bdfc.
> Some drivers were expecting a u16 instead of
> a u32 for PCI device serial numbers, as observed by Oops and hangs in
> Azure on NC and NV GPU instances.

That is the 3rd time hyperv code needs urgent fixes and at least the 2nd time
this is caused by broken upstream submissions. Maybe someone should tell those
guys about the benefits of testing...

Otherwise looks to be doing what it claims.

-Stefan

>
> This patch has been submitted upstream, but is not in mainline or -next
> yet, which is why I'm submitting it as SAUCE.
>
> Upstream thread:
> https://lkml.org/lkml/2017/4/20/729
>
> == Fix ==
> Author: Haiyang Zhang <[hidden email]>
> Date:   Thu Apr 20 13:54:14 2017 -0400
>
> pci-hyperv: Use only 16 bit integer for PCI domain
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
>
>
> Haiyang Zhang (1):
>   This patch uses the lower 16 bits of the serial number as PCI    
>     domain, otherwise some drivers may not be able to handle it.
>
>  drivers/pci/host/pci-hyperv.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Xenial][PATCH 1/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Kleber Souza
In reply to this post by Joseph Salisbury-3
Reply | Threaded
Open this post in threaded view
|

APPLIED to artful: [SRU][Xenial][Yakkety][Zesty][Artful][PATCH 1/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Seth Forshee
In reply to this post by Joseph Salisbury-3
On Mon, Apr 24, 2017 at 07:38:08PM -0400, Joseph Salisbury wrote:
> From: Haiyang Zhang <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1684971
>
> Signed-off-by: Haiyang Zhang <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>

Applied to artful master-next.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU][Xenial][Yakkety][Zesty][Artful][PATCH 0/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Joshua R. Poulson
In reply to this post by Stefan Bader-2
Spanking received, but these three patches that affect totally
different areas of the Hyper-V device driver is at least a two beer
story some day.

On Mon, Apr 24, 2017 at 10:46 PM, Stefan Bader
<[hidden email]> wrote:

> On 25.04.2017 01:38, Joseph Salisbury wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1684971
>>
>> == SRU Justification ==
>> This patch fixes a problem introduced by mainline commit 4a9b0933bdfc.
>> Some drivers were expecting a u16 instead of
>> a u32 for PCI device serial numbers, as observed by Oops and hangs in
>> Azure on NC and NV GPU instances.
>
> That is the 3rd time hyperv code needs urgent fixes and at least the 2nd time
> this is caused by broken upstream submissions. Maybe someone should tell those
> guys about the benefits of testing...
>
> Otherwise looks to be doing what it claims.
>
> -Stefan
>>
>> This patch has been submitted upstream, but is not in mainline or -next
>> yet, which is why I'm submitting it as SAUCE.
>>
>> Upstream thread:
>> https://lkml.org/lkml/2017/4/20/729
>>
>> == Fix ==
>> Author: Haiyang Zhang <[hidden email]>
>> Date:   Thu Apr 20 13:54:14 2017 -0400
>>
>>       pci-hyperv: Use only 16 bit integer for PCI domain
>>
>> == Test Case ==
>> A test kernel was built with this patch and tested by the original bug reporter.
>> The bug reporter states the test kernel resolved the bug.
>>
>>
>>
>> Haiyang Zhang (1):
>>   This patch uses the lower 16 bits of the serial number as PCI
>>     domain, otherwise some drivers may not be able to handle it.
>>
>>  drivers/pci/host/pci-hyperv.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [Yakkety]: [SRU][Xenial][Yakkety][Zesty][Artful][PATCH 1/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Kleber Souza
In reply to this post by Joseph Salisbury-3
Reply | Threaded
Open this post in threaded view
|

APPLIED [Zesty]: [SRU][Xenial][Yakkety][Zesty][Artful][PATCH 1/1] UBUNTU: SAUCE: pci-hyperv: Use only 16 bit integer for PCI domain

Kleber Souza
In reply to this post by Joseph Salisbury-3