[SRU] [Xenial] [snapdragon] [ PATCH 0/1 ] Fixes for LP:1776725

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Xenial] [snapdragon] [ PATCH 0/1 ] Fixes for LP:1776725

Ondrej Kubik

SRU Justification


Impact:

    LEDs on dragonboard401c are not fully supported. Particularly WiFi and BT activity LEDs, heartbeat user LEDs


Step to reproduce:

 - Boot DragonBoard 410c and observer BT, WiFI LEDs and User LEDs


Expected result:

 LEDs are switched ON correctly


Actual result:

 BT, WiFi and some user LEDs are now switched ON


TEST CASE:

 - boot device

 - BT, WiFi and User LEDs should be switched ON accordingly


Ondrej Kubik (1):

  UBUNTU: SAUCE: dtb: updating custom apq8016 for snappy to fix LED

    functionality


 arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi | 8 ++++----

 1 file changed, 4 insertions(+), 4 deletions(-)

-- 

2.7.4



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [SRU] [Xenial] [snapdragon] [ PATCH 0/1 ] Fixes for LP:1776725

Kleber Souza
On 06/26/18 19:10, Ondrej Kubik wrote:

> SRU Justification
>
>
> Impact:
>
>     LEDs on dragonboard401c are not fully supported. Particularly WiFi
> and BT activity LEDs, heartbeat user LEDs
>
>
> Step to reproduce:
>
>  - Boot DragonBoard 410c and observer BT, WiFI LEDs and User LEDs
>
>
> Expected result:
>
>  LEDs are switched ON correctly
>
>
> Actual result:
>
>  BT, WiFi and some user LEDs are now switched ON
>
>
> TEST CASE:
>
>  - boot device
>
>  - BT, WiFi and User LEDs should be switched ON accordingly
>
>
> Ondrej Kubik (1):
>
>   UBUNTU: SAUCE: dtb: updating custom apq8016 for snappy to fix LED
>
>     functionality
>
>
>  arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi | 8 ++++----
>
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> -- 
>
> 2.7.4
>
>
>
>

Hi Ondrej,

Could you please send the patches to the mailing-list in plain text
format only, in a way that we can apply them using 'git am'?

Also it makes our review process much easier if the patches are grouped
together in a thread, i.e. all the patches sent as reply to the cover
letter, in a fashion as 'git send-email --no-chain-reply-to' does.


Thank you,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [SRU] [Xenial] [snapdragon] [ PATCH 0/1 ] Fixes for LP:1776725

Kleber Souza
On 06/28/18 14:26, Kleber Souza wrote:

> On 06/26/18 19:10, Ondrej Kubik wrote:
>> SRU Justification
>>
>>
>> Impact:
>>
>>     LEDs on dragonboard401c are not fully supported. Particularly WiFi
>> and BT activity LEDs, heartbeat user LEDs
>>
>>
>> Step to reproduce:
>>
>>  - Boot DragonBoard 410c and observer BT, WiFI LEDs and User LEDs
>>
>>
>> Expected result:
>>
>>  LEDs are switched ON correctly
>>
>>
>> Actual result:
>>
>>  BT, WiFi and some user LEDs are now switched ON
>>
>>
>> TEST CASE:
>>
>>  - boot device
>>
>>  - BT, WiFi and User LEDs should be switched ON accordingly
>>
>>
>> Ondrej Kubik (1):
>>
>>   UBUNTU: SAUCE: dtb: updating custom apq8016 for snappy to fix LED
>>
>>     functionality
>>
>>
>>  arch/arm64/boot/dts/qcom/apq8016-sbc-snappy.dtsi | 8 ++++----
>>
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> -- 
>>
>> 2.7.4
>>
>>
>>
>>
>
> Hi Ondrej,
>
> Could you please send the patches to the mailing-list in plain text
> format only, in a way that we can apply them using 'git am'?
>
> Also it makes our review process much easier if the patches are grouped
> together in a thread, i.e. all the patches sent as reply to the cover
> letter, in a fashion as 'git send-email --no-chain-reply-to' does.
>
>
> Thank you,
> Kleber
>

Hi Ondrej,

If you are not familiar with the general process of sending patches to a
mailing list, this documentation from the mainline kernel could be very
useful:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html


Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team