[SRU] [Xenial] [snapdragon] [ PATCH 0/2 ] Fixes for LP:1776723

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Xenial] [snapdragon] [ PATCH 0/2 ] Fixes for LP:1776723

Ondrej Kubik

SRU Justification


Impact:

    snap cross building is broken and snap package can only build natively

    additionally snapcraft.yaml is using deprecated scriptlet syntax for install overrides

    this syntax has been deprecated by snapcraft and should be replaced with new one to future proof builds


Step to reproduce:

 - cross build with snapcraft on x86_64 host by calling: snapcraft --targer-arch=arm64


Expected result:

 snap package builds without warnings


Actual result:

 build fails


TEST CASE:

 - cross build with snapcraft on x86_64 host by calling: snapcraft --targer-arch=arm64

 - build should complete without errors and snapcraft warningsSRU Justification


Impact:

    snap cross building is broken and snap package can only build natively

    additionally snapcraft.yaml is using deprecated scriptlet syntax for install overrides

    this syntax has been deprecated by snapcraft and should be replaced with new one to future proof builds


Step to reproduce:

 - cross build with snapcraft on x86_64 host by calling: snapcraft --targer-arch=arm64


Expected result:

 snap package builds without warnings


Actual result:

 build fails


Ondrej Kubik (2):

  UBUNTU: SAUCE: snapcraft: Fixing cross build for firmware part

  UBUNTU: SAUCE: snapcraft: updating scriptlets syntax


 snapcraft.yaml | 13 +++++++++----

 1 file changed, 9 insertions(+), 4 deletions(-)


-- 

2.7.4




TEST CASE:
 - cross build with snapcraft on x86_64 host by calling: snapcraft --targer-arch=arm64
 - build should complete without errors and snapcraft warnings

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [SRU] [Xenial] [snapdragon] [ PATCH 0/2 ] Fixes for LP:1776723

Kleber Souza
On 06/26/18 19:17, Ondrej Kubik wrote:

> SRU Justification
>
>
> Impact:
>
>     snap cross building is broken and snap package can only build natively
>
>     additionally snapcraft.yaml is using deprecated scriptlet syntax for
> install overrides
>
>     this syntax has been deprecated by snapcraft and should be replaced
> with new one to future proof builds
>
>
> Step to reproduce:
>
>  - cross build with snapcraft on x86_64 host by calling: snapcraft
> --targer-arch=arm64
>
>
> Expected result:
>
>  snap package builds without warnings
>
>
> Actual result:
>
>  build fails
>
>
> TEST CASE:
>
>  - cross build with snapcraft on x86_64 host by calling: snapcraft
> --targer-arch=arm64
>
>  - build should complete without errors and snapcraft warningsSRU
> Justification
>
>
> Impact:
>
>     snap cross building is broken and snap package can only build natively
>
>     additionally snapcraft.yaml is using deprecated scriptlet syntax for
> install overrides
>
>     this syntax has been deprecated by snapcraft and should be replaced
> with new one to future proof builds
>
>
> Step to reproduce:
>
>  - cross build with snapcraft on x86_64 host by calling: snapcraft
> --targer-arch=arm64
>
>
> Expected result:
>
>  snap package builds without warnings
>
>
> Actual result:
>
>  build fails
>
>
> Ondrej Kubik (2):
>
>   UBUNTU: SAUCE: snapcraft: Fixing cross build for firmware part
>
>   UBUNTU: SAUCE: snapcraft: updating scriptlets syntax
>
>
>  snapcraft.yaml | 13 +++++++++----
>
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
>
> -- 
>
> 2.7.4
>
>
>
>
> TEST CASE:
>  - cross build with snapcraft on x86_64 host by calling: snapcraft
> --targer-arch=arm64
>  - build should complete without errors and snapcraft warnings
>
>

Same with this thread, please resend the patches as plain text only and
grouped.

Thank you,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team