[SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Siva Rebbagondla-2
From: Sanjay Kumar Konduri <[hidden email]>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400

Observed third party station is unable to scan redpine AP, when Soft-AP
restart command invoked. This is because power save is not disabled for
rsi Soft-AP mode in rsi_mac80211_tx().

Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
Signed-off-by: Siva Rebbagondla <[hidden email]>
---
v2: Changed the subject as per stable patch format [Shrirang].
---
 ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
index 129859a..244ef27 100644
--- a/ubuntu/rsi/rsi_91x_mac80211.c
+++ b/ubuntu/rsi/rsi_91x_mac80211.c
@@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
  return;
  }
  if ((!bss->assoc) &&
-    (adapter->ps_state == PS_ENABLED) &&
-    (vif->type == NL80211_IFTYPE_STATION))
+    (adapter->ps_state == PS_ENABLED))
  rsi_disable_ps(adapter);
  if (ieee80211_is_auth(wlh->frame_control))
  common->mac_ops_resumed = false;
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU Xenial][v2][PATCH 2/2] UBUNTU: SAUCE: Redpine: improve cancel_hw_scan handling to fix kernel panic

Siva Rebbagondla-2
From: Siva Rebbagondla <[hidden email]>

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773410

Kernel panic is observed when network manager is stopped while system
is entering into hibernation. The root cause of the issue is scan work
function keeps running even after cancel_hw_scan() call.
Issue is resolved by calling cancel_work_sync().

[ 1171.913244] BUG: unable to handle page request at 00000000001067e38
[ 1171.913248] IP: cfg80211_scan_done+0xb0/0xc0 [cfg80211]
[ 1171.913554] Hardware name: Dell Inc. Edge Gateway 3003/      , BIOS 01.00.06 01/22/2018
[ 1171.913668] Workqueue: phy1 ieee80211_scan_work [mac80211]
[ 1171.913773] RIP: 0010:cfg80211_scan_done+0xb0/0xc0 [cfg80211]
[ 1171.913780] RSP: 0018:ffffc1fe41b47dc8 EFLAGS: 00010286
[ 1171.913789] RAX: 0000000000000001 RBX: ffffffffc0e60120 RCX: 0000000100080006
[ 1171.913794] RDX: ffff9eeab7e3bc58 RSI: ffff9eeab0c69080 RDI: ffff9eeab7e3bc00
[ 1171.913799] RBP: ffff9eeab7e3bc00 R08: 00000000b7e3b201 R09: 0000000100080006
[ 1171.913805] R10: ffffc1fe41b47d20 R11: 0000000000000000 R12: ffff9eeab0c69080
[ 1171.913810] R13: 0000000000000022 R14: ffff9eeab0c68760 R15: ffff9eeab7af3c00
[ 1171.913817] FS:  0000000000000000(0000) GS:ffff9eeab0000000(0000) knlGS:0000000000000000
[ 1171.913823] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1171.913828] CR2: 00007f76c73ac190 CR3: 000000006e20a000 CR4: 00000000001006f0
[ 1171.913833] Call Trace:
[ 1171.913864]  ? rsi_mac80211_sta_remove+0x260/0x260 [rsi_91x]
[ 1171.913971]  __ieee80211_scan_completed+0xb1/0x390 [mac80211]
[ 1171.914078]  ieee80211_scan_work+0x7e/0x480 [mac80211]
[ 1171.914098]  process_one_work+0x142/0x3d0
[ 1171.914111]  worker_thread+0x229/0x440
[ 1171.914122]  kthread+0xf5/0x130
[ 1171.914132]  ? process_one_work+0x3d0/0x3d0
[ 1171.914140]  ? kthread_associate_blkcg+0x90/0x90
[ 1171.914152]  ret_from_fork+0x35/0x40

Signed-off-by: Siva Rebbagondla <[hidden email]>
---
v2: Changed the subject as per stable patch format [Shrirang].
---
 ubuntu/rsi/rsi_91x_mac80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
index 244ef27..5a85bcd 100644
--- a/ubuntu/rsi/rsi_91x_mac80211.c
+++ b/ubuntu/rsi/rsi_91x_mac80211.c
@@ -429,6 +429,7 @@ void rsi_mac80211_hw_scan_cancel(struct ieee80211_hw *hw,
  rsi_wait_event(&common->cancel_hw_scan_event,
        EVENT_WAIT_FOREVER);
  rsi_reset_event(&common->cancel_hw_scan_event);
+ cancel_work_sync(&common->scan_work);
  common->scan_request = NULL;
  }
 
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Shrirang Bagul
In reply to this post by Siva Rebbagondla-2
On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:

> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
When you have multiple patches addressing different bugs, it's advisable to
include a cover letter with a short explanation. Otherwise, everything looks
okay.
 
Acked-by: Shrirang Bagul <[hidden email]>

> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>   return;
>   }
>   if ((!bss->assoc) &&
> -    (adapter->ps_state == PS_ENABLED) &&
> -    (vif->type == NL80211_IFTYPE_STATION))
> +    (adapter->ps_state == PS_ENABLED))
>   rsi_disable_ps(adapter);
>   if (ieee80211_is_auth(wlh->frame_control))
>   common->mac_ops_resumed = false;
--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Siva Rebbagondla-2
On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <[hidden email]> wrote:
On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
When you have multiple patches addressing different bugs, it's advisable to
include a cover letter with a short explanation. Otherwise, everything looks
okay.
​ Sure Shrirang. I will follow cover letter format, in case of multiple patches submission.​ Thanks ​
 

Acked-by: Shrirang Bagul <[hidden email]>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>               return;
>       }
>       if ((!bss->assoc) &&
> -         (adapter->ps_state == PS_ENABLED) &&
> -         (vif->type == NL80211_IFTYPE_STATION))
> +         (adapter->ps_state == PS_ENABLED))
>               rsi_disable_ps(adapter);
>       if (ieee80211_is_auth(wlh->frame_control))
>               common->mac_ops_resumed = false;


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Shrirang Bagul
Hi Siva,

Well, the status has changed since my previous email on this thread.
Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.

/Shrirang

On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:
Hi Shrirang,

Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/".
Do i need to resend the patches one again?. Please confirm this.

Snippet from above URL, which shows ACK for submitted patches.

Thank you,
Siva Rebbagondla.

On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <[hidden email]> wrote:
Hi Shrirang,

I just sent a subscription request to ubuntu kernel team.

Thanks,
Siva Rebbagondla

On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <[hidden email]> wrote:
Hi Siva,

Looks like the email address you are using to send patches was not registered in the [hidden email] mailing list.
The patches submitted in this series are under moderation and won't get picked-up.

Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the patches.

/Shrirang

On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:
On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <[hidden email]> wrote:
On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
When you have multiple patches addressing different bugs, it's advisable to
include a cover letter with a short explanation. Otherwise, everything looks
okay.
Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks
 

Acked-by: Shrirang Bagul <[hidden email]>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>               return;
>       }
>       if ((!bss->assoc) &&
> -         (adapter->ps_state == PS_ENABLED) &&
> -         (vif->type == NL80211_IFTYPE_STATION))
> +         (adapter->ps_state == PS_ENABLED))
>               rsi_disable_ps(adapter);
>       if (ieee80211_is_auth(wlh->frame_control))
>               common->mac_ops_resumed = false;




--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Siva Rebbagondla-2
Thanks for the update. 
And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.

Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.

Best regards,
Siva Rebbagondla

On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <[hidden email]> wrote:
Hi Siva,

Well, the status has changed since my previous email on this thread.
Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.

/Shrirang

On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:
Hi Shrirang,

Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/".
Do i need to resend the patches one again?. Please confirm this.

Snippet from above URL, which shows ACK for submitted patches.

Thank you,
Siva Rebbagondla.

On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <[hidden email]> wrote:
Hi Shrirang,

I just sent a subscription request to ubuntu kernel team.

Thanks,
Siva Rebbagondla

On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <[hidden email]> wrote:
Hi Siva,

Looks like the email address you are using to send patches was not registered in the [hidden email] mailing list.
The patches submitted in this series are under moderation and won't get picked-up.

Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the patches.

/Shrirang

On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:
On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <[hidden email]> wrote:
On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
When you have multiple patches addressing different bugs, it's advisable to
include a cover letter with a short explanation. Otherwise, everything looks
okay.
Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks
 

Acked-by: Shrirang Bagul <[hidden email]>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>               return;
>       }
>       if ((!bss->assoc) &&
> -         (adapter->ps_state == PS_ENABLED) &&
> -         (vif->type == NL80211_IFTYPE_STATION))
> +         (adapter->ps_state == PS_ENABLED))
>               rsi_disable_ps(adapter);
>       if (ieee80211_is_auth(wlh->frame_control))
>               common->mac_ops_resumed = false;




--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Shrirang Bagul
Hi Siva,

Let's continue the discussion on the bug: https://bugs.launchpad.net/plano/+bug/1769225 and not on the mailing list.

/Shrirang
On Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote:
Thanks for the update. 
And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.

Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.

Best regards,
Siva Rebbagondla

On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <[hidden email]> wrote:
Hi Siva,

Well, the status has changed since my previous email on this thread.
Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.

/Shrirang

On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:
Hi Shrirang,

Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/".
Do i need to resend the patches one again?. Please confirm this.

Snippet from above URL, which shows ACK for submitted patches.

Thank you,
Siva Rebbagondla.

On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <[hidden email]> wrote:
Hi Shrirang,

I just sent a subscription request to ubuntu kernel team.

Thanks,
Siva Rebbagondla

On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <[hidden email]> wrote:
Hi Siva,

Looks like the email address you are using to send patches was not registered in the [hidden email] mailing list.
The patches submitted in this series are under moderation and won't get picked-up.

Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the patches.

/Shrirang

On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:
On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <[hidden email]> wrote:
On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
When you have multiple patches addressing different bugs, it's advisable to
include a cover letter with a short explanation. Otherwise, everything looks
okay.
Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks
 

Acked-by: Shrirang Bagul <[hidden email]>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>               return;
>       }
>       if ((!bss->assoc) &&
> -         (adapter->ps_state == PS_ENABLED) &&
> -         (vif->type == NL80211_IFTYPE_STATION))
> +         (adapter->ps_state == PS_ENABLED))
>               rsi_disable_ps(adapter);
>       if (ieee80211_is_auth(wlh->frame_control))
>               common->mac_ops_resumed = false;




--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Siva Rebbagondla-2
OK Shrirang. 

Thanks

On Thu 31 May, 2018, 9:32 AM Shrirang Bagul, <[hidden email]> wrote:
Hi Siva,

Let's continue the discussion on the bug: https://bugs.launchpad.net/plano/+bug/1769225 and not on the mailing list.

/Shrirang
On Thu, 2018-05-31 at 09:09 +0530, Siva Rebbagondla wrote:
Thanks for the update. 
And you are confirming that soft-ap is not fixed in ubuntu-xenial , after reboot. Is that correct?.

Can you please share us the xenial os image which contain latest 2 patches?. This helps us to debug more deep into the issue.

Best regards,
Siva Rebbagondla

On Thu 31 May, 2018, 9:03 AM Shrirang Bagul, <[hidden email]> wrote:
Hi Siva,

Well, the status has changed since my previous email on this thread.
Because, the test kernel built with these patches still doesn't fix the issue, I'm not sure if these patches should be merged at all.

/Shrirang

On Thu, 2018-05-31 at 08:35 +0530, Siva Rebbagondla wrote:
Hi Shrirang,

Just to cross check, As i able to see acknowledgment for my submitted patches in "https://lists.ubuntu.com/archives/kernel-team/2018-May/".
Do i need to resend the patches one again?. Please confirm this.

Snippet from above URL, which shows ACK for submitted patches.

Thank you,
Siva Rebbagondla.

On Tue, May 29, 2018 at 12:55 PM, Siva Rebbagondla <[hidden email]> wrote:
Hi Shrirang,

I just sent a subscription request to ubuntu kernel team.

Thanks,
Siva Rebbagondla

On Tue, May 29, 2018 at 12:08 PM, Shrirang Bagul <[hidden email]> wrote:
Hi Siva,

Looks like the email address you are using to send patches was not registered in the [hidden email] mailing list.
The patches submitted in this series are under moderation and won't get picked-up.

Please subscribe to the list by following the registration process here: https://lists.ubuntu.com/mailman/listinfo/kernel-team and resend the patches.

/Shrirang

On Mon, 2018-05-28 at 18:34 +0530, Siva Rebbagondla wrote:
On Mon, May 28, 2018 at 6:02 PM, Shrirang Bagul <[hidden email]> wrote:
On Mon, 2018-05-28 at 16:19 +0530, Siva Rebbagondla wrote:
> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
When you have multiple patches addressing different bugs, it's advisable to
include a cover letter with a short explanation. Otherwise, everything looks
okay.
Sure Shrirang. I will follow cover letter format, in case of multiple patches submission. Thanks
 

Acked-by: Shrirang Bagul <[hidden email]>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>               return;
>       }
>       if ((!bss->assoc) &&
> -         (adapter->ps_state == PS_ENABLED) &&
> -         (vif->type == NL80211_IFTYPE_STATION))
> +         (adapter->ps_state == PS_ENABLED))
>               rsi_disable_ps(adapter);
>       if (ieee80211_is_auth(wlh->frame_control))
>               common->mac_ops_resumed = false;




--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK/cmnt: [SRU Xenial][v2][PATCH 1/2] UBUNTU: SAUCE: Redpine: fix for Soft-AP restart issue

Stefan Bader-2
In reply to this post by Siva Rebbagondla-2
On 28.05.2018 03:49, Siva Rebbagondla wrote:

> From: Sanjay Kumar Konduri <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773400
>
> Observed third party station is unable to scan redpine AP, when Soft-AP
> restart command invoked. This is because power save is not disabled for
> rsi Soft-AP mode in rsi_mac80211_tx().
>
> Signed-off-by: Sanjay Kumar Konduri <[hidden email]>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
> ---
> v2: Changed the subject as per stable patch format [Shrirang].
> ---
Based on the further replies it sounds like this patch set should not be
considered for now. If things got resolved, please re-submit.

Thanks,
Stefan

>  ubuntu/rsi/rsi_91x_mac80211.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ubuntu/rsi/rsi_91x_mac80211.c b/ubuntu/rsi/rsi_91x_mac80211.c
> index 129859a..244ef27 100644
> --- a/ubuntu/rsi/rsi_91x_mac80211.c
> +++ b/ubuntu/rsi/rsi_91x_mac80211.c
> @@ -564,8 +564,7 @@ static void rsi_mac80211_tx(struct ieee80211_hw *hw,
>   return;
>   }
>   if ((!bss->assoc) &&
> -    (adapter->ps_state == PS_ENABLED) &&
> -    (vif->type == NL80211_IFTYPE_STATION))
> +    (adapter->ps_state == PS_ENABLED))
>   rsi_disable_ps(adapter);
>   if (ieee80211_is_auth(wlh->frame_control))
>   common->mac_ops_resumed = false;
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment