[SRU linux-kvm] UBUNTU: [Config]: set CONFIG_BASE_FULL

[Thadeu Lima de Souza Cascardo-3]

BugLink: https://bugs.launchpad.net/bugs/1866149

[Impact]
systemd-systemctl will fail to set kernel.pid_max, leading to a degraded boot.

[Fix]
Set CONFIG_BASE_FULL=y, CONFIG_BASE_SMALL=0.

[Test case]
Write 419304 to /proc/sys/kernel/pid_max.

[Potential regression]
Boot time may be affected.



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Thadeu Lima de Souza Cascardo-3]

BugLink: https://bugs.launchpad.net/bugs/1866149

Which, in turn, leads to CONFIG_BASE_SMALL=0. This turns off some memory
savings that linux-kvm carried. Those savings, however, are minimal, and do not
justify the runtime penalty and did not account to significant boot time
savings.

This also lead to a limit in PIDs on the system that caused degraged boot when
systemd-sysctl tried to change the default maximum PID.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index cc864334cc25..3bd41a7c3205 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -194,8 +194,8 @@ CONFIG_AUTOFS_FS=y
 # CONFIG_BACKLIGHT_CLASS_DEVICE is not set
 # CONFIG_BACKTRACE_SELF_TEST is not set
 CONFIG_BAREUDP=m
-# CONFIG_BASE_FULL is not set
-CONFIG_BASE_SMALL=1
+CONFIG_BASE_FULL=y
+CONFIG_BASE_SMALL=0
 # CONFIG_BATMAN_ADV is not set
 # CONFIG_BATTERY_BQ27XXX is not set
 # CONFIG_BATTERY_DS2780 is not set
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Thadeu Lima de Souza Cascardo-3]

BugLink: https://bugs.launchpad.net/bugs/1866149

Which, in turn, leads to CONFIG_BASE_SMALL=0. This turns off some memory
savings that linux-kvm carried. Those savings, however, are minimal, and do not
justify the runtime penalty and did not account to significant boot time
savings.

This also lead to a limit in PIDs on the system that caused degraged boot when
systemd-sysctl tried to change the default maximum PID.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index ecad0df5219f..4ef05a669150 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -186,8 +186,8 @@ CONFIG_AUTOFS_FS=y
 # CONFIG_AUXDISPLAY is not set
 # CONFIG_BACKLIGHT_CLASS_DEVICE is not set
 # CONFIG_BACKTRACE_SELF_TEST is not set
-# CONFIG_BASE_FULL is not set
-CONFIG_BASE_SMALL=1
+CONFIG_BASE_FULL=y
+CONFIG_BASE_SMALL=0
 # CONFIG_BATMAN_ADV is not set
 # CONFIG_BATTERY_BQ27XXX is not set
 # CONFIG_BATTERY_DS2780 is not set
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Thadeu Lima de Souza Cascardo-3]

BugLink: https://bugs.launchpad.net/bugs/1866149

Which, in turn, leads to CONFIG_BASE_SMALL=0. This turns off some memory
savings that linux-kvm carried. Those savings, however, are minimal, and do not
justify the runtime penalty and did not account to significant boot time
savings.

This also lead to a limit in PIDs on the system that caused degraged boot when
systemd-sysctl tried to change the default maximum PID.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index fb0f7dc2e543..a650ad095efa 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -189,8 +189,8 @@ CONFIG_AUTOFS4_FS=y
 # CONFIG_AUXDISPLAY is not set
 # CONFIG_BACKLIGHT_LCD_SUPPORT is not set
 # CONFIG_BACKTRACE_SELF_TEST is not set
-# CONFIG_BASE_FULL is not set
-CONFIG_BASE_SMALL=1
+CONFIG_BASE_FULL=y
+CONFIG_BASE_SMALL=0
 # CONFIG_BATMAN_ADV is not set
 # CONFIG_BATTERY_BQ27XXX is not set
 # CONFIG_BATTERY_DS2780 is not set
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Thadeu Lima de Souza Cascardo-3]

BugLink: https://bugs.launchpad.net/bugs/1866149

Which, in turn, leads to CONFIG_BASE_SMALL=0. This turns off some memory
savings that linux-kvm carried. Those savings, however, are minimal, and do not
justify the runtime penalty and did not account to significant boot time
savings.

This also lead to a limit in PIDs on the system that caused degraged boot when
systemd-sysctl tried to change the default maximum PID.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index f5d48d9f154b..debb0a8100d1 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -153,8 +153,8 @@ CONFIG_AUTOFS4_FS=y
 # CONFIG_AUXDISPLAY is not set
 # CONFIG_BACKLIGHT_LCD_SUPPORT is not set
 # CONFIG_BACKTRACE_SELF_TEST is not set
-# CONFIG_BASE_FULL is not set
-CONFIG_BASE_SMALL=1
+CONFIG_BASE_FULL=y
+CONFIG_BASE_SMALL=0
 # CONFIG_BATMAN_ADV is not set
 # CONFIG_BCACHE is not set
 # CONFIG_BCMA is not set
--
2.27.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Kamal Mostafa-2]

Yup, LGTM.  Thadeu, thanks for the explanation in the LP bug about the
possible performance implications.

Acked-by: Kamal Mostafa <[hidden email]>

 -Kamal

On Fri, Jan 08, 2021 at 02:48:04PM -0300, Thadeu Lima de Souza Cascardo wrote:

> BugLink: https://bugs.launchpad.net/bugs/1866149
>
> [Impact]
> systemd-systemctl will fail to set kernel.pid_max, leading to a degraded boot.
>
> [Fix]
> Set CONFIG_BASE_FULL=y, CONFIG_BASE_SMALL=0.
>
> [Test case]
> Write 419304 to /proc/sys/kernel/pid_max.
>
> [Potential regression]
> Boot time may be affected.
>
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Colin Ian King-2]

On 08/01/2021 17:48, Thadeu Lima de Souza Cascardo wrote:

> BugLink: https://bugs.launchpad.net/bugs/1866149
>
> [Impact]
> systemd-systemctl will fail to set kernel.pid_max, leading to a degraded boot.
>
> [Fix]
> Set CONFIG_BASE_FULL=y, CONFIG_BASE_SMALL=0.
>
> [Test case]
> Write 419304 to /proc/sys/kernel/pid_max.
>
> [Potential regression]
> Boot time may be affected.
>
>
>

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

[Kelsey Skunberg]

Applied to G/F/B/X kvm. thank you!

-Kelsey

On 2021-01-08 14:48:04 , Thadeu Lima de Souza Cascardo wrote:

> BugLink: https://bugs.launchpad.net/bugs/1866149
>
> [Impact]
> systemd-systemctl will fail to set kernel.pid_max, leading to a degraded boot.
>
> [Fix]
> Set CONFIG_BASE_FULL=y, CONFIG_BASE_SMALL=0.
>
> [Test case]
> Write 419304 to /proc/sys/kernel/pid_max.
>
> [Potential regression]
> Boot time may be affected.
>
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team