[SRU] [linux-oem] [PATCH 0/1] UBUNTU: SAUCE: Use I2C tansport for touchpad on Precision M5530

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [linux-oem] [PATCH 0/1] UBUNTU: SAUCE: Use I2C tansport for touchpad on Precision M5530

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1746661

[Impact]
Touchpad on Precision M5530 uses PS/2 instead of I2C as its transport.

[Test Case]
The touchpad binds to psmouse instead of i2c_hid.
With the patch, the touchpad uses i2c_hid instead.

[Fix]
LKML Link: https://lkml.org/lkml/2018/1/30/963
The de facto standard, Windows, parse its DSDT as a term list. The DSDT
table on Precision M5530 also designed that way, hence we should just
respect that.
Add a new quirk for this specific machine.
I'll backport the patch for stable releases once it's upstreamed.

[Regression Potential]
Low. This fix is limited to XPS 15 9570/Precision M5530. Also it's the
"correct" way to do for this machine.

Kai-Heng Feng (1):
  ACPI: Parse entire table as a term_list for Dell XPS 9570 and
    Precision M5530

 drivers/acpi/bus.c | 40 +++++++++++++++++++++++++++++++++-------
 1 file changed, 33 insertions(+), 7 deletions(-)

--
2.15.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU] [linux-oem] [PATCH 1/1] UBUNTU: SAUCE: ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1746661

The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out
of box.

The touchpad relies on its _INI method to update its _HID value from
XXXX0000 to SYNA2393.
Also, the _STA relies on value of I2CN to report correct status.

Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be
correctly set up, and _INI can get run. The ACPI table in this machine
is designed to get parsed this way.

Also, change the quirk table to a more generic name.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515
Cc: Mario Limonciello <[hidden email]>
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/acpi/bus.c | 40 +++++++++++++++++++++++++++++++++-------
 1 file changed, 33 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 4d0979e02a28..7cb18bc2b59a 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -66,10 +66,39 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
  return 0;
 }
 #endif
+static int set_gbl_term_list(const struct dmi_system_id *id)
+{
+ pr_notice("%s detected - parse the entire table as a term_list\n",
+  id->ident);
+ acpi_gbl_parse_table_as_term_list = 1;
+ return 0;
+}
 
-static const struct dmi_system_id dsdt_dmi_table[] __initconst = {
+static const struct dmi_system_id acpi_quirks_dmi_table[] __initconst = {
+ /*
+ * Touchpad on Dell XPS 9570/Precision M5530 doesn't work under I2C
+ * mode.
+ * https://bugzilla.kernel.org/show_bug.cgi?id=198515
+ */
+ {
+ .callback = set_gbl_term_list,
+ .ident = "Dell Precision M5530",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Precision M5530"),
+ },
+ },
+ {
+ .callback = set_gbl_term_list,
+ .ident = "Dell XPS 15 9570",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"),
+ },
+ },
  /*
  * Invoke DSDT corruption work-around on all Toshiba Satellite.
+ * DSDT will be copied to memory.
  * https://bugzilla.kernel.org/show_bug.cgi?id=14679
  */
  {
@@ -83,7 +112,7 @@ static const struct dmi_system_id dsdt_dmi_table[] __initconst = {
  {}
 };
 #else
-static const struct dmi_system_id dsdt_dmi_table[] __initconst = {
+static const struct dmi_system_id acpi_quirks_dmi_table[] __initconst = {
  {}
 };
 #endif
@@ -1001,11 +1030,8 @@ void __init acpi_early_init(void)
 
  acpi_permanent_mmap = true;
 
- /*
- * If the machine falls into the DMI check table,
- * DSDT will be copied to memory
- */
- dmi_check_system(dsdt_dmi_table);
+ /* Check machine-specific quirks */
+ dmi_check_system(acpi_quirks_dmi_table);
 
  status = acpi_reallocate_root_table();
  if (ACPI_FAILURE(status)) {
--
2.15.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [linux-oem] [PATCH 0/1] UBUNTU: SAUCE: Use I2C tansport for touchpad on Precision M5530

Marcelo Henrique Cerri
In reply to this post by Kai-Heng Feng
Good test results with low risk of regression:

Acked-by: Marcelo Henrique Cerri <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [linux-oem] [PATCH 1/1] UBUNTU: SAUCE: ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

Colin Ian King-2
In reply to this post by Kai-Heng Feng
On 01/02/18 05:47, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1746661
>
> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out
> of box.
>
> The touchpad relies on its _INI method to update its _HID value from
> XXXX0000 to SYNA2393.
> Also, the _STA relies on value of I2CN to report correct status.
>
> Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be
> correctly set up, and _INI can get run. The ACPI table in this machine
> is designed to get parsed this way.
>
> Also, change the quirk table to a more generic name.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198515
> Cc: Mario Limonciello <[hidden email]>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> ---
>  drivers/acpi/bus.c | 40 +++++++++++++++++++++++++++++++++-------
>  1 file changed, 33 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 4d0979e02a28..7cb18bc2b59a 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -66,10 +66,39 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
>   return 0;
>  }
>  #endif
> +static int set_gbl_term_list(const struct dmi_system_id *id)
> +{
> + pr_notice("%s detected - parse the entire table as a term_list\n",
> +  id->ident);
> + acpi_gbl_parse_table_as_term_list = 1;
> + return 0;
> +}
>  
> -static const struct dmi_system_id dsdt_dmi_table[] __initconst = {
> +static const struct dmi_system_id acpi_quirks_dmi_table[] __initconst = {
> + /*
> + * Touchpad on Dell XPS 9570/Precision M5530 doesn't work under I2C
> + * mode.
> + * https://bugzilla.kernel.org/show_bug.cgi?id=198515
> + */
> + {
> + .callback = set_gbl_term_list,
> + .ident = "Dell Precision M5530",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Precision M5530"),
> + },
> + },
> + {
> + .callback = set_gbl_term_list,
> + .ident = "Dell XPS 15 9570",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9570"),
> + },
> + },
>   /*
>   * Invoke DSDT corruption work-around on all Toshiba Satellite.
> + * DSDT will be copied to memory.
>   * https://bugzilla.kernel.org/show_bug.cgi?id=14679
>   */
>   {
> @@ -83,7 +112,7 @@ static const struct dmi_system_id dsdt_dmi_table[] __initconst = {
>   {}
>  };
>  #else
> -static const struct dmi_system_id dsdt_dmi_table[] __initconst = {
> +static const struct dmi_system_id acpi_quirks_dmi_table[] __initconst = {
>   {}
>  };
>  #endif
> @@ -1001,11 +1030,8 @@ void __init acpi_early_init(void)
>  
>   acpi_permanent_mmap = true;
>  
> - /*
> - * If the machine falls into the DMI check table,
> - * DSDT will be copied to memory
> - */
> - dmi_check_system(dsdt_dmi_table);
> + /* Check machine-specific quirks */
> + dmi_check_system(acpi_quirks_dmi_table);
>  
>   status = acpi_reallocate_root_table();
>   if (ACPI_FAILURE(status)) {
>

Limited to a specific set of platform, so regression potential is small.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU] [linux-oem] [PATCH 0/1] UBUNTU: SAUCE: Use I2C tansport for touchpad on Precision M5530

Timo Aaltonen-6
In reply to this post by Kai-Heng Feng
On 01.02.2018 07:47, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1746661
>
> [Impact]
> Touchpad on Precision M5530 uses PS/2 instead of I2C as its transport.
>
> [Test Case]
> The touchpad binds to psmouse instead of i2c_hid.
> With the patch, the touchpad uses i2c_hid instead.
>
> [Fix]
> LKML Link: https://lkml.org/lkml/2018/1/30/963
> The de facto standard, Windows, parse its DSDT as a term list. The DSDT
> table on Precision M5530 also designed that way, hence we should just
> respect that.
> Add a new quirk for this specific machine.
> I'll backport the patch for stable releases once it's upstreamed.
>
> [Regression Potential]
> Low. This fix is limited to XPS 15 9570/Precision M5530. Also it's the
> "correct" way to do for this machine.
>
> Kai-Heng Feng (1):
>   ACPI: Parse entire table as a term_list for Dell XPS 9570 and
>     Precision M5530
>
>  drivers/acpi/bus.c | 40 +++++++++++++++++++++++++++++++++-------
>  1 file changed, 33 insertions(+), 7 deletions(-)
>

The patch was not against linux-oem but maybe current upstream? I've
backported it though and applied to git.


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team