[SRU-v2][AWS-{B,F,G}] enable PCI write-combine for arm64

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU-v2][AWS-{B,F,G}] enable PCI write-combine for arm64

Kamal Mostafa-2
***
*** [SRU-v2] This is a re-submit of a patch that I retracted last month,
*** pending upstream discussion.  Upstream is now prepared to accept it.
***
*** This was ACK'ed by Stefan and Andrea (2020/09/03) and those ACK's
*** are pre-applied here, as the patch is unchanged.
***
*** SRU template and supporting details are in the bug link:
***

BugLink: https://bugs.launchpad.net/bugs/1893817

To improve PCI performance on arm64 AWS instances, enable arch_can_pci_mmap_wc()
via the patch:

  From: Clint Sbisa <[hidden email]>
  Subject: [PATCH] arm64: Enable PCI write-combine resources under sysfs

  https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../


Supplied here are two versions of this one-liner patch:
    [PATCH][AWS-B]       <--  for linux-aws/bionic master (v4.15)
    [PATCH][AWS-{F,G}]   <--  for linux-aws/{focal and groovy} master

I have smoke-tested this on AWS ARM instances.

 -Kamal

-----

Clint Sbisa (1):
  UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs

 arch/arm64/include/asm/pci.h | 1 +
 1 file changed, 1 insertion(+)

--
2.17.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCHv2][AWS-B] UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs

Kamal Mostafa-2
From: Clint Sbisa <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1893817

Using write-combine is crucial for performance of PCI devices where
significant amounts of transactions go over PCI BARs.

arm64 supports write-combine PCI mappings, so the appropriate define
has been added which will expose write-combine mappings under sysfs
for prefetchable PCI resources.

Signed-off-by: Clint Sbisa <[hidden email]>
Reference: https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
Signed-off-by: Kamal Mostafa <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>                            
Acked-by: Andrea Righi <[hidden email]>                            
---
 arch/arm64/include/asm/pci.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
index 8747f7c5e0e7..b4121784b4e8 100644
--- a/arch/arm64/include/asm/pci.h
+++ b/arch/arm64/include/asm/pci.h
@@ -23,6 +23,7 @@
  */
 #define PCI_DMA_BUS_IS_PHYS (0)
 
+#define arch_can_pci_mmap_wc() 1
 #define ARCH_GENERIC_PCI_MMAP_RESOURCE 1
 
 extern int isa_dma_bridge_buggy;
--
2.17.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCHv2][AWS-{F, G}] UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs

Kamal Mostafa-2
In reply to this post by Kamal Mostafa-2
From: Clint Sbisa <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1893817

Using write-combine is crucial for performance of PCI devices where
significant amounts of transactions go over PCI BARs.

arm64 supports write-combine PCI mappings, so the appropriate define
has been added which will expose write-combine mappings under sysfs
for prefetchable PCI resources.

Signed-off-by: Clint Sbisa <[hidden email]>
Reference: https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
Signed-off-by: Kamal Mostafa <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>                            
Acked-by: Andrea Righi <[hidden email]>                            
---
 arch/arm64/include/asm/pci.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
index 70b323cf8300..b33ca260e3c9 100644
--- a/arch/arm64/include/asm/pci.h
+++ b/arch/arm64/include/asm/pci.h
@@ -17,6 +17,7 @@
 #define pcibios_assign_all_busses() \
  (pci_has_flag(PCI_REASSIGN_ALL_BUS))
 
+#define arch_can_pci_mmap_wc() 1
 #define ARCH_GENERIC_PCI_MMAP_RESOURCE 1
 
 extern int isa_dma_bridge_buggy;
--
2.17.1

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU-v2][AWS-{B,F,G}] enable PCI write-combine for arm64

Colin Ian King-2
In reply to this post by Kamal Mostafa-2
On 07/10/2020 21:11, Kamal Mostafa wrote:

> ***
> *** [SRU-v2] This is a re-submit of a patch that I retracted last month,
> *** pending upstream discussion.  Upstream is now prepared to accept it.
> ***
> *** This was ACK'ed by Stefan and Andrea (2020/09/03) and those ACK's
> *** are pre-applied here, as the patch is unchanged.
> ***
> *** SRU template and supporting details are in the bug link:
> ***
>
> BugLink: https://bugs.launchpad.net/bugs/1893817
>
> To improve PCI performance on arm64 AWS instances, enable arch_can_pci_mmap_wc()
> via the patch:
>
>   From: Clint Sbisa <[hidden email]>
>   Subject: [PATCH] arm64: Enable PCI write-combine resources under sysfs
>
>   https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
>
>
> Supplied here are two versions of this one-liner patch:
>     [PATCH][AWS-B]       <--  for linux-aws/bionic master (v4.15)
>     [PATCH][AWS-{F,G}]   <--  for linux-aws/{focal and groovy} master
>
> I have smoke-tested this on AWS ARM instances.
>
>  -Kamal
>
> -----
>
> Clint Sbisa (1):
>   UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs
>
>  arch/arm64/include/asm/pci.h | 1 +
>  1 file changed, 1 insertion(+)
>

Thanks for the link to the discussion. Based on the info in the
discussion I'm happy with the commit.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU-v2][AWS-{B,F,G}] enable PCI write-combine for arm64

Stefan Bader-2
In reply to this post by Kamal Mostafa-2
On 07.10.20 22:11, Kamal Mostafa wrote:

> ***
> *** [SRU-v2] This is a re-submit of a patch that I retracted last month,
> *** pending upstream discussion.  Upstream is now prepared to accept it.
> ***
> *** This was ACK'ed by Stefan and Andrea (2020/09/03) and those ACK's
> *** are pre-applied here, as the patch is unchanged.
> ***
> *** SRU template and supporting details are in the bug link:
> ***
>
> BugLink: https://bugs.launchpad.net/bugs/1893817
>
> To improve PCI performance on arm64 AWS instances, enable arch_can_pci_mmap_wc()
> via the patch:
>
>   From: Clint Sbisa <[hidden email]>
>   Subject: [PATCH] arm64: Enable PCI write-combine resources under sysfs
>
>   https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
>
>
> Supplied here are two versions of this one-liner patch:
>     [PATCH][AWS-B]       <--  for linux-aws/bionic master (v4.15)
>     [PATCH][AWS-{F,G}]   <--  for linux-aws/{focal and groovy} master
>
> I have smoke-tested this on AWS ARM instances.
>
>  -Kamal
>
> -----
>
> Clint Sbisa (1):
>   UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs
>
>  arch/arm64/include/asm/pci.h | 1 +
>  1 file changed, 1 insertion(+)
>
Ok, already there but formally ... again

Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[G]: [SRU-v2][AWS-{B,F,G}] enable PCI write-combine for arm64

Seth Forshee
In reply to this post by Kamal Mostafa-2
On Wed, Oct 07, 2020 at 01:11:18PM -0700, Kamal Mostafa wrote:

> ***
> *** [SRU-v2] This is a re-submit of a patch that I retracted last month,
> *** pending upstream discussion.  Upstream is now prepared to accept it.
> ***
> *** This was ACK'ed by Stefan and Andrea (2020/09/03) and those ACK's
> *** are pre-applied here, as the patch is unchanged.
> ***
> *** SRU template and supporting details are in the bug link:
> ***
>
> BugLink: https://bugs.launchpad.net/bugs/1893817
>
> To improve PCI performance on arm64 AWS instances, enable arch_can_pci_mmap_wc()
> via the patch:
>
>   From: Clint Sbisa <[hidden email]>
>   Subject: [PATCH] arm64: Enable PCI write-combine resources under sysfs
>
>   https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
>
>
> Supplied here are two versions of this one-liner patch:
>     [PATCH][AWS-B]       <--  for linux-aws/bionic master (v4.15)
>     [PATCH][AWS-{F,G}]   <--  for linux-aws/{focal and groovy} master
>
> I have smoke-tested this on AWS ARM instances.
>
>  -Kamal

Applied for groovy. Thanks!

Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[AWS-F]: [PATCHv2][AWS-{F, G}] UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs

Ian May
In reply to this post by Kamal Mostafa-2
Applied to aws-focal.  

Thanks!
Ian

On 2020-10-07 13:11:20 , Kamal Mostafa wrote:

> From: Clint Sbisa <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1893817
>
> Using write-combine is crucial for performance of PCI devices where
> significant amounts of transactions go over PCI BARs.
>
> arm64 supports write-combine PCI mappings, so the appropriate define
> has been added which will expose write-combine mappings under sysfs
> for prefetchable PCI resources.
>
> Signed-off-by: Clint Sbisa <[hidden email]>
> Reference: https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
> Signed-off-by: Kamal Mostafa <[hidden email]>
> Acked-by: Stefan Bader <[hidden email]>                            
> Acked-by: Andrea Righi <[hidden email]>                            
> ---
>  arch/arm64/include/asm/pci.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
> index 70b323cf8300..b33ca260e3c9 100644
> --- a/arch/arm64/include/asm/pci.h
> +++ b/arch/arm64/include/asm/pci.h
> @@ -17,6 +17,7 @@
>  #define pcibios_assign_all_busses() \
>   (pci_has_flag(PCI_REASSIGN_ALL_BUS))
>  
> +#define arch_can_pci_mmap_wc() 1
>  #define ARCH_GENERIC_PCI_MMAP_RESOURCE 1
>  
>  extern int isa_dma_bridge_buggy;
> --
> 2.17.1
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[AWS-B]: [PATCHv2][AWS-B] UBUNTU: SAUCE: arm64: Enable PCI write-combine resources under sysfs

Ian May
In reply to this post by Kamal Mostafa-2
Applied to aws-bionic.  

Thanks!
Ian

On 2020-10-07 13:11:19 , Kamal Mostafa wrote:

> From: Clint Sbisa <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1893817
>
> Using write-combine is crucial for performance of PCI devices where
> significant amounts of transactions go over PCI BARs.
>
> arm64 supports write-combine PCI mappings, so the appropriate define
> has been added which will expose write-combine mappings under sysfs
> for prefetchable PCI resources.
>
> Signed-off-by: Clint Sbisa <[hidden email]>
> Reference: https://lore.kernel.org/linux-pci/20200831151827.pumm2p54fyj7fz5s@.../
> Signed-off-by: Kamal Mostafa <[hidden email]>
> Acked-by: Stefan Bader <[hidden email]>                            
> Acked-by: Andrea Righi <[hidden email]>                            
> ---
>  arch/arm64/include/asm/pci.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/pci.h b/arch/arm64/include/asm/pci.h
> index 8747f7c5e0e7..b4121784b4e8 100644
> --- a/arch/arm64/include/asm/pci.h
> +++ b/arch/arm64/include/asm/pci.h
> @@ -23,6 +23,7 @@
>   */
>  #define PCI_DMA_BUS_IS_PHYS (0)
>  
> +#define arch_can_pci_mmap_wc() 1
>  #define ARCH_GENERIC_PCI_MMAP_RESOURCE 1
>  
>  extern int isa_dma_bridge_buggy;
> --
> 2.17.1
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team