[SRU xenial] LP#1748671: fix regression with ipv4 raw_sendmsg

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU xenial] LP#1748671: fix regression with ipv4 raw_sendmsg

Andy Whitcroft-3
We have reports of a regresion in the 4.4.0-113 upload triggering
panics in raw_sendmsg.  This was traced to a miss-backport of the
commit.  Fix this up.

Proposing for SRU to xenial.

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[xenial/master-next 1/1] UBUNTU: SAUCE: net: ipv4: fix for a race condition in raw_sendmsg -- fix backport

Andy Whitcroft-3
Fix a miss-backport of the upstream commit.

Fixes: 63da13a92f24 ("net: ipv4: fix for a race condition in raw_sendmsg -- fix backport")
BugLink: http://bugs.launchpad.net/bugs/1748671
Signed-off-by: Andy Whitcroft <[hidden email]>
---
 net/ipv4/raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index 83a609bc7c57..3b764c0c1fec 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -621,7 +621,7 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
  goto done;
  }
 
- if (hdrincl) {
+ if (!hdrincl) {
  rfv.msg = msg;
  rfv.hlen = 0;
 
--
2.15.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU xenial] LP#1748671: fix regression with ipv4 raw_sendmsg

Kamal Mostafa-2
In reply to this post by Andy Whitcroft-3

Acked-by: Kamal Mostafa <[hidden email]>

On Mon, Feb 12, 2018 at 07:21:01PM +0000, Andy Whitcroft wrote:

> We have reports of a regresion in the 4.4.0-113 upload triggering
> panics in raw_sendmsg.  This was traced to a miss-backport of the
> commit.  Fix this up.
>
> Proposing for SRU to xenial.
>
> -apw
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [xenial/master-next 1/1] UBUNTU: SAUCE: net: ipv4: fix for a race condition in raw_sendmsg -- fix backport

brad.figg
In reply to this post by Andy Whitcroft-3
Reply | Threaded
Open this post in threaded view
|

ACK: [xenial/master-next 1/1] UBUNTU: SAUCE: net: ipv4: fix for a race condition in raw_sendmsg -- fix backport

Khaled Elmously
In reply to this post by Andy Whitcroft-3
Nice catch

Acked-by: Khalid Elmously <[hidden email]>


On 2018-02-12 19:21:02 , Andy Whitcroft wrote:

> Fix a miss-backport of the upstream commit.
>
> Fixes: 63da13a92f24 ("net: ipv4: fix for a race condition in raw_sendmsg -- fix backport")
> BugLink: http://bugs.launchpad.net/bugs/1748671
> Signed-off-by: Andy Whitcroft <[hidden email]>
> ---
>  net/ipv4/raw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> index 83a609bc7c57..3b764c0c1fec 100644
> --- a/net/ipv4/raw.c
> +++ b/net/ipv4/raw.c
> @@ -621,7 +621,7 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
>   goto done;
>   }
>  
> - if (hdrincl) {
> + if (!hdrincl) {
>   rfv.msg = msg;
>   rfv.hlen = 0;
>  
> --
> 2.15.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU xenial] LP#1748671: fix regression with ipv4 raw_sendmsg

Khaled Elmously
In reply to this post by Andy Whitcroft-3
Applied to xenial/master-next and included in 4.4.0-116.140


On 2018-02-12 19:21:01 , Andy Whitcroft wrote:

> We have reports of a regresion in the 4.4.0-113 upload triggering
> panics in raw_sendmsg.  This was traced to a miss-backport of the
> commit.  Fix this up.
>
> Proposing for SRU to xenial.
>
> -apw
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team