[Trusty][Zesty][SRU][PATCH 0/1] Fix for CVE-2017-14051

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Trusty][Zesty][SRU][PATCH 0/1] Fix for CVE-2017-14051

Po-Hsu Lin (Sam)
From our CVE tracker, only Trusty and Zesty need this patch.

This patch can fix the integer overflow problem in the
qla2x00_sysfs_write_optrom_ctl function in drivers/scsi/qla2xxx/qla_attr.c

Dan Carpenter (1):
  scsi: qla2xxx: Fix an integer overflow in sysfs code

 drivers/scsi/qla2xxx/qla_attr.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[CVE-2017-14051][Trusty][Zesty][SRU][PATCH 1/1] scsi: qla2xxx: Fix an integer overflow in sysfs code

Po-Hsu Lin (Sam)
From: Dan Carpenter <[hidden email]>

CVE-2017-14051

The value of "size" comes from the user.  When we add "start + size" it
could lead to an integer overflow bug.

It means we vmalloc() a lot more memory than we had intended.  I believe
that on 64 bit systems vmalloc() can succeed even if we ask it to
allocate huge 4GB buffers.  So we would get memory corruption and likely
a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().

Only root can trigger this bug.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061

Cc: <[hidden email]>
Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
Reported-by: shqking <[hidden email]>
Signed-off-by: Dan Carpenter <[hidden email]>
Signed-off-by: Martin K. Petersen <[hidden email]>
(cherry picked from commit e6f77540c067b48dee10f1e33678415bfcc89017)
Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 drivers/scsi/qla2xxx/qla_attr.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 5f174b8..08dd6a3 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -303,6 +303,8 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
  return -EINVAL;
  if (start > ha->optrom_size)
  return -EINVAL;
+ if (size > ha->optrom_size - start)
+ size = ha->optrom_size - start;
 
  switch (val) {
  case 0:
@@ -324,8 +326,7 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
  return -EINVAL;
 
  ha->optrom_region_start = start;
- ha->optrom_region_size = start + size > ha->optrom_size ?
-    ha->optrom_size - start : size;
+ ha->optrom_region_size = start + size;
 
  ha->optrom_state = QLA_SREADING;
  ha->optrom_buffer = vmalloc(ha->optrom_region_size);
@@ -392,8 +393,7 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
  }
 
  ha->optrom_region_start = start;
- ha->optrom_region_size = start + size > ha->optrom_size ?
-    ha->optrom_size - start : size;
+ ha->optrom_region_size = start + size;
 
  ha->optrom_state = QLA_SWRITING;
  ha->optrom_buffer = vmalloc(ha->optrom_region_size);
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK[T]: [CVE-2017-14051][Trusty][Zesty][SRU][PATCH 1/1] scsi: qla2xxx: Fix an integer overflow in sysfs code

Kleber Souza
On 01/10/18 10:48, Po-Hsu Lin wrote:

> From: Dan Carpenter <[hidden email]>
>
> CVE-2017-14051
>
> The value of "size" comes from the user.  When we add "start + size" it
> could lead to an integer overflow bug.
>
> It means we vmalloc() a lot more memory than we had intended.  I believe
> that on 64 bit systems vmalloc() can succeed even if we ask it to
> allocate huge 4GB buffers.  So we would get memory corruption and likely
> a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().
>
> Only root can trigger this bug.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061
>
> Cc: <[hidden email]>
> Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
> Reported-by: shqking <[hidden email]>
> Signed-off-by: Dan Carpenter <[hidden email]>
> Signed-off-by: Martin K. Petersen <[hidden email]>
> (cherry picked from commit e6f77540c067b48dee10f1e33678415bfcc89017)
> Signed-off-by: Po-Hsu Lin <[hidden email]>
> ---
>  drivers/scsi/qla2xxx/qla_attr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index 5f174b8..08dd6a3 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -303,6 +303,8 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
>   return -EINVAL;
>   if (start > ha->optrom_size)
>   return -EINVAL;
> + if (size > ha->optrom_size - start)
> + size = ha->optrom_size - start;
>  
>   switch (val) {
>   case 0:
> @@ -324,8 +326,7 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
>   return -EINVAL;
>  
>   ha->optrom_region_start = start;
> - ha->optrom_region_size = start + size > ha->optrom_size ?
> -    ha->optrom_size - start : size;
> + ha->optrom_region_size = start + size;
>  
>   ha->optrom_state = QLA_SREADING;
>   ha->optrom_buffer = vmalloc(ha->optrom_region_size);
> @@ -392,8 +393,7 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
>   }
>  
>   ha->optrom_region_start = start;
> - ha->optrom_region_size = start + size > ha->optrom_size ?
> -    ha->optrom_size - start : size;
> + ha->optrom_region_size = start + size;
>  
>   ha->optrom_state = QLA_SWRITING;
>   ha->optrom_buffer = vmalloc(ha->optrom_region_size);
>

Clean cherry-pick. For trusty:

Acked-by: Kleber Sacilotto de Souza <[hidden email]>


Please note that Zesty has reached EOL and doesn't need this fix.


Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Trusty][SRU][PATCH 0/1] Fix for CVE-2017-14051

Colin King
In reply to this post by Po-Hsu Lin (Sam)
On 10/01/18 09:48, Po-Hsu Lin wrote:

> From our CVE tracker, only Trusty and Zesty need this patch.
>
> This patch can fix the integer overflow problem in the
> qla2x00_sysfs_write_optrom_ctl function in drivers/scsi/qla2xxx/qla_attr.c
>
> Dan Carpenter (1):
>   scsi: qla2xxx: Fix an integer overflow in sysfs code
>
>  drivers/scsi/qla2xxx/qla_attr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
NACK for Zesty (EOL)

For Trusty, clean cherry pick, so:

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED{T]: [CVE-2017-14051][Trusty][Zesty][SRU][PATCH 1/1] scsi: qla2xxx: Fix an integer overflow in sysfs code

Stefan Bader-2
In reply to this post by Po-Hsu Lin (Sam)
On 10.01.2018 10:48, Po-Hsu Lin wrote:

> From: Dan Carpenter <[hidden email]>
>
> CVE-2017-14051
>
> The value of "size" comes from the user.  When we add "start + size" it
> could lead to an integer overflow bug.
>
> It means we vmalloc() a lot more memory than we had intended.  I believe
> that on 64 bit systems vmalloc() can succeed even if we ask it to
> allocate huge 4GB buffers.  So we would get memory corruption and likely
> a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().
>
> Only root can trigger this bug.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061
>
> Cc: <[hidden email]>
> Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
> Reported-by: shqking <[hidden email]>
> Signed-off-by: Dan Carpenter <[hidden email]>
> Signed-off-by: Martin K. Petersen <[hidden email]>
> (cherry picked from commit e6f77540c067b48dee10f1e33678415bfcc89017)
> Signed-off-by: Po-Hsu Lin <[hidden email]>
> ---
>  drivers/scsi/qla2xxx/qla_attr.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> index 5f174b8..08dd6a3 100644
> --- a/drivers/scsi/qla2xxx/qla_attr.c
> +++ b/drivers/scsi/qla2xxx/qla_attr.c
> @@ -303,6 +303,8 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
>   return -EINVAL;
>   if (start > ha->optrom_size)
>   return -EINVAL;
> + if (size > ha->optrom_size - start)
> + size = ha->optrom_size - start;
>  
>   switch (val) {
>   case 0:
> @@ -324,8 +326,7 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
>   return -EINVAL;
>  
>   ha->optrom_region_start = start;
> - ha->optrom_region_size = start + size > ha->optrom_size ?
> -    ha->optrom_size - start : size;
> + ha->optrom_region_size = start + size;
>  
>   ha->optrom_state = QLA_SREADING;
>   ha->optrom_buffer = vmalloc(ha->optrom_region_size);
> @@ -392,8 +393,7 @@ qla2x00_sysfs_write_optrom_ctl(struct file *filp, struct kobject *kobj,
>   }
>  
>   ha->optrom_region_start = start;
> - ha->optrom_region_size = start + size > ha->optrom_size ?
> -    ha->optrom_size - start : size;
> + ha->optrom_region_size = start + size;
>  
>   ha->optrom_state = QLA_SWRITING;
>   ha->optrom_buffer = vmalloc(ha->optrom_region_size);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment