[X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Heitor Alves de Siqueira
BugLink: https://bugs.launchpad.net/bugs/1848236

[Impact]
Some wireless Intel cards that use the iwlmvm driver are not available
during installation.

[Test Case]
Boot up the Ubuntu installer on a system with an iwlmvm adapter, and try
using the wireless connection.

[Fix]
Add the missing sub-module to debian.master/d-i/nic-modules

[Regression Potential]
As we're including a new sub-module, this change makes the installer
susceptible to bugs present in the iwlmvm driver. Other than that, this
change should not introduce any new regressions as it doesn't change any
driver code.

Heitor Alves de Siqueira (1):
  UBUNTU: d-i: Add iwlmvm to nic-modules

 debian.master/d-i/modules/nic-modules | 1 +
 1 file changed, 1 insertion(+)

--
2.23.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[X/B/D/E][PATCH 1/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Heitor Alves de Siqueira
BugLink: https://bugs.launchpad.net/bugs/1848236

Signed-off-by: Heitor Alves de Siqueira <[hidden email]>
---
 debian.master/d-i/modules/nic-modules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules
index 5a59ddf9e1b6..3bd35f81020a 100644
--- a/debian.master/d-i/modules/nic-modules
+++ b/debian.master/d-i/modules/nic-modules
@@ -98,6 +98,7 @@ iwl3945 ?
 iwl4965 ?
 iwl-legacy ?
 iwldvm ?
+iwlmvm ?
 iwlwifi ?
 ixgb ?
 ixgbe ?
--
2.23.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[Unstable]/cmt: [X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Seth Forshee
In reply to this post by Heitor Alves de Siqueira
On Tue, Oct 15, 2019 at 03:07:16PM -0300, Heitor Alves de Siqueira wrote:

> BugLink: https://bugs.launchpad.net/bugs/1848236
>
> [Impact]
> Some wireless Intel cards that use the iwlmvm driver are not available
> during installation.
>
> [Test Case]
> Boot up the Ubuntu installer on a system with an iwlmvm adapter, and try
> using the wireless connection.
>
> [Fix]
> Add the missing sub-module to debian.master/d-i/nic-modules
>
> [Regression Potential]
> As we're including a new sub-module, this change makes the installer
> susceptible to bugs present in the iwlmvm driver. Other than that, this
> change should not introduce any new regressions as it doesn't change any
> driver code.

I'm surprised we haven't noticed this before. I'm not sure how this
benefits disco though, or even xenial and bionic as afaik we aren't
still generating desktop installer images using the GA kernel. Even for
eoan, is there any benefit unless we respin to include the change (which
seems unlikely at this point)?

We do want to make sure this gets into the hwe-edge kernel though to
ensure it's included in the next 20.04 point release.

Applied to unstable/master. Holding my ack for the stable series kernels
until I understand what benefit there is to having it there.

Thanks,
Seth

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED[Unstable]/cmt: [X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Heitor Alves de Siqueira
On Tue, Oct 15, 2019 at 3:45 PM Seth Forshee <[hidden email]> wrote:

>
> I'm surprised we haven't noticed this before. I'm not sure how this
> benefits disco though, or even xenial and bionic as afaik we aren't
> still generating desktop installer images using the GA kernel. Even for
> eoan, is there any benefit unless we respin to include the change (which
> seems unlikely at this point)?
>
> We do want to make sure this gets into the hwe-edge kernel though to
> ensure it's included in the next 20.04 point release.
>
> Applied to unstable/master. Holding my ack for the stable series kernels
> until I understand what benefit there is to having it there.
>
> Thanks,
> Seth

Hi Seth!
Thanks for applying it to unstable. Apologies for not tagging the patch for
that, but it would indeed be good to have that in the 20.04 release! :)

As for the other stable series, wouldn't the netboot mini.iso benefit from
having the driver included? I think that would get automatically rebuilt to
include this change, so users working with the daily releases or the mini.iso
would still benefit from this patch (even if we don't have any new point
releases for the older Series). Would that be an appropriate use case?

Thanks,
Heitor

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: APPLIED[Unstable]/cmt: [X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Seth Forshee
On Wed, Oct 16, 2019 at 03:10:36PM -0300, Heitor Alves de Siqueira wrote:

> On Tue, Oct 15, 2019 at 3:45 PM Seth Forshee <[hidden email]> wrote:
> >
> > I'm surprised we haven't noticed this before. I'm not sure how this
> > benefits disco though, or even xenial and bionic as afaik we aren't
> > still generating desktop installer images using the GA kernel. Even for
> > eoan, is there any benefit unless we respin to include the change (which
> > seems unlikely at this point)?
> >
> > We do want to make sure this gets into the hwe-edge kernel though to
> > ensure it's included in the next 20.04 point release.
> >
> > Applied to unstable/master. Holding my ack for the stable series kernels
> > until I understand what benefit there is to having it there.
> >
> > Thanks,
> > Seth
>
> Hi Seth!
> Thanks for applying it to unstable. Apologies for not tagging the patch for
> that, but it would indeed be good to have that in the 20.04 release! :)
>
> As for the other stable series, wouldn't the netboot mini.iso benefit from
> having the driver included? I think that would get automatically rebuilt to
> include this change, so users working with the daily releases or the mini.iso
> would still benefit from this patch (even if we don't have any new point
> releases for the older Series). Would that be an appropriate use case?

I wasn't aware we did daily builds of the mini.iso for stable releases,
and I wouldn't have guessed that the sorts of systems with wireless
cards are generally netbooted. But if so the change is useful, and even
if not it should be harmless, so:

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [X/B/D/E][PATCH 1/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Kleber Souza
In reply to this post by Heitor Alves de Siqueira
On 15.10.19 20:07, Heitor Alves de Siqueira wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848236
>
> Signed-off-by: Heitor Alves de Siqueira <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  debian.master/d-i/modules/nic-modules | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules
> index 5a59ddf9e1b6..3bd35f81020a 100644
> --- a/debian.master/d-i/modules/nic-modules
> +++ b/debian.master/d-i/modules/nic-modules
> @@ -98,6 +98,7 @@ iwl3945 ?
>  iwl4965 ?
>  iwl-legacy ?
>  iwldvm ?
> +iwlmvm ?
>  iwlwifi ?
>  ixgb ?
>  ixgbe ?
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [X/B/D/E][PATCH 0/1] UBUNTU: d-i: Add iwlmvm to nic-modules

Kleber Souza
In reply to this post by Heitor Alves de Siqueira
On 15.10.19 20:07, Heitor Alves de Siqueira wrote:

> BugLink: https://bugs.launchpad.net/bugs/1848236
>
> [Impact]
> Some wireless Intel cards that use the iwlmvm driver are not available
> during installation.
>
> [Test Case]
> Boot up the Ubuntu installer on a system with an iwlmvm adapter, and try
> using the wireless connection.
>
> [Fix]
> Add the missing sub-module to debian.master/d-i/nic-modules
>
> [Regression Potential]
> As we're including a new sub-module, this change makes the installer
> susceptible to bugs present in the iwlmvm driver. Other than that, this
> change should not introduce any new regressions as it doesn't change any
> driver code.
>
> Heitor Alves de Siqueira (1):
>   UBUNTU: d-i: Add iwlmvm to nic-modules
>
>  debian.master/d-i/modules/nic-modules | 1 +
>  1 file changed, 1 insertion(+)
>

Applied to xenial, bionic, disco and eoan master-next branches.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team