[X/B/F/G/H/Unstable][SRU][PATCH 0/1] DMI entry syntax fix for Pegatron / ByteSpeed C15B

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[X/B/F/G/H/Unstable][SRU][PATCH 0/1] DMI entry syntax fix for Pegatron / ByteSpeed C15B

Po-Hsu Lin (Sam)
[Impact]
Upstream reports that when compiling the kernel with a48491c65b51
("Input: i8042 - add ByteSpeed touchpad to noloop table"), g++ will
complain about:
    drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’
    designator used multiple times in the same initializer list

C99 semantics is that last duplicated initialiser wins,
so DMI entry gets overwritten.

[Fix]
* a3a9060ecad030 ("Input: i8042 - unbreak Pegatron C15B") in linux-next

This can be cherry-picked into all the affected series.
Note that patch for bug 1906128 should be applied first.

[Test]
I didn't get this error while building the test kernels for bug
1906128 on builder kathleen, with fakeroot commands.

So the only thing that I can test is to build them again and make
sure there is no other issues.

[Where problems could occur]
If this fix is incorrect it might affect the touchpad support on
Pegatron / ByteSpeed C15B laptop.

Alexey Dobriyan (1):
  Input: i8042 - unbreak Pegatron C15B

 drivers/input/serio/i8042-x86ia64io.h | 2 ++
 1 file changed, 2 insertions(+)

--
2.7.4

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[X/B/F/G/H/Unstable][SRU][PATCH 1/1] Input: i8042 - unbreak Pegatron C15B

Po-Hsu Lin (Sam)
From: Alexey Dobriyan <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1910639

g++ reports

        drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list

C99 semantics is that last duplicated initialiser wins,
so DMI entry gets overwritten.

Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
Signed-off-by: Alexey Dobriyan <[hidden email]>
Acked-by: Po-Hsu Lin <[hidden email]>
Link: https://lore.kernel.org/r/20201228072335.GA27766@...
Signed-off-by: Dmitry Torokhov <[hidden email]>
(cherry picked from commit a3a9060ecad030e2c7903b2b258383d2c716b56c linux-next)
Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 drivers/input/serio/i8042-x86ia64io.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 1f45010..e0176ba 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -223,6 +223,8 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
  DMI_MATCH(DMI_SYS_VENDOR, "PEGATRON CORPORATION"),
  DMI_MATCH(DMI_PRODUCT_NAME, "C15B"),
  },
+ },
+ {
  .matches = {
  DMI_MATCH(DMI_SYS_VENDOR, "ByteSpeed LLC"),
  DMI_MATCH(DMI_PRODUCT_NAME, "ByteSpeed Laptop C15B"),
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmt: [X/B/F/G/H/Unstable][SRU][PATCH 0/1] DMI entry syntax fix for Pegatron / ByteSpeed C15B

William Breathitt Gray
In reply to this post by Po-Hsu Lin (Sam)
On Fri, Jan 08, 2021 at 01:34:01PM +0800, Po-Hsu Lin wrote:

> [Impact]
> Upstream reports that when compiling the kernel with a48491c65b51
> ("Input: i8042 - add ByteSpeed touchpad to noloop table"), g++ will
> complain about:
>     drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’
>     designator used multiple times in the same initializer list
>
> C99 semantics is that last duplicated initialiser wins,
> so DMI entry gets overwritten.
>
> [Fix]
> * a3a9060ecad030 ("Input: i8042 - unbreak Pegatron C15B") in linux-next
>
> This can be cherry-picked into all the affected series.
> Note that patch for bug 1906128 should be applied first.
>
> [Test]
> I didn't get this error while building the test kernels for bug
> 1906128 on builder kathleen, with fakeroot commands.
>
> So the only thing that I can test is to build them again and make
> sure there is no other issues.
>
> [Where problems could occur]
> If this fix is incorrect it might affect the touchpad support on
> Pegatron / ByteSpeed C15B laptop.
>
> Alexey Dobriyan (1):
>   Input: i8042 - unbreak Pegatron C15B
>
>  drivers/input/serio/i8042-x86ia64io.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.7.4
Acked-by: William Breathitt Gray <[hidden email]>

By the way, if your patch requires prerequisite patches as you mention,
please provide the `git patch-id --stable` patch ID for it; this helps
make sure the patches are applied in the correct order. You can have
`git format-patch` generate this automatically for you by using the
`--base` option:
https://git-scm.com/docs/git-format-patch#_base_tree_information

William Breathitt Gray

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/Cmt: [X/B/F/G/H/Unstable][SRU][PATCH 0/1] DMI entry syntax fix for Pegatron / ByteSpeed C15B

Po-Hsu Lin (Sam)
On Fri, Jan 8, 2021 at 3:21 PM William Breathitt Gray
<[hidden email]> wrote:

>
> On Fri, Jan 08, 2021 at 01:34:01PM +0800, Po-Hsu Lin wrote:
> > [Impact]
> > Upstream reports that when compiling the kernel with a48491c65b51
> > ("Input: i8042 - add ByteSpeed touchpad to noloop table"), g++ will
> > complain about:
> >     drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’
> >     designator used multiple times in the same initializer list
> >
> > C99 semantics is that last duplicated initialiser wins,
> > so DMI entry gets overwritten.
> >
> > [Fix]
> > * a3a9060ecad030 ("Input: i8042 - unbreak Pegatron C15B") in linux-next
> >
> > This can be cherry-picked into all the affected series.
> > Note that patch for bug 1906128 should be applied first.
> >
> > [Test]
> > I didn't get this error while building the test kernels for bug
> > 1906128 on builder kathleen, with fakeroot commands.
> >
> > So the only thing that I can test is to build them again and make
> > sure there is no other issues.
> >
> > [Where problems could occur]
> > If this fix is incorrect it might affect the touchpad support on
> > Pegatron / ByteSpeed C15B laptop.
> >
> > Alexey Dobriyan (1):
> >   Input: i8042 - unbreak Pegatron C15B
> >
> >  drivers/input/serio/i8042-x86ia64io.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > --
> > 2.7.4
>
> Acked-by: William Breathitt Gray <[hidden email]>
>
> By the way, if your patch requires prerequisite patches as you mention,
> please provide the `git patch-id --stable` patch ID for it; this helps
> make sure the patches are applied in the correct order. You can have
> `git format-patch` generate this automatically for you by using the
> `--base` option:
> https://git-scm.com/docs/git-format-patch#_base_tree_information
>

Oh! Didn't try this before.
Thanks for the info!
Sam

> William Breathitt Gray

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED U: Re: [X/B/F/G/H/Unstable][SRU][PATCH 1/1] Input: i8042 - unbreak Pegatron C15B

Paolo Pisati-5
In reply to this post by Po-Hsu Lin (Sam)
On Fri, Jan 08, 2021 at 01:34:02PM +0800, Po-Hsu Lin wrote:

> From: Alexey Dobriyan <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1910639
>
> g++ reports
>
> drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list
>
> C99 semantics is that last duplicated initialiser wins,
> so DMI entry gets overwritten.
>
> Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
> Signed-off-by: Alexey Dobriyan <[hidden email]>
> Acked-by: Po-Hsu Lin <[hidden email]>
> Link: https://lore.kernel.org/r/20201228072335.GA27766@...
> Signed-off-by: Dmitry Torokhov <[hidden email]>
> (cherry picked from commit a3a9060ecad030e2c7903b2b258383d2c716b56c linux-next)
> Signed-off-by: Po-Hsu Lin <[hidden email]>

--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [X/B/F/G/H/Unstable][SRU][PATCH 1/1] Input: i8042 - unbreak Pegatron C15B

Stefan Bader-2
In reply to this post by Po-Hsu Lin (Sam)
On 08.01.21 06:34, Po-Hsu Lin wrote:

> From: Alexey Dobriyan <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1910639
>
> g++ reports
>
> drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’ designator used multiple times in the same initializer list
>
> C99 semantics is that last duplicated initialiser wins,
> so DMI entry gets overwritten.
>
> Fixes: a48491c65b51 ("Input: i8042 - add ByteSpeed touchpad to noloop table")
> Signed-off-by: Alexey Dobriyan <[hidden email]>
> Acked-by: Po-Hsu Lin <[hidden email]>
> Link: https://lore.kernel.org/r/20201228072335.GA27766@...
> Signed-off-by: Dmitry Torokhov <[hidden email]>
> (cherry picked from commit a3a9060ecad030e2c7903b2b258383d2c716b56c linux-next)
> Signed-off-by: Po-Hsu Lin <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

As William already stated, referring to a pre-requisite somewhere in a cover
email indirectly by stating a bug number is rather pointless. IF it is the patch
mentioned in "Fixes:", then say so. If not, add at least an additional "Fixes"
(probably the git command mentioned by William does something like that, it
feels new so I have not tried yet myself). But in general, when looking at
patches on the mailing list one should not need to go on a wild hunt for info.

-Stefan

>  drivers/input/serio/i8042-x86ia64io.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index 1f45010..e0176ba 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -223,6 +223,8 @@ static const struct dmi_system_id __initconst i8042_dmi_noloop_table[] = {
>   DMI_MATCH(DMI_SYS_VENDOR, "PEGATRON CORPORATION"),
>   DMI_MATCH(DMI_PRODUCT_NAME, "C15B"),
>   },
> + },
> + {
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "ByteSpeed LLC"),
>   DMI_MATCH(DMI_PRODUCT_NAME, "ByteSpeed Laptop C15B"),
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[X/B/F/G]: [X/B/F/G/H/Unstable][SRU][PATCH 0/1] DMI entry syntax fix for Pegatron / ByteSpeed C15B

Kelsey Skunberg
In reply to this post by Po-Hsu Lin (Sam)
Applied to X/B/F/G master-next. thank you!

-Kelsey

On 2021-01-08 13:34:01 , Po-Hsu Lin wrote:

> [Impact]
> Upstream reports that when compiling the kernel with a48491c65b51
> ("Input: i8042 - add ByteSpeed touchpad to noloop table"), g++ will
> complain about:
>     drivers/input/serio/i8042-x86ia64io.h:225:3: error: ‘.matches’
>     designator used multiple times in the same initializer list
>
> C99 semantics is that last duplicated initialiser wins,
> so DMI entry gets overwritten.
>
> [Fix]
> * a3a9060ecad030 ("Input: i8042 - unbreak Pegatron C15B") in linux-next
>
> This can be cherry-picked into all the affected series.
> Note that patch for bug 1906128 should be applied first.
>
> [Test]
> I didn't get this error while building the test kernels for bug
> 1906128 on builder kathleen, with fakeroot commands.
>
> So the only thing that I can test is to build them again and make
> sure there is no other issues.
>
> [Where problems could occur]
> If this fix is incorrect it might affect the touchpad support on
> Pegatron / ByteSpeed C15B laptop.
>
> Alexey Dobriyan (1):
>   Input: i8042 - unbreak Pegatron C15B
>
>  drivers/input/serio/i8042-x86ia64io.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.7.4
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team