[X][B][SRU][PATCH 0/1] selftests/net: correct the return value for run_afpackettests

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[X][B][SRU][PATCH 0/1] selftests/net: correct the return value for run_afpackettests

Po-Hsu Lin (Sam)
== Justification ==
The run_afpackettests will be marked as passed regardless the return
value of those sub-tests in the script:
    --------------------
    running psock_tpacket test
    --------------------
    [FAIL]
    selftests: run_afpackettests [PASS]

Fix this by changing the return value for each tests.

== Fix ==
* 8c03557 (selftests/net: correct the return value for run_afpackettests)

This patch has alreay landed on newer releases and D with stable
updates.
For X and B this can be backported with the same logic.

== Test ==
Tested on a Xenial KVM with this patch applied on these two trees, when
the test failed the return value will be 1 instead of 0 as expected.

== Regression Potential ==
* Low, it's just reflecting the real test return value. We may see this
test failing on some kernels but it's good as it's reporting a real bug.

Po-Hsu Lin (1):
  selftests/net: correct the return value for run_afpackettests

 tools/testing/selftests/net/run_afpackettests | 4 ++++
 1 file changed, 4 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[X][B][SRU][PATCH 1/1] selftests/net: correct the return value for run_afpackettests

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1825778

The run_afpackettests will be marked as passed regardless the return
value of those sub-tests in the script:
    --------------------
    running psock_tpacket test
    --------------------
    [FAIL]
    selftests: run_afpackettests [PASS]

Fix this by changing the return value for each tests.

Signed-off-by: Po-Hsu Lin <[hidden email]>
Signed-off-by: David S. Miller <[hidden email]>
(backported from commit 8c03557c3f25271e62e39154af66ebdd1b59c9ca)
[PHLin: backported with the same logic]
Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 tools/testing/selftests/net/run_afpackettests | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/net/run_afpackettests b/tools/testing/selftests/net/run_afpackettests
index 5246e78..e33a555 100755
--- a/tools/testing/selftests/net/run_afpackettests
+++ b/tools/testing/selftests/net/run_afpackettests
@@ -5,12 +5,14 @@ if [ $(id -u) != 0 ]; then
  exit 0
 fi
 
+ret=0
 echo "--------------------"
 echo "running psock_fanout test"
 echo "--------------------"
 ./psock_fanout
 if [ $? -ne 0 ]; then
  echo "[FAIL]"
+ ret=1
 else
  echo "[PASS]"
 fi
@@ -21,6 +23,8 @@ echo "--------------------"
 ./psock_tpacket
 if [ $? -ne 0 ]; then
  echo "[FAIL]"
+ ret=1
 else
  echo "[PASS]"
 fi
+exit $ret
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [X][B][SRU][PATCH 1/1] selftests/net: correct the return value for run_afpackettests

Thadeu Lima de Souza Cascardo-3
Acked-by: Thadeu Lima de Souza Cascardo <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [X][B][SRU][PATCH 1/1] selftests/net: correct the return value for run_afpackettests

Connor Kuehl
In reply to this post by Po-Hsu Lin (Sam)
On 12/6/19 4:07 AM, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1825778
>
> The run_afpackettests will be marked as passed regardless the return
> value of those sub-tests in the script:
>      --------------------
>      running psock_tpacket test
>      --------------------
>      [FAIL]
>      selftests: run_afpackettests [PASS]
>
> Fix this by changing the return value for each tests.
>
> Signed-off-by: Po-Hsu Lin <[hidden email]>
> Signed-off-by: David S. Miller <[hidden email]>
> (backported from commit 8c03557c3f25271e62e39154af66ebdd1b59c9ca)
> [PHLin: backported with the same logic]
> Signed-off-by: Po-Hsu Lin <[hidden email]>

Acked-by: Connor Kuehl <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [X][B][SRU][PATCH 0/1] selftests/net: correct the return value for run_afpackettests

Kleber Souza
In reply to this post by Po-Hsu Lin (Sam)
On 2019-12-06 13:07, Po-Hsu Lin wrote:

> == Justification ==
> The run_afpackettests will be marked as passed regardless the return
> value of those sub-tests in the script:
>     --------------------
>     running psock_tpacket test
>     --------------------
>     [FAIL]
>     selftests: run_afpackettests [PASS]
>
> Fix this by changing the return value for each tests.
>
> == Fix ==
> * 8c03557 (selftests/net: correct the return value for run_afpackettests)
>
> This patch has alreay landed on newer releases and D with stable
> updates.
> For X and B this can be backported with the same logic.
>
> == Test ==
> Tested on a Xenial KVM with this patch applied on these two trees, when
> the test failed the return value will be 1 instead of 0 as expected.
>
> == Regression Potential ==
> * Low, it's just reflecting the real test return value. We may see this
> test failing on some kernels but it's good as it's reporting a real bug.
>
> Po-Hsu Lin (1):
>   selftests/net: correct the return value for run_afpackettests
>
>  tools/testing/selftests/net/run_afpackettests | 4 ++++
>  1 file changed, 4 insertions(+)
>

Applied to xenial and bionic master-next branches.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team