[X/Z/A/Linux-OEM][PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[X/Z/A/Linux-OEM][PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Aaron Ma
BugLink: https://bugs.launchpad.net/bugs/1733605

[Impact]
Elantech touchpad on Lenovo laptops L480/580 report it's version as 15,
and current kernel can not support this hw_version,
so driver didn't support horizontal,vertical and multi-touch.
error log:
kernel: psmouse serio1: elantech: unknown hardware version, aborting...

[Fix]
Add the ictype as hw_version 4 to support this new touchpad.

[Test Case]
Tested on Lenovo L480/580, touchpad/trackstick works fine, multi-touch
ok.

[Regression Potential]
Add new ictype of on specific touchpad, no regression is supposed.

Aaron Ma (1):
  Input: elantech - add new icbody type 15

 drivers/input/mouse/elantech.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.13.6


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] Input: elantech - add new icbody type 15

Aaron Ma
BugLink: https://bugs.launchpad.net/bugs/1733605

The touchpad of Lenovo Thinkpad L480 reports it's version as 15.

Link: https://patchwork.kernel.org/patch/10065519/

Cc: [hidden email]
Signed-off-by: Aaron Ma <[hidden email]>
---
 drivers/input/mouse/elantech.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 6f4dc0fd2ca3..51b96e9bf793 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1613,7 +1613,7 @@ static int elantech_set_properties(struct elantech_data *etd)
  case 5:
  etd->hw_version = 3;
  break;
- case 6 ... 14:
+ case 6 ... 15:
  etd->hw_version = 4;
  break;
  default:
--
2.13.6


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [PATCH 1/1] Input: elantech - add new icbody type 15

Po-Hsu Lin (Sam)
Do we need this for the Bionic kernel?

Since there is already a positive test result, thus
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [PATCH 1/1] Input: elantech - add new icbody type 15

Aaron Ma
Yes, Bionic needs this patch too, thanks for reminder.

Aaron

On 11/22/2017 05:00 PM, Po-Hsu Lin wrote:
> Do we need this for the Bionic kernel?
>
> Since there is already a positive test result, thus
> Acked-by: Po-Hsu Lin <[hidden email]>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [X/Z/A/B/Linux-OEM][PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Aaron Ma
In reply to this post by Aaron Ma
Bionic needs this patch too, add B in subject.

Aaron

On 11/22/2017 01:00 PM, Aaron Ma wrote:

> BugLink: https://bugs.launchpad.net/bugs/1733605
>
> [Impact]
> Elantech touchpad on Lenovo laptops L480/580 report it's version as 15,
> and current kernel can not support this hw_version,
> so driver didn't support horizontal,vertical and multi-touch.
> error log:
> kernel: psmouse serio1: elantech: unknown hardware version, aborting...
>
> [Fix]
> Add the ictype as hw_version 4 to support this new touchpad.
>
> [Test Case]
> Tested on Lenovo L480/580, touchpad/trackstick works fine, multi-touch
> ok.
>
> [Regression Potential]
> Add new ictype of on specific touchpad, no regression is supposed.
>
> Aaron Ma (1):
>   Input: elantech - add new icbody type 15
>
>  drivers/input/mouse/elantech.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [X/Z/A/B/Linux-OEM][PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Hui Wang
On 2017年11月22日 22:49, Aaron Ma wrote:
Bionic needs this patch too, add B in subject.

Aaron

Acked-by: Hui Wang [hidden email]

On 11/22/2017 01:00 PM, Aaron Ma wrote:
BugLink: https://bugs.launchpad.net/bugs/1733605

[Impact]
Elantech touchpad on Lenovo laptops L480/580 report it's version as 15,
and current kernel can not support this hw_version,
so driver didn't support horizontal,vertical and multi-touch.
error log:
kernel: psmouse serio1: elantech: unknown hardware version, aborting...

[Fix]
Add the ictype as hw_version 4 to support this new touchpad.

[Test Case]
Tested on Lenovo L480/580, touchpad/trackstick works fine, multi-touch
ok.

[Regression Potential]
Add new ictype of on specific touchpad, no regression is supposed.

Aaron Ma (1):
  Input: elantech - add new icbody type 15

 drivers/input/mouse/elantech.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


    



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [X/Z/A/Linux-OEM][PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Timo Aaltonen-6
In reply to this post by Aaron Ma
On 22.11.2017 07:00, Aaron Ma wrote:

> BugLink: https://bugs.launchpad.net/bugs/1733605
>
> [Impact]
> Elantech touchpad on Lenovo laptops L480/580 report it's version as 15,
> and current kernel can not support this hw_version,
> so driver didn't support horizontal,vertical and multi-touch.
> error log:
> kernel: psmouse serio1: elantech: unknown hardware version, aborting...
>
> [Fix]
> Add the ictype as hw_version 4 to support this new touchpad.
>
> [Test Case]
> Tested on Lenovo L480/580, touchpad/trackstick works fine, multi-touch
> ok.
>
> [Regression Potential]
> Add new ictype of on specific touchpad, no regression is supposed.
>
> Aaron Ma (1):
>   Input: elantech - add new icbody type 15
>
>  drivers/input/mouse/elantech.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

applied to linux-oem, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED: [X/Z/A/Linux-OEM][PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Kleber Souza
On 11/26/17 17:31, Timo Aaltonen wrote:

> On 22.11.2017 07:00, Aaron Ma wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1733605
>>
>> [Impact]
>> Elantech touchpad on Lenovo laptops L480/580 report it's version as 15,
>> and current kernel can not support this hw_version,
>> so driver didn't support horizontal,vertical and multi-touch.
>> error log:
>> kernel: psmouse serio1: elantech: unknown hardware version, aborting...
>>
>> [Fix]
>> Add the ictype as hw_version 4 to support this new touchpad.
>>
>> [Test Case]
>> Tested on Lenovo L480/580, touchpad/trackstick works fine, multi-touch
>> ok.
>>
>> [Regression Potential]
>> Add new ictype of on specific touchpad, no regression is supposed.
>>
>> Aaron Ma (1):
>>   Input: elantech - add new icbody type 15
>>
>>  drivers/input/mouse/elantech.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> applied to linux-oem, thanks
>

Hi Timo,

When partially applying a patch (not on all the kernels it has been
submitted to), please add this information to the email subject (for
example "APPLIED[Linux-OEM]: ...") so it makes it easier to the stable
team to identify for which kernels the patch is still left to be applied.


Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED: [X/Z/A/B] [PATCH 0/1] Add new ictype of elantech touchpad on Lenovo

Aaron Ma

On 11/28/2017 04:16 PM, Kleber Souza wrote:

> On 11/26/17 17:31, Timo Aaltonen wrote:
>> On 22.11.2017 07:00, Aaron Ma wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1733605
>>>
>>> [Impact]
>>> Elantech touchpad on Lenovo laptops L480/580 report it's version as 15,
>>> and current kernel can not support this hw_version,
>>> so driver didn't support horizontal,vertical and multi-touch.
>>> error log:
>>> kernel: psmouse serio1: elantech: unknown hardware version, aborting...
>>>
>>> [Fix]
>>> Add the ictype as hw_version 4 to support this new touchpad.
>>>
>>> [Test Case]
>>> Tested on Lenovo L480/580, touchpad/trackstick works fine, multi-touch
>>> ok.
>>>
>>> [Regression Potential]
>>> Add new ictype of on specific touchpad, no regression is supposed.
>>>
>>> Aaron Ma (1):
>>>   Input: elantech - add new icbody type 15
>>>
>>>  drivers/input/mouse/elantech.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> applied to linux-oem, thanks
>>
>
> Hi Timo,
>
> When partially applying a patch (not on all the kernels it has been
> submitted to), please add this information to the email subject (for
> example "APPLIED[Linux-OEM]: ...") so it makes it easier to the stable
> team to identify for which kernels the patch is still left to be applied.
>

Hi Kleber:

Could anyone apply this patch to X/Z/A/B kernel?

Regards,
Aaron


>
> Thanks,
> Kleber
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team