[Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

John Johansen-2
apparmor_initialized is no longer init only data and the __initdata
tagging was removed from the variable definition in
security/apparmor/lsm.c but missed being removed from the declaration
in security/apparmor/include/lib.h

resulting in the following build warning

WARNING: vmlinux.o(.text+0x393a60): Section mismatch in reference from the function param_set_aauint() to the variable .init.data:apparmor_initialized

Signed-off-by: John Johansen <[hidden email]>
---
 security/apparmor/include/lib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h
index 954e22ae8342..3f3b8d09f1c5 100644
--- a/security/apparmor/include/lib.h
+++ b/security/apparmor/include/lib.h
@@ -56,7 +56,7 @@
  } while (0)
 
 /* Flag indicating whether initialization completed */
-extern int apparmor_initialized __initdata;
+extern int apparmor_initialized;
 
 /* fn's in lib */
 char *aa_split_fqname(char *args, char **ns_name);
--
2.14.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

Stefan Bader-2
On 13.03.2018 21:48, John Johansen wrote:
> apparmor_initialized is no longer init only data and the __initdata
> tagging was removed from the variable definition in
> security/apparmor/lsm.c but missed being removed from the declaration
> in security/apparmor/include/lib.h
>
> resulting in the following build warning
>
> WARNING: vmlinux.o(.text+0x393a60): Section mismatch in reference from the function param_set_aauint() to the variable .init.data:apparmor_initialized

LP Bug reference?

-Stefan

>
> Signed-off-by: John Johansen <[hidden email]>
> ---
>  security/apparmor/include/lib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h
> index 954e22ae8342..3f3b8d09f1c5 100644
> --- a/security/apparmor/include/lib.h
> +++ b/security/apparmor/include/lib.h
> @@ -56,7 +56,7 @@
>   } while (0)
>  
>  /* Flag indicating whether initialization completed */
> -extern int apparmor_initialized __initdata;
> +extern int apparmor_initialized;
>  
>  /* fn's in lib */
>  char *aa_split_fqname(char *args, char **ns_name);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

John Johansen-2
On 03/20/2018 06:13 AM, Stefan Bader wrote:

> On 13.03.2018 21:48, John Johansen wrote:
>> apparmor_initialized is no longer init only data and the __initdata
>> tagging was removed from the variable definition in
>> security/apparmor/lsm.c but missed being removed from the declaration
>> in security/apparmor/include/lib.h
>>
>> resulting in the following build warning
>>
>> WARNING: vmlinux.o(.text+0x393a60): Section mismatch in reference from the function param_set_aauint() to the variable .init.data:apparmor_initialized
>
> LP Bug reference?

oops sorry
BugLink: http://bugs.launchpad.net/bugs/1758471

>
> -Stefan
>
>>
>> Signed-off-by: John Johansen <[hidden email]>
>> ---
>>  security/apparmor/include/lib.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h
>> index 954e22ae8342..3f3b8d09f1c5 100644
>> --- a/security/apparmor/include/lib.h
>> +++ b/security/apparmor/include/lib.h
>> @@ -56,7 +56,7 @@
>>   } while (0)
>>  
>>  /* Flag indicating whether initialization completed */
>> -extern int apparmor_initialized __initdata;
>> +extern int apparmor_initialized;
>>  
>>  /* fn's in lib */
>>  char *aa_split_fqname(char *args, char **ns_name);
>>
>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

Stefan Bader-2
In reply to this post by John Johansen-2
On 13.03.2018 21:48, John Johansen wrote:
> apparmor_initialized is no longer init only data and the __initdata
> tagging was removed from the variable definition in
> security/apparmor/lsm.c but missed being removed from the declaration
> in security/apparmor/include/lib.h
>
> resulting in the following build warning
>
> WARNING: vmlinux.o(.text+0x393a60): Section mismatch in reference from the function param_set_aauint() to the variable .init.data:apparmor_initialized
>
BugLink: http://bugs.launchpad.net/bugs/1758471

> Signed-off-by: John Johansen <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---

Note to fix/add BugLink upon commit

>  security/apparmor/include/lib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h
> index 954e22ae8342..3f3b8d09f1c5 100644
> --- a/security/apparmor/include/lib.h
> +++ b/security/apparmor/include/lib.h
> @@ -56,7 +56,7 @@
>   } while (0)
>  
>  /* Flag indicating whether initialization completed */
> -extern int apparmor_initialized __initdata;
> +extern int apparmor_initialized;
>  
>  /* fn's in lib */
>  char *aa_split_fqname(char *args, char **ns_name);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

Kleber Souza
In reply to this post by John Johansen-2
On 03/13/18 21:48, John Johansen wrote:

> apparmor_initialized is no longer init only data and the __initdata
> tagging was removed from the variable definition in
> security/apparmor/lsm.c but missed being removed from the declaration
> in security/apparmor/include/lib.h
>
> resulting in the following build warning
>
> WARNING: vmlinux.o(.text+0x393a60): Section mismatch in reference from the function param_set_aauint() to the variable .init.data:apparmor_initialized
>
> Signed-off-by: John Johansen <[hidden email]>
> ---
>  security/apparmor/include/lib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h
> index 954e22ae8342..3f3b8d09f1c5 100644
> --- a/security/apparmor/include/lib.h
> +++ b/security/apparmor/include/lib.h
> @@ -56,7 +56,7 @@
>   } while (0)
>  
>  /* Flag indicating whether initialization completed */
> -extern int apparmor_initialized __initdata;
> +extern int apparmor_initialized;
>  
>  /* fn's in lib */
>  char *aa_split_fqname(char *args, char **ns_name);
>

Given the BugLink reference is added when applying the patch:

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/cmnt: [Xenial SRU] UBUNTU: SAUCE: apparmor: fix bad __initdata tagging on, apparmor_initialized

Kleber Souza
In reply to this post by John Johansen-2
On 03/13/18 21:48, John Johansen wrote:

> apparmor_initialized is no longer init only data and the __initdata
> tagging was removed from the variable definition in
> security/apparmor/lsm.c but missed being removed from the declaration
> in security/apparmor/include/lib.h
>
> resulting in the following build warning
>
> WARNING: vmlinux.o(.text+0x393a60): Section mismatch in reference from the function param_set_aauint() to the variable .init.data:apparmor_initialized
>
> Signed-off-by: John Johansen <[hidden email]>
> ---
>  security/apparmor/include/lib.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/include/lib.h b/security/apparmor/include/lib.h
> index 954e22ae8342..3f3b8d09f1c5 100644
> --- a/security/apparmor/include/lib.h
> +++ b/security/apparmor/include/lib.h
> @@ -56,7 +56,7 @@
>   } while (0)
>  
>  /* Flag indicating whether initialization completed */
> -extern int apparmor_initialized __initdata;
> +extern int apparmor_initialized;
>  
>  /* fn's in lib */
>  char *aa_split_fqname(char *args, char **ns_name);
>

Applied to xenial/master-next branch, adding the BugLink reference.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team