[Xenial][deb-to-snap master][Patch] deb to snap: install updates before building

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Xenial][deb-to-snap master][Patch] deb to snap: install updates before building

Robert Liu
BugLink: https://launchpad.net/bugs/1808768

Install updates after deboostrap to avoid using out-of-date packages.

Signed-off-by: Robert Liu <[hidden email]>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index 2816139..f585d2b 100644
--- a/Makefile
+++ b/Makefile
@@ -70,6 +70,9 @@ install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinu
 all:
  debootstrap --variant=minbase $(RELEASE) chroot
  cp /etc/apt/sources.list chroot/etc/apt/sources.list
+ # install all updates
+ $(ENV) chroot chroot apt-get -y update
+ $(ENV) chroot chroot apt-get -y upgrade
  echo "deb http://ppa.launchpad.net/snappy-dev/image/ubuntu $(RELEASE) main" >> chroot/etc/apt/sources.list
  if [ "$(PROPOSED)" = "true" ]; then \
   echo "deb http://$(MIRROR) $(RELEASE)-proposed main restricted" >> chroot/etc/apt/sources.list; \
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [Xenial][deb-to-snap master][Patch] deb to snap: install updates before building

Kleber Souza
On 12/17/18 11:50 AM, Robert Liu wrote:

> BugLink: https://launchpad.net/bugs/1808768
>
> Install updates after deboostrap to avoid using out-of-date packages.
>
> Signed-off-by: Robert Liu <[hidden email]>
> ---
>  Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index 2816139..f585d2b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -70,6 +70,9 @@ install : KVERS = $(shell ls -1 chroot/boot/vmlinuz-*| tail -1 |sed 's/^.*vmlinu
>  all:
>   debootstrap --variant=minbase $(RELEASE) chroot
>   cp /etc/apt/sources.list chroot/etc/apt/sources.list
> + # install all updates
> + $(ENV) chroot chroot apt-get -y update
> + $(ENV) chroot chroot apt-get -y upgrade
>   echo "deb http://ppa.launchpad.net/snappy-dev/image/ubuntu $(RELEASE) main" >> chroot/etc/apt/sources.list
>   if [ "$(PROPOSED)" = "true" ]; then \
>    echo "deb http://$(MIRROR) $(RELEASE)-proposed main restricted" >> chroot/etc/apt/sources.list; \

This patch has been re-submitted, ack'ed and applied. So this one can be
ignored.

Thanks,
kleber


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team