[Zesty/Artful][PATCH] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Zesty/Artful][PATCH] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86

Wen-chien Jesse Sung
BugLink: https://launchpad.net/bugs/1733281

The ubuntu/xr-usb-serial is expected to be built for i386 and x86_64,
and in ubuntu/Makefile it says:

ifneq ($(filter $(ARCH), i386 x86_64),)
obj-y += xr-usb-serial/
endif

Since ARCH is x86 for both i386 and x86_64, this condition will never be
true thus the module will never get a chance to be built.

Signed-off-by: Wen-chien Jesse Sung <[hidden email]>
---
 ubuntu/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ubuntu/Makefile b/ubuntu/Makefile
index ef16668..2c1e696 100644
--- a/ubuntu/Makefile
+++ b/ubuntu/Makefile
@@ -25,7 +25,7 @@ obj-$(CONFIG_HIO)             += hio/
 ##
 ##
 ##
-ifneq ($(filter $(ARCH), i386 x86_64),)
+ifeq ($(ARCH),x86)
 obj-y += xr-usb-serial/
 endif
 ##
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Zesty/Artful][PATCH] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86

Po-Hsu Lin (Sam)
As per jesse's comment on IRC, we don't need this patch for Xenial since the module are different:

<jesse> PHLin: no, the patch applied to Xenial and Zesty/Artful to enable the module are different....

So
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Zesty/Artful][PATCH] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86

Seth Forshee
In reply to this post by Wen-chien Jesse Sung
On Mon, Nov 20, 2017 at 04:14:17PM +0800, Wen-chien Jesse Sung wrote:

> BugLink: https://launchpad.net/bugs/1733281
>
> The ubuntu/xr-usb-serial is expected to be built for i386 and x86_64,
> and in ubuntu/Makefile it says:
>
> ifneq ($(filter $(ARCH), i386 x86_64),)
> obj-y += xr-usb-serial/
> endif
>
> Since ARCH is x86 for both i386 and x86_64, this condition will never be
> true thus the module will never get a chance to be built.
>
> Signed-off-by: Wen-chien Jesse Sung <[hidden email]>

Acked-by: Seth Forshee <[hidden email]>

Also applied to bionic and unstable, please try to remember to include
these for patches like this in the future. Thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[A]: [Zesty/Artful][PATCH] UBUNTU: SAUCE: make sure ubuntu/xr-usb-serial builds for x86

Stefan Bader-2
In reply to this post by Wen-chien Jesse Sung
On 20.11.2017 09:14, Wen-chien Jesse Sung wrote:

> BugLink: https://launchpad.net/bugs/1733281
>
> The ubuntu/xr-usb-serial is expected to be built for i386 and x86_64,
> and in ubuntu/Makefile it says:
>
> ifneq ($(filter $(ARCH), i386 x86_64),)
> obj-y += xr-usb-serial/
> endif
>
> Since ARCH is x86 for both i386 and x86_64, this condition will never be
> true thus the module will never get a chance to be built.
>
> Signed-off-by: Wen-chien Jesse Sung <[hidden email]>
> ---
>  ubuntu/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index ef16668..2c1e696 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -25,7 +25,7 @@ obj-$(CONFIG_HIO)             += hio/
>  ##
>  ##
>  ##
> -ifneq ($(filter $(ARCH), i386 x86_64),)
> +ifeq ($(ARCH),x86)
>  obj-y += xr-usb-serial/
>  endif
>  ##
>
Applied to Artful/master-next-backlog, ignored for Zesty (EOL)


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment