[azure][PATCH] PCI: hv: Use device serial number as PCI domain

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[azure][PATCH] PCI: hv: Use device serial number as PCI domain

Marcelo Henrique Cerri
From: Haiyang Zhang <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1670544

Use the device serial number as the PCI domain.  The serial numbers start
with 1 and are unique within a VM.  So names, such as VF NIC names, that
include domain number as part of the name, can be shorter than that based
on part of bus UUID previously.  The new names will also stay same for VMs
created with copied VHD and same number of devices.

Signed-off-by: Haiyang Zhang <[hidden email]>
Signed-off-by: Stephen Hemminger <[hidden email]>
Signed-off-by: Bjorn Helgaas <[hidden email]>
Reviewed-by: K. Y. Srinivasan <[hidden email]>
(cherry picked from commit 4a9b0933bdfcd85da840284bf5a0eb17b654b9c2)
Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---

All the commits in 4.9 and 4.10 are already included since the azure kernel
is based on zesty. From the remaining commits, one was sauced for zesty and
this commit applies cleanly from upstream.


 drivers/pci/host/pci-hyperv.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index d096237f9591..a679b6acb438 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -1320,6 +1320,18 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
  get_pcichild(hpdev, hv_pcidev_ref_initial);
  get_pcichild(hpdev, hv_pcidev_ref_childlist);
  spin_lock_irqsave(&hbus->device_list_lock, flags);
+
+ /*
+ * When a device is being added to the bus, we set the PCI domain
+ * number to be the device serial number, which is non-zero and
+ * unique on the same VM.  The serial numbers start with 1, and
+ * increase by 1 for each device.  So device names including this
+ * can have shorter names than based on the bus instance UUID.
+ * Only the first device serial number is used for domain, so the
+ * domain number will not change after the first device is added.
+ */
+ if (list_empty(&hbus->children))
+ hbus->sysdata.domain = desc->ser;
  list_add_tail(&hpdev->list_entry, &hbus->children);
  spin_unlock_irqrestore(&hbus->device_list_lock, flags);
  return hpdev;
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [azure][PATCH] PCI: hv: Use device serial number as PCI domain

Tim Gardner-2
Reply | Threaded
Open this post in threaded view
|

APPLIED/cmnt: [azure][PATCH] PCI: hv: Use device serial number as PCI domain

Marcelo Henrique Cerri
In reply to this post by Marcelo Henrique Cerri
Brad acked via IRC.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team