Re: [b, c, d][PATCH v2] UBUNTU: [Packaging] buildinfo -- include origin package mark to modules files
On Wed, Dec 05, 2018 at 03:16:44PM -0200, Marcelo Henrique Cerri wrote:
> BugLink: http://bugs.launchpad.net/bugs/1806380 >
> Include a flag at the end of each line of the
> "debian.$branch/abi/*/$arch/$flavour.modules" file indicating the
> package that each module is currently shipped in.
> This will cause the build to fail when a module is silently moved from
> or to the linux-modules-extra package.
> Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
Doesn't module-check also need to be updated to avoid breaking use of
modules.ignore? Or is the expectation that we will start appending the
"extra" as needed when adding modules to that file?
I'm also curious whether you considered splitting them out into multiple
abi files, something like generic.modules and generic.extras.modules,
and if so why you settled on using a flag instead.
Should we extract the flag name from the package name rather than
hardcoding it like you've done here. This may be overthinking it, since
I don't know whether we would need to track abi for any additional
module packages nor what those packages would be named.