[bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Kees Cook-5
The bcm2835_wdt.ko module is required for Raspberry Pi systems to actually
reboot and shutdown. It should not get automatically blacklisted. See
https://github.com/raspberrypi/linux/issues/2523

Closes LP: #1766052

Signed-off-by: Kees Cook <[hidden email]>
---
v2: add missing pipe (sforshee)
---
 debian/rules.d/2-binary-arch.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 72e55fc6815c..f9d1d792019e 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -183,6 +183,7 @@ endif
  echo "# Autogenerated watchdog blacklist" \
  >>$(pkgdir)/lib/modprobe.d/blacklist_$(src_pkg_name)_$(abi_release)-$*.conf
  ls -1 $(pkgdir)/lib/modules/$(abi_release)-$*/kernel/drivers/watchdog/ | \
+ grep -v '^bcm2835_wdt$$' | \
  sed -e 's/^/blacklist /' -e 's/.ko$$//' | \
  sort -u \
  >>$(pkgdir)/lib/modprobe.d/blacklist_$(src_pkg_name)_$(abi_release)-$*.conf
--
2.7.4


--
Kees Cook
Pixel Security

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Seth Forshee
On Thu, Apr 26, 2018 at 08:51:14AM -0700, Kees Cook wrote:
> The bcm2835_wdt.ko module is required for Raspberry Pi systems to actually
> reboot and shutdown. It should not get automatically blacklisted. See
> https://github.com/raspberrypi/linux/issues/2523
>
> Closes LP: #1766052
>
> Signed-off-by: Kees Cook <[hidden email]>

Seems reasonable.

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Khaled Elmously
In reply to this post by Kees Cook-5
On 2018-04-26 08:51:14 , Kees Cook wrote:

> The bcm2835_wdt.ko module is required for Raspberry Pi systems to actually
> reboot and shutdown. It should not get automatically blacklisted. See
> https://github.com/raspberrypi/linux/issues/2523
>
> Closes LP: #1766052
>
> Signed-off-by: Kees Cook <[hidden email]>
> ---
> v2: add missing pipe (sforshee)
> ---
>  debian/rules.d/2-binary-arch.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 72e55fc6815c..f9d1d792019e 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -183,6 +183,7 @@ endif
>   echo "# Autogenerated watchdog blacklist" \
>   >>$(pkgdir)/lib/modprobe.d/blacklist_$(src_pkg_name)_$(abi_release)-$*.conf
>   ls -1 $(pkgdir)/lib/modules/$(abi_release)-$*/kernel/drivers/watchdog/ | \
> + grep -v '^bcm2835_wdt$$' | \
>   sed -e 's/^/blacklist /' -e 's/.ko$$//' | \
>   sort -u \
>   >>$(pkgdir)/lib/modprobe.d/blacklist_$(src_pkg_name)_$(abi_release)-$*.conf

Acked-by: Khalid Elmously <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Joseph Salisbury-3
In reply to this post by Seth Forshee
On 04/26/2018 11:58 AM, Seth Forshee wrote:

> On Thu, Apr 26, 2018 at 08:51:14AM -0700, Kees Cook wrote:
>> The bcm2835_wdt.ko module is required for Raspberry Pi systems to actually
>> reboot and shutdown. It should not get automatically blacklisted. See
>> https://github.com/raspberrypi/linux/issues/2523
>>
>> Closes LP: #1766052
>>
>> Signed-off-by: Kees Cook <[hidden email]>
> Seems reasonable.
>
> Acked-by: Seth Forshee <[hidden email]>
>
I see there are two acks for this patch.  Any chance it will be applied
soon?


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Kleber Souza
On 05/10/18 19:29, Joseph Salisbury wrote:

> On 04/26/2018 11:58 AM, Seth Forshee wrote:
>> On Thu, Apr 26, 2018 at 08:51:14AM -0700, Kees Cook wrote:
>>> The bcm2835_wdt.ko module is required for Raspberry Pi systems to actually
>>> reboot and shutdown. It should not get automatically blacklisted. See
>>> https://github.com/raspberrypi/linux/issues/2523
>>>
>>> Closes LP: #1766052
>>>
>>> Signed-off-by: Kees Cook <[hidden email]>
>> Seems reasonable.
>>
>> Acked-by: Seth Forshee <[hidden email]>
>>
> I see there are two acks for this patch.  Any chance it will be applied
> soon?

The deadline for getting patches applied for the next SRU cycle is this
Friday (May 18th), so this patch will be probably applied by the end of
the week.


Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/cmnt: [bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Kleber Souza
In reply to this post by Kees Cook-5
On 04/26/18 17:51, Kees Cook wrote:
> The bcm2835_wdt.ko module is required for Raspberry Pi systems to actually
> reboot and shutdown. It should not get automatically blacklisted. See
> https://github.com/raspberrypi/linux/issues/2523
>
> Closes LP: #1766052

The Launchpad bug link needs to be in the format:

BugLink: http://bugs.launchpad.net/bugs/<bug#>

I have fixed it while applying the patch.


>
> Signed-off-by: Kees Cook <[hidden email]>
> ---
> v2: add missing pipe (sforshee)
> ---
>  debian/rules.d/2-binary-arch.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 72e55fc6815c..f9d1d792019e 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -183,6 +183,7 @@ endif
>   echo "# Autogenerated watchdog blacklist" \
>   >>$(pkgdir)/lib/modprobe.d/blacklist_$(src_pkg_name)_$(abi_release)-$*.conf
>   ls -1 $(pkgdir)/lib/modules/$(abi_release)-$*/kernel/drivers/watchdog/ | \
> + grep -v '^bcm2835_wdt$$' | \
>   sed -e 's/^/blacklist /' -e 's/.ko$$//' | \
>   sort -u \
>   >>$(pkgdir)/lib/modprobe.d/blacklist_$(src_pkg_name)_$(abi_release)-$*.conf
>

The Launchpad bug was also nominated for Artful but the patch is tagged
against Bionic only, so I have applied it only to Bionic.

Applied to bionic/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[U]: [bionic][PATCH v2] UBUNTU: [Packaging] Fix missing watchdog for Raspberry Pi

Thadeu Lima de Souza Cascardo-3
In reply to this post by Kees Cook-5
Applied to unstable master branch.

Thanks.
Cascardo.

Applied-to: unstable/master

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team