[bionic:linux-azure-4.15, {focal, groovy}:linux-azure][PATCH 0/1] LP:#1908264 - Disable Atari partition support for cloud kernels

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[bionic:linux-azure-4.15, {focal, groovy}:linux-azure][PATCH 0/1] LP:#1908264 - Disable Atari partition support for cloud kernels

Marcelo Henrique Cerri
BugLink: https://bugs.launchpad.net/bugs/1908264

As bug description. Same change that we already accepted for
linux-aws.

---
Marcelo Henrique Cerri (1):
  UBUNTU: [Config] azure: Disable ATARI_PARTITION

 debian.azure-4.15/config/annotations          | 3 +++
 debian.azure-4.15/config/config.common.ubuntu | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

--
2.25.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[bionic:linux-azure-4.15][PATCH 1/1] UBUNTU: [Config] azure: Disable ATARI_PARTITION

Marcelo Henrique Cerri
BugLink: https://bugs.launchpad.net/bugs/1908264

Support for Atari partitions is not available in the Azure so disable
it for the same reasons we disable it in other cloud kernels.

Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 debian.azure-4.15/config/annotations          | 3 +++
 debian.azure-4.15/config/config.common.ubuntu | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/debian.azure-4.15/config/annotations b/debian.azure-4.15/config/annotations
index 91854a8fd282..cf9a019fc4ec 100644
--- a/debian.azure-4.15/config/annotations
+++ b/debian.azure-4.15/config/annotations
@@ -136,6 +136,9 @@ CONFIG_LOOPBACK_TARGET                             mark<ENFORCED> note<LP#179179
 CONFIG_BT_HS   policy<{'amd64': '-'}>
 CONFIG_BT_HS   mark<ENFORCED> note<https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00435.html>
 
+CONFIG_ATARI_PARTITION                             policy<{'amd64': 'n'}>
+CONFIG_ATARI_PARTITION                             mark<ENFORCED> note<LP:1908264>
+
 # From linux-azure initial packaging
 
 CONFIG_POWERCAP                                    policy<{'amd64': 'n'}>
diff --git a/debian.azure-4.15/config/config.common.ubuntu b/debian.azure-4.15/config/config.common.ubuntu
index 48693eb5ec48..e3c24bbfdecb 100644
--- a/debian.azure-4.15/config/config.common.ubuntu
+++ b/debian.azure-4.15/config/config.common.ubuntu
@@ -262,7 +262,7 @@ CONFIG_ASYNC_XOR=m
 # CONFIG_AT803X_PHY is not set
 CONFIG_ATA=y
 CONFIG_ATALK=m
-CONFIG_ATARI_PARTITION=y
+CONFIG_ATARI_PARTITION=n
 CONFIG_ATA_ACPI=y
 CONFIG_ATA_BMDMA=y
 CONFIG_ATA_GENERIC=y
--
2.25.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[focal:linux-azure][PATCH 1/1] UBUNTU: [Config] azure: Disable ATARI_PARTITION

Marcelo Henrique Cerri
In reply to this post by Marcelo Henrique Cerri
BugLink: https://bugs.launchpad.net/bugs/1908264

Support for Atari partitions is not available in the Azure so disable
it for the same reasons we disable it in other cloud kernels.

Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 debian.azure/config/annotations          | 3 +++
 debian.azure/config/config.common.ubuntu | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/debian.azure/config/annotations b/debian.azure/config/annotations
index 54e63b01179b..ddbff51a2935 100644
--- a/debian.azure/config/annotations
+++ b/debian.azure/config/annotations
@@ -109,6 +109,9 @@ CONFIG_USB_XHCI_PLATFORM                           mark<ENFORCED> note<LP:#18670
 CONFIG_CONTEXT_TRACKING_FORCE                      policy<{'amd64': 'n'}>
 CONFIG_CONTEXT_TRACKING_FORCE                      flag<REVIEW> note<Likely VIRT_CPU_ACCOUNTING_GEN should be disabled>
 
+CONFIG_ATARI_PARTITION                             policy<{'amd64': 'n'}>
+CONFIG_ATARI_PARTITION                             mark<ENFORCED> note<LP:1908264>
+
 # From linux-azure initial packaging
 
 CONFIG_POWERCAP                                    policy<{'amd64': 'n'}>
diff --git a/debian.azure/config/config.common.ubuntu b/debian.azure/config/config.common.ubuntu
index 6ee373d32c50..3d68e6fe3754 100644
--- a/debian.azure/config/config.common.ubuntu
+++ b/debian.azure/config/config.common.ubuntu
@@ -261,7 +261,7 @@ CONFIG_ASYNC_XOR=m
 # CONFIG_AT803X_PHY is not set
 CONFIG_ATA=y
 CONFIG_ATALK=m
-CONFIG_ATARI_PARTITION=y
+# CONFIG_ATARI_PARTITION is not set
 CONFIG_ATA_ACPI=y
 CONFIG_ATA_BMDMA=y
 CONFIG_ATA_GENERIC=y
--
2.25.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[groovy:linux-azure][PATCH 1/1] UBUNTU: [Config] azure: Disable ATARI_PARTITION

Marcelo Henrique Cerri
In reply to this post by Marcelo Henrique Cerri
BugLink: https://bugs.launchpad.net/bugs/1908264

Support for Atari partitions is not available in the Azure so disable
it for the same reasons we disable it in other cloud kernels.

Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 debian.azure/config/annotations          | 3 +++
 debian.azure/config/config.common.ubuntu | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/debian.azure/config/annotations b/debian.azure/config/annotations
index 9c9ed9366fb7..9ce018acaac3 100644
--- a/debian.azure/config/annotations
+++ b/debian.azure/config/annotations
@@ -109,6 +109,9 @@ CONFIG_USB_XHCI_PLATFORM                           mark<ENFORCED> note<LP:#18670
 CONFIG_CONTEXT_TRACKING_FORCE                      policy<{'amd64': 'n'}>
 CONFIG_CONTEXT_TRACKING_FORCE                      flag<REVIEW> note<Likely VIRT_CPU_ACCOUNTING_GEN should be disabled>
 
+CONFIG_ATARI_PARTITION                             policy<{'amd64': 'n'}>
+CONFIG_ATARI_PARTITION                             mark<ENFORCED> note<LP:1908264>
+
 # From linux-azure initial packaging
 
 CONFIG_POWERCAP                                    policy<{'amd64': 'n'}>
diff --git a/debian.azure/config/config.common.ubuntu b/debian.azure/config/config.common.ubuntu
index 4b41135c448b..7fa85909dfa0 100644
--- a/debian.azure/config/config.common.ubuntu
+++ b/debian.azure/config/config.common.ubuntu
@@ -269,7 +269,7 @@ CONFIG_AS_TPAUSE=y
 # CONFIG_AT803X_PHY is not set
 CONFIG_ATA=y
 CONFIG_ATALK=m
-CONFIG_ATARI_PARTITION=y
+# CONFIG_ATARI_PARTITION is not set
 CONFIG_ATA_ACPI=y
 CONFIG_ATA_BMDMA=y
 CONFIG_ATA_FORCE=y
--
2.25.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [bionic:linux-azure-4.15, {focal, groovy}:linux-azure][PATCH 0/1] LP:#1908264 - Disable Atari partition support for cloud kernels

Kamal Mostafa-2
In reply to this post by Marcelo Henrique Cerri

Acked-by: Kamal Mostafa <[hidden email]>

 -Kamal

On Thu, Jan 14, 2021 at 01:46:06PM -0300, Marcelo Henrique Cerri wrote:

> BugLink: https://bugs.launchpad.net/bugs/1908264
>
> As bug description. Same change that we already accepted for
> linux-aws.
>
> ---
> Marcelo Henrique Cerri (1):
>   UBUNTU: [Config] azure: Disable ATARI_PARTITION
>
>  debian.azure-4.15/config/annotations          | 3 +++
>  debian.azure-4.15/config/config.common.ubuntu | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 2.25.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [bionic:linux-azure-4.15][PATCH 1/1] UBUNTU: [Config] azure: Disable ATARI_PARTITION

Kamal Mostafa-2
In reply to this post by Marcelo Henrique Cerri
On Thu, Jan 14, 2021 at 01:46:07PM -0300, Marcelo Henrique Cerri wrote:

> --- a/debian.azure-4.15/config/config.common.ubuntu
> +++ b/debian.azure-4.15/config/config.common.ubuntu
> @@ -262,7 +262,7 @@ CONFIG_ASYNC_XOR=m
>  # CONFIG_AT803X_PHY is not set
>  CONFIG_ATA=y
>  CONFIG_ATALK=m
> -CONFIG_ATARI_PARTITION=y
> +CONFIG_ATARI_PARTITION=n
>  CONFIG_ATA_ACPI=y
>  CONFIG_ATA_BMDMA=y
>  CONFIG_ATA_GENERIC=y

How come this one is not the usual "# CONFIG_WHATEVER is not set" format?

 -Kamal

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [bionic:linux-azure-4.15][PATCH 1/1] UBUNTU: [Config] azure: Disable ATARI_PARTITION

Marcelo Henrique Cerri
On Thu, Jan 14, 2021 at 09:42:38AM -0800, Kamal Mostafa wrote:

> On Thu, Jan 14, 2021 at 01:46:07PM -0300, Marcelo Henrique Cerri wrote:
> > --- a/debian.azure-4.15/config/config.common.ubuntu
> > +++ b/debian.azure-4.15/config/config.common.ubuntu
> > @@ -262,7 +262,7 @@ CONFIG_ASYNC_XOR=m
> >  # CONFIG_AT803X_PHY is not set
> >  CONFIG_ATA=y
> >  CONFIG_ATALK=m
> > -CONFIG_ATARI_PARTITION=y
> > +CONFIG_ATARI_PARTITION=n
> >  CONFIG_ATA_ACPI=y
> >  CONFIG_ATA_BMDMA=y
> >  CONFIG_ATA_GENERIC=y
>
> How come this one is not the usual "# CONFIG_WHATEVER is not set" format?
Now that you mentioned it, that looks wrong to me.

I manually set it to "n" and then ran `fakeroot debian/rules
udpateconfigs`. It seems that in those cases it doesn't update the
config to the above format. If I remove the config line and then
respond with "n" when updateconfigs asks about it, then I get
the commented line.

I will update the patches because I think that will cause problems in
the future.

>
>  -Kamal

--
Regards,
Marcelo


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (673 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

NACK: [bionic:linux-azure-4.15,{focal,groovy}:linux-azure][PATCH 0/1] LP:#1908264 - Disable Atari partition support for cloud kernels

Marcelo Henrique Cerri
In reply to this post by Marcelo Henrique Cerri
Nacked.

I will send a v2 for the 3 kernels for clarity.

On Thu, Jan 14, 2021 at 01:46:06PM -0300, Marcelo Henrique Cerri wrote:

> BugLink: https://bugs.launchpad.net/bugs/1908264
>
> As bug description. Same change that we already accepted for
> linux-aws.
>
> ---
> Marcelo Henrique Cerri (1):
>   UBUNTU: [Config] azure: Disable ATARI_PARTITION
>
>  debian.azure-4.15/config/annotations          | 3 +++
>  debian.azure-4.15/config/config.common.ubuntu | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> --
> 2.25.1
>
--
Regards,
Marcelo


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (673 bytes) Download Attachment