[bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1766823

== Justification ==
In the Xenial / Bionic KVM kernel, the CONFIG_ZRAM was not set, it's
impossible for users to use zram module on it. And the ubuntu_zram_smoke_test
regression test is failing due to the missing module.

== Test ==
Before enabling CONFIG_ZRAM and the related configs, the zram module cannot be
found. After that, the zram module can be inserted and pass the
ubuntu_zram_smoke_test.

Test kernels could be found here:
http://people.canonical.com/~phlin/kernel/lp-1766823-zram/

== Fix ==
UBUNTU: [Config]: enable CONFIG_ZRAM

== Regression Potential ==
Minimal.
No code changes, just a config changes without disabling any other configs.

Po-Hsu Lin (1):
  UBUNTU: [Config]: enable CONFIG_ZRAM

 debian.kvm/config/config.common.ubuntu | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[xenial/linux-kvm][SRU][PATCH 1/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1766823

zram is an useful module for memory constrained systems. However it's
imposibble for KVM kernel user to use it.

Enable the CONFIG_ZRAM and other related configs like in generic kernel to make
it available for KVM kernels, so that it can pass the ubuntu_zram_smoke_test
in the SRU regression test suite.

Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 20e51ff2..d2093c1 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1709,6 +1709,7 @@ CONFIG_PERF_EVENTS=y
 CONFIG_PERF_EVENTS_INTEL_UNCORE=y
 # CONFIG_PERSISTENT_KEYRINGS is not set
 CONFIG_PGTABLE_LEVELS=4
+CONFIG_PGTABLE_MAPPING=y
 # CONFIG_PHANTOM is not set
 # CONFIG_PHONET is not set
 # CONFIG_PHYLIB is not set
@@ -2291,4 +2292,8 @@ CONFIG_ZLIB_INFLATE=y
 CONFIG_ZONE_DMA32=y
 CONFIG_ZONE_DMA_FLAG=0
 # CONFIG_ZPOOL is not set
-# CONFIG_ZSMALLOC is not set
+CONFIG_ZRAM=m
+CONFIG_ZRAM_LZ4_COMPRESS=y
+CONFIG_ZRAM_WRITEBACK=y
+CONFIG_ZSMALLOC=y
+# CONFIG_ZSMALLOC_STAT is not set
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[bionic/linux-kvm][SRU][PATCH 1/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Po-Hsu Lin (Sam)
In reply to this post by Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1766823

zram is an useful module for memory constrained systems. However it's
imposibble for KVM kernel user to use it.

Enable the CONFIG_ZRAM and other related configs like in generic kernel to make
it available for KVM kernels, so that it can pass the ubuntu_zram_smoke_test
in the SRU regression test suite.

Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 9b21e28..750ee9d9 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1844,6 +1844,7 @@ CONFIG_PERF_EVENTS_INTEL_RAPL=y
 CONFIG_PERF_EVENTS_INTEL_UNCORE=y
 # CONFIG_PERSISTENT_KEYRINGS is not set
 CONFIG_PGTABLE_LEVELS=4
+CONFIG_PGTABLE_MAPPING=y
 # CONFIG_PHANTOM is not set
 # CONFIG_PHONET is not set
 # CONFIG_PHYLIB is not set
@@ -2504,6 +2505,9 @@ CONFIG_ZLIB_INFLATE=y
 # CONFIG_ZONE_DMA is not set
 CONFIG_ZONE_DMA32=y
 # CONFIG_ZPOOL is not set
-# CONFIG_ZSMALLOC is not set
+CONFIG_ZRAM=m
+CONFIG_ZRAM_WRITEBACK=y
+CONFIG_ZSMALLOC=y
+# CONFIG_ZSMALLOC_STAT is not set
 CONFIG_ZSTD_COMPRESS=m
 CONFIG_ZSTD_DECOMPRESS=m
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Kamal Mostafa-2
In reply to this post by Po-Hsu Lin (Sam)

Acked-by: Kamal Mostafa <[hidden email]>

On Fri, Aug 03, 2018 at 02:51:05PM +0800, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766823
>
> == Justification ==
> In the Xenial / Bionic KVM kernel, the CONFIG_ZRAM was not set, it's
> impossible for users to use zram module on it. And the ubuntu_zram_smoke_test
> regression test is failing due to the missing module.
>
> == Test ==
> Before enabling CONFIG_ZRAM and the related configs, the zram module cannot be
> found. After that, the zram module can be inserted and pass the
> ubuntu_zram_smoke_test.
>
> Test kernels could be found here:
> http://people.canonical.com/~phlin/kernel/lp-1766823-zram/
>
> == Fix ==
> UBUNTU: [Config]: enable CONFIG_ZRAM
>
> == Regression Potential ==
> Minimal.
> No code changes, just a config changes without disabling any other configs.
>
> Po-Hsu Lin (1):
>   UBUNTU: [Config]: enable CONFIG_ZRAM
>
>  debian.kvm/config/config.common.ubuntu | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [xenial/linux-kvm][SRU][PATCH 1/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Kleber Souza
In reply to this post by Po-Hsu Lin (Sam)
On 08/03/18 08:51, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766823
>
> zram is an useful module for memory constrained systems. However it's
> imposibble for KVM kernel user to use it.
>
> Enable the CONFIG_ZRAM and other related configs like in generic kernel to make
> it available for KVM kernels, so that it can pass the ubuntu_zram_smoke_test
> in the SRU regression test suite.
>
> Signed-off-by: Po-Hsu Lin <[hidden email]>
> ---
>  debian.kvm/config/config.common.ubuntu | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> index 20e51ff2..d2093c1 100644
> --- a/debian.kvm/config/config.common.ubuntu
> +++ b/debian.kvm/config/config.common.ubuntu
> @@ -1709,6 +1709,7 @@ CONFIG_PERF_EVENTS=y
>  CONFIG_PERF_EVENTS_INTEL_UNCORE=y
>  # CONFIG_PERSISTENT_KEYRINGS is not set
>  CONFIG_PGTABLE_LEVELS=4
> +CONFIG_PGTABLE_MAPPING=y
>  # CONFIG_PHANTOM is not set
>  # CONFIG_PHONET is not set
>  # CONFIG_PHYLIB is not set
> @@ -2291,4 +2292,8 @@ CONFIG_ZLIB_INFLATE=y
>  CONFIG_ZONE_DMA32=y
>  CONFIG_ZONE_DMA_FLAG=0
>  # CONFIG_ZPOOL is not set
> -# CONFIG_ZSMALLOC is not set
> +CONFIG_ZRAM=m
> +CONFIG_ZRAM_LZ4_COMPRESS=y
> +CONFIG_ZRAM_WRITEBACK=y

CONFIG_ZRAM_WRITEBACK hasn't been implemented yet in Xenial's 4.4 kernel.

> +CONFIG_ZSMALLOC=y
> +# CONFIG_ZSMALLOC_STAT is not set
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [bionic/linux-kvm][SRU][PATCH 1/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Kleber Souza
In reply to this post by Po-Hsu Lin (Sam)
On 08/03/18 08:51, Po-Hsu Lin wrote:

> BugLink: https://bugs.launchpad.net/bugs/1766823
>
> zram is an useful module for memory constrained systems. However it's
> imposibble for KVM kernel user to use it.
>
> Enable the CONFIG_ZRAM and other related configs like in generic kernel to make
> it available for KVM kernels, so that it can pass the ubuntu_zram_smoke_test
> in the SRU regression test suite.
>
> Signed-off-by: Po-Hsu Lin <[hidden email]>

The config options seem to be in sync with bionic's master kernel.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  debian.kvm/config/config.common.ubuntu | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> index 9b21e28..750ee9d9 100644
> --- a/debian.kvm/config/config.common.ubuntu
> +++ b/debian.kvm/config/config.common.ubuntu
> @@ -1844,6 +1844,7 @@ CONFIG_PERF_EVENTS_INTEL_RAPL=y
>  CONFIG_PERF_EVENTS_INTEL_UNCORE=y
>  # CONFIG_PERSISTENT_KEYRINGS is not set
>  CONFIG_PGTABLE_LEVELS=4
> +CONFIG_PGTABLE_MAPPING=y
>  # CONFIG_PHANTOM is not set
>  # CONFIG_PHONET is not set
>  # CONFIG_PHYLIB is not set
> @@ -2504,6 +2505,9 @@ CONFIG_ZLIB_INFLATE=y
>  # CONFIG_ZONE_DMA is not set
>  CONFIG_ZONE_DMA32=y
>  # CONFIG_ZPOOL is not set
> -# CONFIG_ZSMALLOC is not set
> +CONFIG_ZRAM=m
> +CONFIG_ZRAM_WRITEBACK=y
> +CONFIG_ZSMALLOC=y
> +# CONFIG_ZSMALLOC_STAT is not set
>  CONFIG_ZSTD_COMPRESS=m
>  CONFIG_ZSTD_DECOMPRESS=m
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [xenial/linux-kvm][SRU][PATCH 1/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Po-Hsu Lin (Sam)
In reply to this post by Kleber Souza
Thanks, I will send V2 for this.

BTW, how did you find this issue, I tried to build the kernel before
sending this patch but the compiler didn't complain about his.

On Wed, Aug 15, 2018 at 12:01 AM, Kleber Souza
<[hidden email]> wrote:

> On 08/03/18 08:51, Po-Hsu Lin wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1766823
>>
>> zram is an useful module for memory constrained systems. However it's
>> imposibble for KVM kernel user to use it.
>>
>> Enable the CONFIG_ZRAM and other related configs like in generic kernel to make
>> it available for KVM kernels, so that it can pass the ubuntu_zram_smoke_test
>> in the SRU regression test suite.
>>
>> Signed-off-by: Po-Hsu Lin <[hidden email]>
>> ---
>>  debian.kvm/config/config.common.ubuntu | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
>> index 20e51ff2..d2093c1 100644
>> --- a/debian.kvm/config/config.common.ubuntu
>> +++ b/debian.kvm/config/config.common.ubuntu
>> @@ -1709,6 +1709,7 @@ CONFIG_PERF_EVENTS=y
>>  CONFIG_PERF_EVENTS_INTEL_UNCORE=y
>>  # CONFIG_PERSISTENT_KEYRINGS is not set
>>  CONFIG_PGTABLE_LEVELS=4
>> +CONFIG_PGTABLE_MAPPING=y
>>  # CONFIG_PHANTOM is not set
>>  # CONFIG_PHONET is not set
>>  # CONFIG_PHYLIB is not set
>> @@ -2291,4 +2292,8 @@ CONFIG_ZLIB_INFLATE=y
>>  CONFIG_ZONE_DMA32=y
>>  CONFIG_ZONE_DMA_FLAG=0
>>  # CONFIG_ZPOOL is not set
>> -# CONFIG_ZSMALLOC is not set
>> +CONFIG_ZRAM=m
>> +CONFIG_ZRAM_LZ4_COMPRESS=y
>> +CONFIG_ZRAM_WRITEBACK=y
>
> CONFIG_ZRAM_WRITEBACK hasn't been implemented yet in Xenial's 4.4 kernel.
>
>> +CONFIG_ZSMALLOC=y
>> +# CONFIG_ZSMALLOC_STAT is not set
>>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NAK: [xenial/linux-kvm][SRU][PATCH 1/1] UBUNTU: [Config]: enable CONFIG_ZRAM

Kleber Souza
Hi Sam,

On 08/15/18 09:23, Po-Hsu Lin wrote:
> Thanks, I will send V2 for this.
>
> BTW, how did you find this issue, I tried to build the kernel before
> sending this patch but the compiler didn't complain about his.

I ran a grep in the debian* directories (and also on the source code
itself to double check) looking for the config options, not finding it I
checked the mainline tree for the introducing commit.


Thanks,
Kleber

>
> On Wed, Aug 15, 2018 at 12:01 AM, Kleber Souza
> <[hidden email]> wrote:
>> On 08/03/18 08:51, Po-Hsu Lin wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1766823
>>>
>>> zram is an useful module for memory constrained systems. However it's
>>> imposibble for KVM kernel user to use it.
>>>
>>> Enable the CONFIG_ZRAM and other related configs like in generic kernel to make
>>> it available for KVM kernels, so that it can pass the ubuntu_zram_smoke_test
>>> in the SRU regression test suite.
>>>
>>> Signed-off-by: Po-Hsu Lin <[hidden email]>
>>> ---
>>>  debian.kvm/config/config.common.ubuntu | 7 ++++++-
>>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
>>> index 20e51ff2..d2093c1 100644
>>> --- a/debian.kvm/config/config.common.ubuntu
>>> +++ b/debian.kvm/config/config.common.ubuntu
>>> @@ -1709,6 +1709,7 @@ CONFIG_PERF_EVENTS=y
>>>  CONFIG_PERF_EVENTS_INTEL_UNCORE=y
>>>  # CONFIG_PERSISTENT_KEYRINGS is not set
>>>  CONFIG_PGTABLE_LEVELS=4
>>> +CONFIG_PGTABLE_MAPPING=y
>>>  # CONFIG_PHANTOM is not set
>>>  # CONFIG_PHONET is not set
>>>  # CONFIG_PHYLIB is not set
>>> @@ -2291,4 +2292,8 @@ CONFIG_ZLIB_INFLATE=y
>>>  CONFIG_ZONE_DMA32=y
>>>  CONFIG_ZONE_DMA_FLAG=0
>>>  # CONFIG_ZPOOL is not set
>>> -# CONFIG_ZSMALLOC is not set
>>> +CONFIG_ZRAM=m
>>> +CONFIG_ZRAM_LZ4_COMPRESS=y
>>> +CONFIG_ZRAM_WRITEBACK=y
>>
>> CONFIG_ZRAM_WRITEBACK hasn't been implemented yet in Xenial's 4.4 kernel.
>>
>>> +CONFIG_ZSMALLOC=y
>>> +# CONFIG_ZSMALLOC_STAT is not set
>>>
>>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team