[bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1782723

== Justification ==
In the Xenial 4.4 and Bionic 4.15 KVM kernel, the CONFIG_DNOTIFY was not set,
which is causing failures in the stress-ng dnotify test.

== Fix ==
UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

== Test ==
The dnotify test in stress-ng will pass with this patch applied.
Test kernels could be found here:
http://people.canonical.com/~phlin/kernel/lp-1782723-dnotify/

== Regression Potential ==
Minimal.
No code changes, just a config change.


Po-Hsu Lin (1):
  UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

 debian.kvm/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[xenial/linux-kvm][SRU][PATCH 1/1] UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1782723

Adding CONFIG_DNOTIFY=y to common config. It's better to enable this config in
KVM kenrels not only because it is required for the dnotify test in stress-ng,
the config description also suggest that some applications may still rely on it.

Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 2356d44..eeb6fe5 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -579,7 +579,7 @@ CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK=y
 # CONFIG_DM_UEVENT is not set
 # CONFIG_DM_VERITY is not set
 # CONFIG_DM_ZERO is not set
-# CONFIG_DNOTIFY is not set
+CONFIG_DNOTIFY=y
 CONFIG_DNS_RESOLVER=m
 # CONFIG_DOUBLEFAULT is not set
 CONFIG_DQL=y
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[bionic/linux-kvm][SRU][PATCH 1/1] UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

Po-Hsu Lin (Sam)
In reply to this post by Po-Hsu Lin (Sam)
BugLink: https://bugs.launchpad.net/bugs/1782723

Adding CONFIG_DNOTIFY=y to common config. It's better to enable this config in
KVM kenrels not only because it is required for the dnotify test in stress-ng,
the config description also suggest that some applications may still rely on it.

Signed-off-by: Po-Hsu Lin <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index e789e02..b832878 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -641,7 +641,7 @@ CONFIG_DMI_SCAN_MACHINE_NON_EFI_FALLBACK=y
 # CONFIG_DM_UEVENT is not set
 # CONFIG_DM_VERITY is not set
 # CONFIG_DM_ZERO is not set
-# CONFIG_DNOTIFY is not set
+CONFIG_DNOTIFY=y
 CONFIG_DNS_RESOLVER=m
 # CONFIG_DOUBLEFAULT is not set
 # CONFIG_DPTF_POWER is not set
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

Kamal Mostafa-2
In reply to this post by Po-Hsu Lin (Sam)
On Thu, Aug 16, 2018 at 10:56:20AM +0800, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1782723
>
> == Justification ==
> In the Xenial 4.4 and Bionic 4.15 KVM kernel, the CONFIG_DNOTIFY was not set,
> which is causing failures in the stress-ng dnotify test.

Hi Sam-

Since dnotify has been obsolete for many years now, we would prefer not
to enable it in linux-kvm (if its only for the purpose of stress-ng
testing).

Instead, could you fix up the autotest script to skip that test case if
CONFIG_DNOTIFY isn't enabled (or ignore that particular failure)?

 -Kamal

>
> == Fix ==
> UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY
>
> == Test ==
> The dnotify test in stress-ng will pass with this patch applied.
> Test kernels could be found here:
> http://people.canonical.com/~phlin/kernel/lp-1782723-dnotify/
>
> == Regression Potential ==
> Minimal.
> No code changes, just a config change.
>
>
> Po-Hsu Lin (1):
>   UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY
>
>  debian.kvm/config/config.common.ubuntu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [bionic/linux-kvm][xenial/linux-kvm][SRU][PATCH 0/1] UBUNTU: kvm: [Config] enable CONFIG_DNOTIFY

Po-Hsu Lin (Sam)
In reply to this post by Po-Hsu Lin (Sam)
NACK this as per Kamal's comment.
We will fix this in the test case.
Thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team