[kteam-tools][PATCH 0/2] fixes for shankbot crash with -azure

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[kteam-tools][PATCH 0/2] fixes for shankbot crash with -azure

Kleber Souza
Shankbot is crashing because of the -azure kernel. It's happening basically
because the -azure kernel is a backport from zesty to xenial, but the package
version doesn't have the series version as the other backports (e.g. '~17.10').
That causes shankbot to think that the -azure kernel is for zesty, but it
doesn't find it under zesty on the kernel-series-info.yaml file.

So it explodes later down on:

Traceback (most recent call last):
  File "./stable/swm", line 79, in <module>
    retval = WorkflowManager(args).manage()
  File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 105, in manage
    s.crank(bugid)
  File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 141, in crank
    modified = s.process_bug_tasks(bug)
  File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 187, in process_bug_tasks
    if cls.jumper[task.status]() and not s.args.dryrun:
  File "/home/kleber/devel/git/kteam-tools/stable/wfl/wft/prepare_package.py", line 67, in _common
    if s.bug.uploaded(pkg):
  File "/home/kleber/devel/git/kteam-tools/stable/wfl/bug.py", line 433, in uploaded
    for pocket in bi[pkg]:
KeyError: 'meta'

The first patch updates the current kernel version for artful on the yaml file,
this is also needed because Ubuntu.series_name() can also return 'artful'
sometimes.

Second patch is to try to handle the -azure case as best as possible,
it should work even if it gets backported for another series in the
future.


Kleber Sacilotto de Souza (2):
  kernel-series-info.yaml: update artful kernel version
  ktl/ubuntu.py: fix series lookup for -azure kernels

 ktl/kernel-series-info.yaml |  2 +-
 ktl/ubuntu.py               | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

--
2.11.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[kteam-tools][PATCH 1/2] kernel-series-info.yaml: update artful kernel version

Kleber Souza
Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
---
 ktl/kernel-series-info.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ktl/kernel-series-info.yaml b/ktl/kernel-series-info.yaml
index 192d2dea..bb7994f4 100644
--- a/ktl/kernel-series-info.yaml
+++ b/ktl/kernel-series-info.yaml
@@ -133,7 +133,7 @@
         derivative-packages:
             linux: []
         development: true
-        kernel: 4.10.0
+        kernel: 4.11.0
         name: artful
         packages:
         - linux
--
2.11.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[kteam-tools][PATCH 2/2] ktl/ubuntu.py: fix series lookup for -azure kernels

Kleber Souza
In reply to this post by Kleber Souza
Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
---
 ktl/ubuntu.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/ktl/ubuntu.py b/ktl/ubuntu.py
index 22276884..36845346 100644
--- a/ktl/ubuntu.py
+++ b/ktl/ubuntu.py
@@ -220,6 +220,18 @@ class Ubuntu:
             for entry in self.db.values():
                 if version.startswith(entry['kernel']):
                     retval = entry['name']
+                    series_version = entry['series_version']
+
+            # linux-azure is a backport that doesn't contain the 'upstream'
+            # series number on the package name, so we need to look for it
+            # first and then look for the target series.
+            if package.startswith('linux-azure'):
+                for entry in self.db.values():
+                    if 'backport-packages' in entry.keys() and \
+                            package in entry['backport-packages'] and \
+                            entry['backport-packages'][package][0] == 'linux' and \
+                            entry['backport-packages'][package][1] == series_version:
+                        retval = entry['name']
 
         return retval
 
--
2.11.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [kteam-tools][PATCH 0/2] fixes for shankbot crash with -azure

Joshua R. Poulson
In reply to this post by Kleber Souza
Since the Azure kernel should be applicable to all series, should we
do the right thing with version numbers now before it gets used by the
public?

Thanks, --jrp

On Thu, May 18, 2017 at 8:13 AM, Kleber Sacilotto de Souza
<[hidden email]> wrote:

> Shankbot is crashing because of the -azure kernel. It's happening basically
> because the -azure kernel is a backport from zesty to xenial, but the package
> version doesn't have the series version as the other backports (e.g. '~17.10').
> That causes shankbot to think that the -azure kernel is for zesty, but it
> doesn't find it under zesty on the kernel-series-info.yaml file.
>
> So it explodes later down on:
>
> Traceback (most recent call last):
>   File "./stable/swm", line 79, in <module>
>     retval = WorkflowManager(args).manage()
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 105, in manage
>     s.crank(bugid)
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 141, in crank
>     modified = s.process_bug_tasks(bug)
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 187, in process_bug_tasks
>     if cls.jumper[task.status]() and not s.args.dryrun:
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/wft/prepare_package.py", line 67, in _common
>     if s.bug.uploaded(pkg):
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/bug.py", line 433, in uploaded
>     for pocket in bi[pkg]:
> KeyError: 'meta'
>
> The first patch updates the current kernel version for artful on the yaml file,
> this is also needed because Ubuntu.series_name() can also return 'artful'
> sometimes.
>
> Second patch is to try to handle the -azure case as best as possible,
> it should work even if it gets backported for another series in the
> future.
>
>
> Kleber Sacilotto de Souza (2):
>   kernel-series-info.yaml: update artful kernel version
>   ktl/ubuntu.py: fix series lookup for -azure kernels
>
>  ktl/kernel-series-info.yaml |  2 +-
>  ktl/ubuntu.py               | 12 ++++++++++++
>  2 files changed, 13 insertions(+), 1 deletion(-)
>
> --
> 2.11.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Applied/modified: [kteam-tools][PATCH 0/2] fixes for shankbot crash with -azure

brad.figg
In reply to this post by Kleber Souza
On Thu, May 18, 2017 at 05:13:22PM +0200, Kleber Sacilotto de Souza wrote:

> Shankbot is crashing because of the -azure kernel. It's happening basically
> because the -azure kernel is a backport from zesty to xenial, but the package
> version doesn't have the series version as the other backports (e.g. '~17.10').
> That causes shankbot to think that the -azure kernel is for zesty, but it
> doesn't find it under zesty on the kernel-series-info.yaml file.
>
> So it explodes later down on:
>
> Traceback (most recent call last):
>   File "./stable/swm", line 79, in <module>
>     retval = WorkflowManager(args).manage()
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 105, in manage
>     s.crank(bugid)
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 141, in crank
>     modified = s.process_bug_tasks(bug)
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/manager.py", line 187, in process_bug_tasks
>     if cls.jumper[task.status]() and not s.args.dryrun:
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/wft/prepare_package.py", line 67, in _common
>     if s.bug.uploaded(pkg):
>   File "/home/kleber/devel/git/kteam-tools/stable/wfl/bug.py", line 433, in uploaded
>     for pocket in bi[pkg]:
> KeyError: 'meta'
>
> The first patch updates the current kernel version for artful on the yaml file,
> this is also needed because Ubuntu.series_name() can also return 'artful'
> sometimes.
>
> Second patch is to try to handle the -azure case as best as possible,
> it should work even if it gets backported for another series in the
> future.
>
>
> Kleber Sacilotto de Souza (2):
>   kernel-series-info.yaml: update artful kernel version
>   ktl/ubuntu.py: fix series lookup for -azure kernels
>
>  ktl/kernel-series-info.yaml |  2 +-
>  ktl/ubuntu.py               | 12 ++++++++++++
>  2 files changed, 13 insertions(+), 1 deletion(-)
>
> --
> 2.11.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

I made some stylistic changes to the second patch.

Brad
--
Brad Figg [hidden email] http://www.canonical.com

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team