[kteam-tools][PATCH] create-release-tracker: adds prefix for cycle tag

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[kteam-tools][PATCH] create-release-tracker: adds prefix for cycle tag

Kleber Souza
Adds the 'kernel-sru-cycle-' prefix to the cycle tag parameter
so it behaves the same as 'start-sru-cycle'.

Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
---
 stable/create-release-tracker | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/stable/create-release-tracker b/stable/create-release-tracker
index cb1abefd..abc97b5f 100755
--- a/stable/create-release-tracker
+++ b/stable/create-release-tracker
@@ -72,7 +72,7 @@ class CreateTrackingBug():
                           private=self.args.private)
 
             if self.args.cycle is not None:
-                bug.tags.append(self.args.cycle)
+                bug.tags.append('kernel-sru-cycle-' + self.args.cycle)
 
             # -------------------------------------------------------------------------------------
             # C H A N G E L O G   W O R K
@@ -122,7 +122,7 @@ if __name__ == '__main__':
     parser.add_argument('--private', action='store_true', default=False, help='The bug will be private and not everyone will have access.')
     parser.add_argument('--staging', action='store_true', default=False, help='Use the staging LP server to create the bug. This is just for testing and will go away when the staging database is reset.')
     parser.add_argument('--master_bug', default=None, help='If you are running this from a derivative or backport branch, you should use this option to specify the number of the tracking bug for the master branch release where this was rebased on.')
-    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created.')
+    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created (e.g. \'2017.04.04-1\').')
 
     args = parser.parse_args()
 
--
2.11.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [kteam-tools][PATCH] create-release-tracker: adds prefix for cycle tag

Thadeu Lima de Souza Cascardo-3
On Thu, May 18, 2017 at 05:26:13PM +0200, Kleber Sacilotto de Souza wrote:

> Adds the 'kernel-sru-cycle-' prefix to the cycle tag parameter
> so it behaves the same as 'start-sru-cycle'.
>
> Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
> ---
>  stable/create-release-tracker | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/stable/create-release-tracker b/stable/create-release-tracker
> index cb1abefd..abc97b5f 100755
> --- a/stable/create-release-tracker
> +++ b/stable/create-release-tracker
> @@ -72,7 +72,7 @@ class CreateTrackingBug():
>                            private=self.args.private)
>  
>              if self.args.cycle is not None:
> -                bug.tags.append(self.args.cycle)
> +                bug.tags.append('kernel-sru-cycle-' + self.args.cycle)
>  
>              # -------------------------------------------------------------------------------------
>              # C H A N G E L O G   W O R K
> @@ -122,7 +122,7 @@ if __name__ == '__main__':
>      parser.add_argument('--private', action='store_true', default=False, help='The bug will be private and not everyone will have access.')
>      parser.add_argument('--staging', action='store_true', default=False, help='Use the staging LP server to create the bug. This is just for testing and will go away when the staging database is reset.')
>      parser.add_argument('--master_bug', default=None, help='If you are running this from a derivative or backport branch, you should use this option to specify the number of the tracking bug for the master branch release where this was rebased on.')
> -    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created.')
> +    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created (e.g. \'2017.04.04-1\').')
>  
>      args = parser.parse_args()
>  
> --
> 2.11.0

+1 for the help option, thanks!

Acked-by: Thadeu Lima de Souza Cascardo <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [kteam-tools][PATCH] create-release-tracker: adds prefix for cycle tag

Colin Ian King-2
In reply to this post by Kleber Souza
On 18/05/17 16:26, Kleber Sacilotto de Souza wrote:

> Adds the 'kernel-sru-cycle-' prefix to the cycle tag parameter
> so it behaves the same as 'start-sru-cycle'.
>
> Signed-off-by: Kleber Sacilotto de Souza <[hidden email]>
> ---
>  stable/create-release-tracker | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/stable/create-release-tracker b/stable/create-release-tracker
> index cb1abefd..abc97b5f 100755
> --- a/stable/create-release-tracker
> +++ b/stable/create-release-tracker
> @@ -72,7 +72,7 @@ class CreateTrackingBug():
>                            private=self.args.private)
>  
>              if self.args.cycle is not None:
> -                bug.tags.append(self.args.cycle)
> +                bug.tags.append('kernel-sru-cycle-' + self.args.cycle)
>  
>              # -------------------------------------------------------------------------------------
>              # C H A N G E L O G   W O R K
> @@ -122,7 +122,7 @@ if __name__ == '__main__':
>      parser.add_argument('--private', action='store_true', default=False, help='The bug will be private and not everyone will have access.')
>      parser.add_argument('--staging', action='store_true', default=False, help='Use the staging LP server to create the bug. This is just for testing and will go away when the staging database is reset.')
>      parser.add_argument('--master_bug', default=None, help='If you are running this from a derivative or backport branch, you should use this option to specify the number of the tracking bug for the master branch release where this was rebased on.')
> -    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created.')
> +    parser.add_argument('--cycle', default=None, help='The sru cycle tag to be applied to the bug that is created (e.g. \'2017.04.04-1\').')
>  
>      args = parser.parse_args()
>  
>
Looks fine to me

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [kteam-tools][PATCH] create-release-tracker: adds prefix for cycle tag

Kleber Souza
In reply to this post by Kleber Souza