Quantcast

[kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Thadeu Lima de Souza Cascardo-3
Whenever different people update a kernel ABI, it's possible a different locale
is used, and ABI is changed, though nothing has really changed. This causes
some spurios ABI changes that make it more difficult to review differentes
between releases.

Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
---
 maintscripts/maint-getabis | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
index f375cc1..2defb70 100755
--- a/maintscripts/maint-getabis
+++ b/maintscripts/maint-getabis
@@ -213,7 +213,8 @@ def DownloadPackage(pkgname, srcpkgname):
 # remove the package on success.
 #------------------------------------------------------------------------------
 def ExtractPackage(pkg, tmpdir, abiversion, flavour):
- cmd  = "tmpdir=" + tmpdir + "\n"
+ cmd  = "export LC_ALL=C.UTF-8\n"
+ cmd += "tmpdir=" + tmpdir + "\n"
  cmd += "pkg=" + pkg + "\n"
  cmd += "abiver=" + abiversion + "\n"
  cmd += "flavour=" + flavour + "\n"
--
2.9.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Tim Gardner-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Andy Whitcroft-3
In reply to this post by Thadeu Lima de Souza Cascardo-3
On Thu, Feb 09, 2017 at 12:24:47PM -0200, Thadeu Lima de Souza Cascardo wrote:

> Whenever different people update a kernel ABI, it's possible a different locale
> is used, and ABI is changed, though nothing has really changed. This causes
> some spurios ABI changes that make it more difficult to review differentes
> between releases.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
> ---
>  maintscripts/maint-getabis | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
> index f375cc1..2defb70 100755
> --- a/maintscripts/maint-getabis
> +++ b/maintscripts/maint-getabis
> @@ -213,7 +213,8 @@ def DownloadPackage(pkgname, srcpkgname):
>  # remove the package on success.
>  #------------------------------------------------------------------------------
>  def ExtractPackage(pkg, tmpdir, abiversion, flavour):
> - cmd  = "tmpdir=" + tmpdir + "\n"
> + cmd  = "export LC_ALL=C.UTF-8\n"
> + cmd += "tmpdir=" + tmpdir + "\n"
>   cmd += "pkg=" + pkg + "\n"
>   cmd += "abiver=" + abiversion + "\n"
>   cmd += "flavour=" + flavour + "\n"

If we need this here, do we not want this in "getabis" in the trees as
well and for the same reason.

-apw

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Thadeu Lima de Souza Cascardo-3
On Sat, Feb 11, 2017 at 04:15:31PM +0000, Andy Whitcroft wrote:

> On Thu, Feb 09, 2017 at 12:24:47PM -0200, Thadeu Lima de Souza Cascardo wrote:
> > Whenever different people update a kernel ABI, it's possible a different locale
> > is used, and ABI is changed, though nothing has really changed. This causes
> > some spurios ABI changes that make it more difficult to review differentes
> > between releases.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <[hidden email]>
> > ---
> >  maintscripts/maint-getabis | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/maintscripts/maint-getabis b/maintscripts/maint-getabis
> > index f375cc1..2defb70 100755
> > --- a/maintscripts/maint-getabis
> > +++ b/maintscripts/maint-getabis
> > @@ -213,7 +213,8 @@ def DownloadPackage(pkgname, srcpkgname):
> >  # remove the package on success.
> >  #------------------------------------------------------------------------------
> >  def ExtractPackage(pkg, tmpdir, abiversion, flavour):
> > - cmd  = "tmpdir=" + tmpdir + "\n"
> > + cmd  = "export LC_ALL=C.UTF-8\n"
> > + cmd += "tmpdir=" + tmpdir + "\n"
> >   cmd += "pkg=" + pkg + "\n"
> >   cmd += "abiver=" + abiversion + "\n"
> >   cmd += "flavour=" + flavour + "\n"
>
> If we need this here, do we not want this in "getabis" in the trees as
> well and for the same reason.
>
> -apw

You are right. As I changed my locale, I did not realize changing that portion
of the script was not enough. In fact, it has not effect in most trees. Though
this change should still apply anyway.

I will send patches for the trees we care while I work at it.

Thanks.
Cascardo.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ACK: [kteam-tools PATCH] maint-getabis: ABI sorting with C locale

Tim Gardner-2
In reply to this post by Thadeu Lima de Souza Cascardo-3
Needed in debian/scripts/misc/getabis as well

--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Loading...