[kteam-tools][PATCH] verify-release-ready: check debian/changelog (not master) for bug numbers

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[kteam-tools][PATCH] verify-release-ready: check debian/changelog (not master) for bug numbers

Kamal Mostafa-2
Bug numbers should be extracted from the generated debian/changelog (not
debian.master/changelog) in order to work properly for derivative kernels.

Signed-off-by: Kamal Mostafa <[hidden email]>
---
 maintscripts/verify-release-ready | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
index da27c77..fdadf1d 100755
--- a/maintscripts/verify-release-ready
+++ b/maintscripts/verify-release-ready
@@ -342,10 +342,10 @@ class VerifyReleaseReady():
         s.status(msg, True)
 
     def verify_changelog_bugs(s):
-        master_changelog = Debian.master_changelog()[1]
-        changelog_bugs = master_changelog['bugs']
-        changelog_series = master_changelog['series']
-        changelog_source_package = master_changelog['package']
+        changelog = Debian.changelog()
+        changelog_bugs = changelog[1]['bugs']
+        changelog_series = changelog[1]['series']
+        changelog_source_package = changelog[1]['package']
 
         for bug in changelog_bugs:
             # Error on private or invalid bugs
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [kteam-tools][PATCH] verify-release-ready: check debian/changelog (not master) for bug numbers

Stefan Bader-2
On 02.02.2017 20:53, Kamal Mostafa wrote:
> Bug numbers should be extracted from the generated debian/changelog (not
> debian.master/changelog) in order to work properly for derivative kernels.

I have not looked at the class yet, just wondering whether there would not be a
construct to refer to debian.$derivative/changelog. The way it is done below is
working but maybe not always. Though it is probably an additional check for
having run "debian/rules clean"...

-Stefan

>
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  maintscripts/verify-release-ready | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> index da27c77..fdadf1d 100755
> --- a/maintscripts/verify-release-ready
> +++ b/maintscripts/verify-release-ready
> @@ -342,10 +342,10 @@ class VerifyReleaseReady():
>          s.status(msg, True)
>  
>      def verify_changelog_bugs(s):
> -        master_changelog = Debian.master_changelog()[1]
> -        changelog_bugs = master_changelog['bugs']
> -        changelog_series = master_changelog['series']
> -        changelog_source_package = master_changelog['package']
> +        changelog = Debian.changelog()
> +        changelog_bugs = changelog[1]['bugs']
> +        changelog_series = changelog[1]['series']
> +        changelog_source_package = changelog[1]['package']
>  
>          for bug in changelog_bugs:
>              # Error on private or invalid bugs
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [kteam-tools][PATCH] verify-release-ready: check debian/changelog (not master) for bug numbers

Tim Gardner-2
In reply to this post by Kamal Mostafa-2
I think this makes sense as it will definitely require an 'fdr clean'
beforehand.
--
Tim Gardner [hidden email]

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: ACK: [kteam-tools][PATCH] verify-release-ready: check debian/changelog (not master) for bug numbers

Tim Gardner-2