[linux-oem][PATCH 0/2] Fix headset mic issues for laptops with alc236

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[linux-oem][PATCH 0/2] Fix headset mic issues for laptops with alc236

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1729500

These two patches are only for oem-kernel here, since we need to meet the oem
project cycle. And these two patches have been CCed to stable@@vger.kernel.org
already, so they will be merged to Xenial, Zesty and Artful kernel soon.

[Impact]
plug an external microphone to system
check external microphone status

Expected results: system should able to detect external microphone

Actual results: system can't detect external microphone

[Test Case]
plug an external microphone to system
system detect an external mic, and we can record the sound well with mic

[Fix]
Add the new codec alc236 support and pin cfgs in the pin quirk table

[Regression Potential]
No, it does not change any existing functions.

Hui Wang (1):
  ALSA: hda - fix headset mic problem for Dell machines with alc236

Kailang Yang (1):
  ALSA: hda/realtek - Add support for ALC236/ALC3204

 sound/pci/hda/patch_realtek.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[linux-oem][PATCH 1/2] ALSA: hda/realtek - Add support for ALC236/ALC3204

Hui Wang
From: Kailang Yang <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1729500

Add support for ALC236/ALC3204.
Add headset mode support for ALC236/ALC3204.

Signed-off-by: Kailang Yang <[hidden email]>
Cc: <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 736f20a7060857ff569e9e9586ae6c1204a73e07)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 217bb58..f130b6c 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -327,6 +327,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
  case 0x10ec0215:
  case 0x10ec0225:
  case 0x10ec0233:
+ case 0x10ec0236:
  case 0x10ec0255:
  case 0x10ec0256:
  case 0x10ec0282:
@@ -911,6 +912,7 @@ static struct alc_codec_rename_pci_table rename_pci_tbl[] = {
  { 0x10ec0275, 0x1028, 0, "ALC3260" },
  { 0x10ec0899, 0x1028, 0, "ALC3861" },
  { 0x10ec0298, 0x1028, 0, "ALC3266" },
+ { 0x10ec0236, 0x1028, 0, "ALC3204" },
  { 0x10ec0256, 0x1028, 0, "ALC3246" },
  { 0x10ec0225, 0x1028, 0, "ALC3253" },
  { 0x10ec0295, 0x1028, 0, "ALC3254" },
@@ -3930,6 +3932,7 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec)
  alc_process_coef_fw(codec, coef0255_1);
  alc_process_coef_fw(codec, coef0255);
  break;
+ case 0x10ec0236:
  case 0x10ec0256:
  alc_process_coef_fw(codec, coef0256);
  alc_process_coef_fw(codec, coef0255);
@@ -4028,6 +4031,7 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
  };
 
  switch (codec->core.vendor_id) {
+ case 0x10ec0236:
  case 0x10ec0255:
  case 0x10ec0256:
  alc_write_coef_idx(codec, 0x45, 0xc489);
@@ -4160,6 +4164,7 @@ static void alc_headset_mode_default(struct hda_codec *codec)
  alc_process_coef_fw(codec, alc225_pre_hsmode);
  alc_process_coef_fw(codec, coef0225);
  break;
+ case 0x10ec0236:
  case 0x10ec0255:
  case 0x10ec0256:
  alc_process_coef_fw(codec, coef0255);
@@ -4256,6 +4261,7 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
  case 0x10ec0255:
  alc_process_coef_fw(codec, coef0255);
  break;
+ case 0x10ec0236:
  case 0x10ec0256:
  alc_process_coef_fw(codec, coef0256);
  break;
@@ -4366,6 +4372,7 @@ static void alc_headset_mode_omtp(struct hda_codec *codec)
  case 0x10ec0255:
  alc_process_coef_fw(codec, coef0255);
  break;
+ case 0x10ec0236:
  case 0x10ec0256:
  alc_process_coef_fw(codec, coef0256);
  break;
@@ -4451,6 +4458,7 @@ static void alc_determine_headset_type(struct hda_codec *codec)
  };
 
  switch (codec->core.vendor_id) {
+ case 0x10ec0236:
  case 0x10ec0255:
  case 0x10ec0256:
  alc_process_coef_fw(codec, coef0255);
@@ -4705,6 +4713,7 @@ static void alc255_set_default_jack_type(struct hda_codec *codec)
  case 0x10ec0255:
  alc_process_coef_fw(codec, alc255fw);
  break;
+ case 0x10ec0236:
  case 0x10ec0256:
  alc_process_coef_fw(codec, alc256fw);
  break;
@@ -6789,6 +6798,7 @@ static int patch_alc269(struct hda_codec *codec)
  case 0x10ec0255:
  spec->codec_variant = ALC269_TYPE_ALC255;
  break;
+ case 0x10ec0236:
  case 0x10ec0256:
  spec->codec_variant = ALC269_TYPE_ALC256;
  spec->shutup = alc256_shutup;
@@ -7840,6 +7850,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
  HDA_CODEC_ENTRY(0x10ec0233, "ALC233", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0234, "ALC234", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0235, "ALC233", patch_alc269),
+ HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[linux-oem][PATCH 2/2] ALSA: hda - fix headset mic problem for Dell machines with alc236

Hui Wang
In reply to this post by Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1729500

We have several Dell laptops which use the codec alc236, the headset
mic can't work on these machines. Following the commit 736f20a70, we
add the pin cfg table to make the headset mic work.

Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit f265788c336979090ac80b9ae173aa817c4fe40d)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f130b6c..fe4d063 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6411,6 +6411,14 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  ALC225_STANDARD_PINS,
  {0x12, 0xb7a60130},
  {0x1b, 0x90170110}),
+ SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+ {0x12, 0x90a60140},
+ {0x14, 0x90170110},
+ {0x21, 0x02211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+ {0x12, 0x90a60140},
+ {0x14, 0x90170150},
+ {0x21, 0x02211020}),
  SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL2_MIC_NO_PRESENCE,
  {0x14, 0x90170110},
  {0x21, 0x02211020}),
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [linux-oem][PATCH 0/2] Fix headset mic issues for laptops with alc236

Kai-Heng Feng
In reply to this post by Hui Wang

> On 2 Nov 2017, at 2:36 PM, Hui Wang <[hidden email]> wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1729500
>
> These two patches are only for oem-kernel here, since we need to meet the oem
> project cycle. And these two patches have been CCed to stable@@vger.kernel.org
> already, so they will be merged to Xenial, Zesty and Artful kernel soon.

FWIW, Zesty’s 4.10 is no longer supported by linux-stable. Therefore [hidden email] doesn’t work for it.

Acked-By: Kai-Heng Feng <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [linux-oem][PATCH 0/2] Fix headset mic issues for laptops with alc236

Hui Wang
On 2017年11月03日 14:10, Kai Heng Feng wrote:
>> On 2 Nov 2017, at 2:36 PM, Hui Wang <[hidden email]> wrote:
>>
>> BugLink: http://bugs.launchpad.net/bugs/1729500
>>
>> These two patches are only for oem-kernel here, since we need to meet the oem
>> project cycle. And these two patches have been CCed to stable@@vger.kernel.org
>> already, so they will be merged to Xenial, Zesty and Artful kernel soon.
> FWIW, Zesty’s 4.10 is no longer supported by linux-stable. Therefore [hidden email] doesn’t work for it.
Thank you for reviewing it, and I thought kernel team will cherry-pick
stable commits from 4.9 or 4.13 to Zesty kernel regularly, isn't it right?
>
> Acked-By: Kai-Heng Feng <[hidden email]>
>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [linux-oem][PATCH 0/2] Fix headset mic issues for laptops with alc236

Timo Aaltonen-8
In reply to this post by Hui Wang
On 02.11.2017 08:36, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1729500
>
> These two patches are only for oem-kernel here, since we need to meet the oem
> project cycle. And these two patches have been CCed to stable@@vger.kernel.org
> already, so they will be merged to Xenial, Zesty and Artful kernel soon.
>
> [Impact]
> plug an external microphone to system
> check external microphone status
>
> Expected results: system should able to detect external microphone
>
> Actual results: system can't detect external microphone
>
> [Test Case]
> plug an external microphone to system
> system detect an external mic, and we can record the sound well with mic
>
> [Fix]
> Add the new codec alc236 support and pin cfgs in the pin quirk table
>
> [Regression Potential]
> No, it does not change any existing functions.
>
> Hui Wang (1):
>   ALSA: hda - fix headset mic problem for Dell machines with alc236
>
> Kailang Yang (1):
>   ALSA: hda/realtek - Add support for ALC236/ALC3204
>
>  sound/pci/hda/patch_realtek.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: Re: [linux-oem][PATCH 0/2] Fix headset mic issues for laptops with alc236

Timo Aaltonen-6
In reply to this post by Hui Wang

Acked, and applied to linux-oem.

On 02.11.2017 08:36, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1729500
>
> These two patches are only for oem-kernel here, since we need to meet the oem
> project cycle. And these two patches have been CCed to stable@@vger.kernel.org
> already, so they will be merged to Xenial, Zesty and Artful kernel soon.
>
> [Impact]
> plug an external microphone to system
> check external microphone status
>
> Expected results: system should able to detect external microphone
>
> Actual results: system can't detect external microphone
>
> [Test Case]
> plug an external microphone to system
> system detect an external mic, and we can record the sound well with mic
>
> [Fix]
> Add the new codec alc236 support and pin cfgs in the pin quirk table
>
> [Regression Potential]
> No, it does not change any existing functions.
>
> Hui Wang (1):
>   ALSA: hda - fix headset mic problem for Dell machines with alc236
>
> Kailang Yang (1):
>   ALSA: hda/realtek - Add support for ALC236/ALC3204
>
>  sound/pci/hda/patch_realtek.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team