[linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1731822

Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
the pin 0x1a is for Headphone Mic, he suggested to apply
ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
verified applying this FIXUP can fix this problem.

Cc: <[hidden email]>
Cc: Kailang Yang <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 217bb58..ba48ffa 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x14, 0x90170110},
  {0x1b, 0x90a70130},
  {0x21, 0x03211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
+ {0x12, 0xb7a60130},
+ {0x13, 0xb8a61140},
+ {0x16, 0x90170110},
+ {0x21, 0x04211020}),
  SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
  {0x12, 0x90a60130},
  {0x14, 0x90170110},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

Stefan Bader-2
On 13.11.2017 05:01, Hui Wang wrote:
> BugLink: http://bugs.launchpad.net/bugs/1731822

The linked bug report is not really sru policy complete

-Stefan

>
> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
> the pin 0x1a is for Headphone Mic, he suggested to apply
> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
> verified applying this FIXUP can fix this problem.
>
> Cc: <[hidden email]>
> Cc: Kailang Yang <[hidden email]>
> Signed-off-by: Hui Wang <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
> Signed-off-by: Hui Wang <[hidden email]>
> ---
>  sound/pci/hda/patch_realtek.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 217bb58..ba48ffa 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>   {0x14, 0x90170110},
>   {0x1b, 0x90a70130},
>   {0x21, 0x03211020}),
> + SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
> + {0x12, 0xb7a60130},
> + {0x13, 0xb8a61140},
> + {0x16, 0x90170110},
> + {0x21, 0x04211020}),
>   SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>   {0x12, 0x90a60130},
>   {0x14, 0x90170110},
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

Hui Wang
On 2017年11月15日 21:38, Stefan Bader wrote:
> On 13.11.2017 05:01, Hui Wang wrote:
>> BugLink: http://bugs.launchpad.net/bugs/1731822
> The linked bug report is not really sru policy complete
Added more description to the bug report.

Thanks.

>
> -Stefan
>
>> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
>> the pin 0x1a is for Headphone Mic, he suggested to apply
>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
>> verified applying this FIXUP can fix this problem.
>>
>> Cc: <[hidden email]>
>> Cc: Kailang Yang <[hidden email]>
>> Signed-off-by: Hui Wang <[hidden email]>
>> Signed-off-by: Takashi Iwai <[hidden email]>
>> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
>> Signed-off-by: Hui Wang <[hidden email]>
>> ---
>>   sound/pci/hda/patch_realtek.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 217bb58..ba48ffa 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>>   {0x14, 0x90170110},
>>   {0x1b, 0x90a70130},
>>   {0x21, 0x03211020}),
>> + SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
>> + {0x12, 0xb7a60130},
>> + {0x13, 0xb8a61140},
>> + {0x16, 0x90170110},
>> + {0x21, 0x04211020}),
>>   SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>>   {0x12, 0x90a60130},
>>   {0x14, 0x90170110},
>>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

Stefan Bader-2
On 16.11.2017 01:57, Hui Wang wrote:
> On 2017年11月15日 21:38, Stefan Bader wrote:
>> On 13.11.2017 05:01, Hui Wang wrote:
>>> BugLink: http://bugs.launchpad.net/bugs/1731822
>> The linked bug report is not really sru policy complete
> Added more description to the bug report.

I was trying to point out the missing

===

SRU Justification:

Impact:

Fix:

Testcase:

Regression risk:

===

template stuff. In the end it is Timo's call how anally he wants to follow the
normal SRU procedure. But on the other hand making all the same is easier to
remember. :)

-Stefan

>
> Thanks.
>
>>
>> -Stefan
>>
>>> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
>>> the pin 0x1a is for Headphone Mic, he suggested to apply
>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
>>> verified applying this FIXUP can fix this problem.
>>>
>>> Cc: <[hidden email]>
>>> Cc: Kailang Yang <[hidden email]>
>>> Signed-off-by: Hui Wang <[hidden email]>
>>> Signed-off-by: Takashi Iwai <[hidden email]>
>>> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
>>> Signed-off-by: Hui Wang <[hidden email]>
>>> ---
>>>   sound/pci/hda/patch_realtek.c | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>>> index 217bb58..ba48ffa 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk
>>> alc269_pin_fixup_tbl[] = {
>>>           {0x14, 0x90170110},
>>>           {0x1b, 0x90a70130},
>>>           {0x21, 0x03211020}),
>>> +    SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell",
>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
>>> +        {0x12, 0xb7a60130},
>>> +        {0x13, 0xb8a61140},
>>> +        {0x16, 0x90170110},
>>> +        {0x21, 0x04211020}),
>>>       SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>>>           {0x12, 0x90a60130},
>>>           {0x14, 0x90170110},
>>>
>>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [linux-oem][PATCH] ALSA: hda - fix headset mic problem for Dell machines with alc274

Hui Wang
On 2017年11月17日 22:36, Stefan Bader wrote:

> On 16.11.2017 01:57, Hui Wang wrote:
>> On 2017年11月15日 21:38, Stefan Bader wrote:
>>> On 13.11.2017 05:01, Hui Wang wrote:
>>>> BugLink: http://bugs.launchpad.net/bugs/1731822
>>> The linked bug report is not really sru policy complete
>> Added more description to the bug report.
> I was trying to point out the missing
>
> ===
>
> SRU Justification:
>
> Impact:
>
> Fix:
>
> Testcase:
>
> Regression risk:
>
> ===
>
> template stuff. In the end it is Timo's call how anally he wants to follow the
> normal SRU procedure. But on the other hand making all the same is easier to
> remember. :)
>
> -Stefan
OK, got it. thank you.

>
>> Thanks.
>>
>>> -Stefan
>>>
>>>> Confirmed with Kailang of Realtek, the pin 0x19 is for Headset Mic, and
>>>> the pin 0x1a is for Headphone Mic, he suggested to apply
>>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE to fix this problem. And we
>>>> verified applying this FIXUP can fix this problem.
>>>>
>>>> Cc: <[hidden email]>
>>>> Cc: Kailang Yang <[hidden email]>
>>>> Signed-off-by: Hui Wang <[hidden email]>
>>>> Signed-off-by: Takashi Iwai <[hidden email]>
>>>> (cherry picked from commit 75ee94b20b46459e3d29f5ac2c3af3cebdeef777)
>>>> Signed-off-by: Hui Wang <[hidden email]>
>>>> ---
>>>>    sound/pci/hda/patch_realtek.c | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>>>> index 217bb58..ba48ffa 100644
>>>> --- a/sound/pci/hda/patch_realtek.c
>>>> +++ b/sound/pci/hda/patch_realtek.c
>>>> @@ -6510,6 +6510,11 @@ static const struct snd_hda_pin_quirk
>>>> alc269_pin_fixup_tbl[] = {
>>>>            {0x14, 0x90170110},
>>>>            {0x1b, 0x90a70130},
>>>>            {0x21, 0x03211020}),
>>>> +    SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell",
>>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,
>>>> +        {0x12, 0xb7a60130},
>>>> +        {0x13, 0xb8a61140},
>>>> +        {0x16, 0x90170110},
>>>> +        {0x21, 0x04211020}),
>>>>        SND_HDA_PIN_QUIRK(0x10ec0280, 0x103c, "HP", ALC280_FIXUP_HP_GPIO4,
>>>>            {0x12, 0x90a60130},
>>>>            {0x14, 0x90170110},
>>>>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team