[linux-oem][PATCH] UBUNTU: SAUCE: Revert "cfg80211: workaround for mwifiex"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[linux-oem][PATCH] UBUNTU: SAUCE: Revert "cfg80211: workaround for mwifiex"

Wen-chien Jesse Sung
BugLink: http://bugs.launchpad.net/bugs/1725154

This commit reverts "UBUNTU: SAUCE: cfg80211: workaround for mwifiex"
which is a workaround for a mwifiex issue.

The proper fix is 879ab4225c7cacba77f4310616513c46a82b1dd1 "cfg80211:
fix connect/disconnect edge cases" and we already have this commit
via stable updates.

Signed-off-by: Wen-chien Jesse Sung <[hidden email]>
---
 net/wireless/sme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 81baa29..b6533ec 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -1166,7 +1166,7 @@ int cfg80211_disconnect(struct cfg80211_registered_device *rdev,
  err = cfg80211_sme_disconnect(wdev, reason);
  else if (!rdev->ops->disconnect)
  cfg80211_mlme_down(rdev, dev);
- else if (wdev->ssid_len || wdev->current_bss)
+ else if (wdev->ssid_len)
  err = rdev_disconnect(rdev, dev, reason);
 
  /*
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [linux-oem][PATCH] UBUNTU: SAUCE: Revert "cfg80211: workaround for mwifiex"

Kai-Heng Feng

> On Feb 14, 2018, at 4:32 PM, Wen-chien Jesse Sung  
> <[hidden email]> wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1725154
>
> This commit reverts "UBUNTU: SAUCE: cfg80211: workaround for mwifiex"
> which is a workaround for a mwifiex issue.
>
> The proper fix is 879ab4225c7cacba77f4310616513c46a82b1dd1 "cfg80211:
> fix connect/disconnect edge cases" and we already have this commit
> via stable updates.
>
> Signed-off-by: Wen-chien Jesse Sung <[hidden email]>

Acked-by: Kai-Heng Feng <[hidden email]>

> ---
>  net/wireless/sme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 81baa29..b6533ec 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -1166,7 +1166,7 @@ int cfg80211_disconnect(struct  
> cfg80211_registered_device *rdev,
>   err = cfg80211_sme_disconnect(wdev, reason);
>   else if (!rdev->ops->disconnect)
>   cfg80211_mlme_down(rdev, dev);
> - else if (wdev->ssid_len || wdev->current_bss)
> + else if (wdev->ssid_len)
>   err = rdev_disconnect(rdev, dev, reason);
>
>   /*
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [linux-oem][PATCH] UBUNTU: SAUCE: Revert "cfg80211: workaround for mwifiex"

Anthony Wong-2
In reply to this post by Wen-chien Jesse Sung
On Wed, Feb 14, 2018 at 04:32:40PM +0800, Wen-chien Jesse Sung wrote:

> BugLink: http://bugs.launchpad.net/bugs/1725154
>
> This commit reverts "UBUNTU: SAUCE: cfg80211: workaround for mwifiex"
> which is a workaround for a mwifiex issue.
>
> The proper fix is 879ab4225c7cacba77f4310616513c46a82b1dd1 "cfg80211:
> fix connect/disconnect edge cases" and we already have this commit
> via stable updates.
>
> Signed-off-by: Wen-chien Jesse Sung <[hidden email]>
> ---
>  net/wireless/sme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 81baa29..b6533ec 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -1166,7 +1166,7 @@ int cfg80211_disconnect(struct cfg80211_registered_device *rdev,
>   err = cfg80211_sme_disconnect(wdev, reason);
>   else if (!rdev->ops->disconnect)
>   cfg80211_mlme_down(rdev, dev);
> - else if (wdev->ssid_len || wdev->current_bss)
> + else if (wdev->ssid_len)
>   err = rdev_disconnect(rdev, dev, reason);
>  
>   /*

Acked-by: Anthony Wong <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/OEM Re: [linux-oem][PATCH] UBUNTU: SAUCE: Revert "cfg80211: workaround for mwifiex"

Timo Aaltonen-6
In reply to this post by Wen-chien Jesse Sung
On 14.02.2018 10:32, Wen-chien Jesse Sung wrote:

> BugLink: http://bugs.launchpad.net/bugs/1725154
>
> This commit reverts "UBUNTU: SAUCE: cfg80211: workaround for mwifiex"
> which is a workaround for a mwifiex issue.
>
> The proper fix is 879ab4225c7cacba77f4310616513c46a82b1dd1 "cfg80211:
> fix connect/disconnect edge cases" and we already have this commit
> via stable updates.
>
> Signed-off-by: Wen-chien Jesse Sung <[hidden email]>
> ---
>  net/wireless/sme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 81baa29..b6533ec 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -1166,7 +1166,7 @@ int cfg80211_disconnect(struct cfg80211_registered_device *rdev,
>   err = cfg80211_sme_disconnect(wdev, reason);
>   else if (!rdev->ops->disconnect)
>   cfg80211_mlme_down(rdev, dev);
> - else if (wdev->ssid_len || wdev->current_bss)
> + else if (wdev->ssid_len)
>   err = rdev_disconnect(rdev, dev, reason);
>  
>   /*
>

applied to linux-oem, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team