[patch] fix amd64 ACPI issues

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] fix amd64 ACPI issues

henry.su
Hi,
The is one patch in kernel upstream which fixes the S3/S4 issues on
AMD64 platforms with more than 4G memory, could you please backport it
to the latest Ubuntu8.10 kernel? The git link is:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98

Thanks.

BRS,
Henry


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix amd64 ACPI issues

Tim Gardner-2
Su, Henry wrote:

> Hi,
> The is one patch in kernel upstream which fixes the S3/S4 issues on
> AMD64 platforms with more than 4G memory, could you please backport it
> to the latest Ubuntu8.10 kernel? The git link is:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>
> Thanks.
>
> BRS,
> Henry
>
>
Can you try this? I don't have the right hardware.

rtg
--
Tim Gardner [hidden email]

From 0c064e7409c72ecaee8687705be61d2479002826 Mon Sep 17 00:00:00 2001
From: Rafael J. Wysocki <[hidden email]>
Date: Tue, 10 Jun 2008 00:10:48 +0200
Subject: [PATCH] x86, gart: add resume handling

If GART IOMMU is used on an AMD64 system, the northbridge registers
related to it should be restored during resume so that memory is not
corrupted.  Make gart_resume() handle that as appropriate.

Ref. http://lkml.org/lkml/2008/5/25/96 and the following thread.

Backported to 2.6.24

Signed-off-by: Rafael J. Wysocki <[hidden email]>
Signed-off-by: Ingo Molnar <[hidden email]>
Signed-off-by: Tim Gardner <[hidden email]>
---
 arch/x86/kernel/aperture_64.c |    8 ++-
 arch/x86/kernel/pci-gart_64.c |  109 +++++++++++++++++++++++++++++++++++-----
 drivers/char/agp/amd64-agp.c  |   20 --------
 include/asm-x86/gart.h        |   21 ++++++++
 4 files changed, 121 insertions(+), 37 deletions(-)

diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index e469a1d..91ad861 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -296,7 +296,9 @@ void __init gart_iommu_hole_init(void)
  /* Don't enable translation yet. That is done later.
    Assume this BIOS didn't initialise the GART so
    just overwrite all previous bits */
- write_pci_config(0, num, 3, 0x90, aper_order<<1);
- write_pci_config(0, num, 3, 0x94, aper_alloc>>25);
+ write_pci_config(0, num, 3, AMD64_GARTAPERTURECTL, aper_order<<1);
+ write_pci_config(0, num, 3, AMD64_GARTAPERTUREBASE, aper_alloc>>25);
  }
-}
+
+ set_up_gart_resume(aper_order, aper_alloc);
+}
diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
index 06bcba5..ff31b0d 100644
--- a/arch/x86/kernel/pci-gart_64.c
+++ b/arch/x86/kernel/pci-gart_64.c
@@ -25,6 +25,7 @@
 #include <linux/bitops.h>
 #include <linux/kdebug.h>
 #include <linux/scatterlist.h>
+#include <linux/sysdev.h>
 #include <asm/atomic.h>
 #include <asm/io.h>
 #include <asm/mtrr.h>
@@ -79,6 +80,23 @@ AGPEXTERN __u32 *agp_gatt_table;
 static unsigned long next_bit;  /* protected by iommu_bitmap_lock */
 static int need_flush; /* global flush state. set for each gart wrap */
 
+static inline void enable_gart_translation(struct pci_dev *dev, u64 addr)
+{
+ u32 tmp, ctl;
+
+        /* address of the mappings table */
+        addr >>= 12;
+        tmp = (u32) addr<<4;
+        tmp &= ~0xf;
+        pci_write_config_dword(dev, AMD64_GARTTABLEBASE, tmp);
+
+        /* Enable GART translation for this hammer. */
+        pci_read_config_dword(dev, AMD64_GARTAPERTURECTL, &ctl);
+        ctl |= GARTEN;
+        ctl &= ~(DISGARTCPU | DISGARTIO);
+        pci_write_config_dword(dev, AMD64_GARTAPERTURECTL, ctl);
+}
+
 static unsigned long alloc_iommu(int size)
 {
  unsigned long offset, flags;
@@ -492,6 +510,76 @@ static __init unsigned read_aperture(struct pci_dev *dev, u32 *size)
  return aper_base;
 }
 
+static void enable_gart_translations(void)
+{
+ int i;
+
+ for (i = 0; i < num_k8_northbridges; i++) {
+ struct pci_dev *dev = k8_northbridges[i];
+
+ enable_gart_translation(dev, __pa(agp_gatt_table));
+ }
+}
+
+/*
+ * If fix_up_north_bridges is set, the north bridges have to be fixed up on
+ * resume in the same way as they are handled in gart_iommu_hole_init().
+ */
+static bool fix_up_north_bridges;
+static u32 aperture_order;
+static u32 aperture_alloc;
+
+void set_up_gart_resume(u32 aper_order, u32 aper_alloc)
+{
+ fix_up_north_bridges = true;
+ aperture_order = aper_order;
+ aperture_alloc = aper_alloc;
+}
+
+static int gart_resume(struct sys_device *dev)
+{
+ printk(KERN_INFO "PCI-DMA: Resuming GART IOMMU\n");
+
+ if (fix_up_north_bridges) {
+ int i;
+
+ printk(KERN_INFO "PCI-DMA: Restoring GART aperture settings\n");
+
+ for (i = 0; i < num_k8_northbridges; i++) {
+ struct pci_dev *dev = k8_northbridges[i];
+
+ /*
+ * Don't enable translations just yet.  That is the next
+ * step.  Restore the pre-suspend aperture settings.
+ */
+ pci_write_config_dword(dev, AMD64_GARTAPERTURECTL,
+ aperture_order << 1);
+ pci_write_config_dword(dev, AMD64_GARTAPERTUREBASE,
+ aperture_alloc >> 25);
+ }
+ }
+
+ enable_gart_translations();
+
+ return 0;
+}
+
+static int gart_suspend(struct sys_device *dev, pm_message_t state)
+{
+ return 0;
+}
+
+static struct sysdev_class gart_sysdev_class = {
+ // .name = "gart",
+ .suspend = gart_suspend,
+ .resume = gart_resume,
+};
+
+static struct sys_device device_gart = {
+ .id = 0,
+ .cls = &gart_sysdev_class,
+};
+
 /*
  * Private Northbridge GATT initialization in case we cannot use the
  * AGP driver for some reason.  
@@ -502,7 +590,7 @@ static __init int init_k8_gatt(struct agp_kern_info *info)
  void *gatt;
  unsigned aper_base, new_aper_base;
  unsigned aper_size, gatt_size, new_aper_size;
- int i;
+ int i,error;
 
  printk(KERN_INFO "PCI-DMA: Disabling AGP.\n");
  aper_size = aper_base = info->aper_size = 0;
@@ -536,21 +624,14 @@ static __init int init_k8_gatt(struct agp_kern_info *info)
  memset(gatt, 0, gatt_size);
  agp_gatt_table = gatt;
 
- for (i = 0; i < num_k8_northbridges; i++) {
- u32 ctl;
- u32 gatt_reg;
+ enable_gart_translations();
 
- dev = k8_northbridges[i];
- gatt_reg = __pa(gatt) >> 12;
- gatt_reg <<= 4;
- pci_write_config_dword(dev, 0x98, gatt_reg);
- pci_read_config_dword(dev, 0x90, &ctl);
+ error = sysdev_class_register(&gart_sysdev_class);
+ if (!error)
+ error = sysdev_register(&device_gart);
+ if (error)
+ panic("Could not register gart_sysdev -- would corrupt data on next suspend");
 
- ctl |= 1;
- ctl &= ~((1<<4) | (1<<5));
-
- pci_write_config_dword(dev, 0x90, ctl);
- }
  flush_gart();
 
  printk("PCI-DMA: aperture base @ %x size %u KB\n",aper_base, aper_size>>10);
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index d8200ac..4ad69a6 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -18,26 +18,6 @@
 #include <asm/k8.h>
 #include "agp.h"
 
-/* PTE bits. */
-#define GPTE_VALID 1
-#define GPTE_COHERENT 2
-
-/* Aperture control register bits. */
-#define GARTEN (1<<0)
-#define DISGARTCPU (1<<4)
-#define DISGARTIO (1<<5)
-
-/* GART cache control register bits. */
-#define INVGART (1<<0)
-#define GARTPTEERR (1<<1)
-
-/* K8 On-cpu GART registers */
-#define AMD64_GARTAPERTURECTL 0x90
-#define AMD64_GARTAPERTUREBASE 0x94
-#define AMD64_GARTTABLEBASE 0x98
-#define AMD64_GARTCACHECTL 0x9c
-#define AMD64_GARTEN (1<<0)
-
 /* NVIDIA K8 registers */
 #define NVIDIA_X86_64_0_APBASE 0x10
 #define NVIDIA_X86_64_1_APBASE1 0x50
diff --git a/include/asm-x86/gart.h b/include/asm-x86/gart.h
index f704c50..b9fb3df 100644
--- a/include/asm-x86/gart.h
+++ b/include/asm-x86/gart.h
@@ -1,6 +1,26 @@
 #ifndef _ASM_X8664_IOMMU_H
 #define _ASM_X8664_IOMMU_H 1
 
+/* PTE bits. */
+#define GPTE_VALID 1
+#define GPTE_COHERENT 2
+
+/* Aperture control register bits. */
+#define GARTEN (1<<0)
+#define DISGARTCPU (1<<4)
+#define DISGARTIO (1<<5)
+
+/* GART cache control register bits. */
+#define INVGART (1<<0)
+#define GARTPTEERR (1<<1)
+
+/* K8 On-cpu GART registers */
+#define AMD64_GARTAPERTURECTL 0x90
+#define AMD64_GARTAPERTUREBASE 0x94
+#define AMD64_GARTTABLEBASE 0x98
+#define AMD64_GARTCACHECTL 0x9c
+#define AMD64_GARTEN (1<<0)
+
 extern void pci_iommu_shutdown(void);
 extern void no_iommu_init(void);
 extern int force_iommu, no_iommu;
@@ -10,6 +30,7 @@ extern void gart_iommu_init(void);
 extern void gart_iommu_shutdown(void);
 extern void __init gart_parse_options(char *);
 extern void gart_iommu_hole_init(void);
+extern void set_up_gart_resume(u32, u32);
 extern int fallback_aper_order;
 extern int fallback_aper_force;
 extern int gart_iommu_aperture;
--
1.5.4.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[Hardy][Intrepid] SRU: fix amd64 ACPI issues

Stefan Bader-2
In reply to this post by henry.su
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Su, Henry wrote:

> Hi,
> The is one patch in kernel upstream which fixes the S3/S4 issues on
> AMD64 platforms with more than 4G memory, could you please backport it
> to the latest Ubuntu8.10 kernel? The git link is:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>
> Thanks.
>
> BRS,
> Henry
>
>
I had a look at the Hardy and Intrepid code. For Hardy there is actually
another patch missing which sound like (beside of being an absolute must for
the patch) sounds serious.

Subject: [PATCH] suspend-vs-iommu: prevent suspend if we could not resume

iommu/gart support misses suspend/resume code, which can do bad stuff,
including memory corruption on resume.  Prevent system suspend in case we
would be unable to resume.

Possible suspect https://bugs.launchpad.net/ubuntu/+source/linux/+bug/236902
but this is just an unverified guess.

The remainder of the patch has to be slightly modified since it depends on
other changes. This is also true for Intrepid. Ben, what would be your favoured
approach: include as many upstream changes or keep the changes minimal?

Stefan
- --

When all other means of communication fail, try words!


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIqdXxP+TjRTJVqvQRAhlmAKClVJoNtyV5gACGRvo+C/p9WJUexQCffSDo
VLU3VWNU/fiZnNMhwDC/XYA=
=iz+C
-----END PGP SIGNATURE-----

From 0066865ca8746df4934effe245c8e89b4c2d0b03 Mon Sep 17 00:00:00 2001
From: Stefan Bader <[hidden email]>
Date: Mon, 18 Aug 2008 12:49:47 -0400
Subject: [PATCH] suspend-vs-iommu: prevent suspend if we could not resume

commit cd76374e9de4501acc74f833dc6cb5e7a5dca115
Author: Pavel Machek <[hidden email]>
Date:   Thu May 29 00:30:21 2008 -0700

    iommu/gart support misses suspend/resume code, which can do bad stuff,
    including memory corruption on resume.  Prevent system suspend in case we
    would be unable to resume.

    Signed-off-by: Pavel Machek <[hidden email]>
    Tested-by: Patrick <[hidden email]>
    Signed-off-by: Andrew Morton <[hidden email]>
    Signed-off-by: Ingo Molnar <[hidden email]>

Signed-off-by: Stefan Bader <[hidden email]>
---
 arch/x86/kernel/pci-gart_64.c |   31 ++++++++++++++++++++++++++++++-
 1 files changed, 30 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
index 06bcba5..c5e46d2 100644
--- a/arch/x86/kernel/pci-gart_64.c
+++ b/arch/x86/kernel/pci-gart_64.c
@@ -25,6 +25,7 @@
 #include <linux/bitops.h>
 #include <linux/kdebug.h>
 #include <linux/scatterlist.h>
+#include <linux/sysdev.h>
 #include <asm/atomic.h>
 #include <asm/io.h>
 #include <asm/mtrr.h>
@@ -492,6 +493,27 @@ static __init unsigned read_aperture(struct pci_dev *dev, u32 *size)
  return aper_base;
 }
 
+static int gart_resume(struct sys_device *dev)
+{
+ return 0;
+}
+
+static int gart_suspend(struct sys_device *dev, pm_message_t state)
+{
+ return -EINVAL;
+}
+
+static struct sysdev_class gart_sysdev_class = {
+ .name = "gart",
+ .suspend = gart_suspend,
+ .resume = gart_resume,
+};
+
+static struct sys_device device_gart = {
+ .id = 0,
+ .cls = &gart_sysdev_class,
+};
+
 /*
  * Private Northbridge GATT initialization in case we cannot use the
  * AGP driver for some reason.  
@@ -502,7 +524,7 @@ static __init int init_k8_gatt(struct agp_kern_info *info)
  void *gatt;
  unsigned aper_base, new_aper_base;
  unsigned aper_size, gatt_size, new_aper_size;
- int i;
+ int i, error;
 
  printk(KERN_INFO "PCI-DMA: Disabling AGP.\n");
  aper_size = aper_base = info->aper_size = 0;
@@ -551,6 +573,13 @@ static __init int init_k8_gatt(struct agp_kern_info *info)
 
  pci_write_config_dword(dev, 0x90, ctl);
  }
+
+ error = sysdev_class_register(&gart_sysdev_class);
+ if (!error)
+ error = sysdev_register(&device_gart);
+ if (error)
+ panic("Could not register gart_sysdev -- " \
+ "would corrupt data on next suspend");
  flush_gart();
 
  printk("PCI-DMA: aperture base @ %x size %u KB\n",aper_base, aper_size>>10);
--
1.5.4.3


From 7b1e91930a1866ecd6d2176e5622fc74b25fbe3c Mon Sep 17 00:00:00 2001
From: Stefan Bader <[hidden email]>
Date: Mon, 18 Aug 2008 13:29:41 -0400
Subject: [PATCH] x86, gart: add resume handling

Author: Rafael J. Wysocki <[hidden email]>
Date:   Tue Jun 10 00:10:48 2008 +0200

Picked from upstream 6703f6d10dcd3316e03641a5ecaa6c8a04374d98

If GART IOMMU is used on an AMD64 system, the northbridge registers
related to it should be restored during resume so that memory is not
corrupted.  Make gart_resume() handle that as appropriate.

Ref. http://lkml.org/lkml/2008/5/25/96 and the following thread.

Signed-off-by: Rafael J. Wysocki <[hidden email]>
Signed-off-by: Ingo Molnar <[hidden email]>
Signed-off-by: Stefan Bader <[hidden email]>
---
 arch/x86/kernel/aperture_64.c |    2 +
 arch/x86/kernel/pci-gart_64.c |   76 +++++++++++++++++++++++++++++++---------
 include/asm-x86/gart.h        |    1 +
 3 files changed, 62 insertions(+), 17 deletions(-)

diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
index e469a1d..c23333f 100644
--- a/arch/x86/kernel/aperture_64.c
+++ b/arch/x86/kernel/aperture_64.c
@@ -299,4 +299,6 @@ void __init gart_iommu_hole_init(void)
  write_pci_config(0, num, 3, 0x90, aper_order<<1);
  write_pci_config(0, num, 3, 0x94, aper_alloc>>25);
  }
+
+ set_up_gart_resume(aper_order, aper_alloc);
 }
diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
index c5e46d2..9d7ed16 100644
--- a/arch/x86/kernel/pci-gart_64.c
+++ b/arch/x86/kernel/pci-gart_64.c
@@ -493,18 +493,74 @@ static __init unsigned read_aperture(struct pci_dev *dev, u32 *size)
  return aper_base;
 }
 
+static void enable_gart_translations(void)
+{
+ int i;
+
+ for (i = 0; i < num_k8_northbridges; i++) {
+ struct pci_dev *dev = k8_northbridges[i];
+ u32 ctl;
+ u32 gatt_reg;
+
+ gatt_reg = __pa(agp_gatt_table) >> 12;
+ gatt_reg <<= 4;
+ pci_write_config_dword(dev, 0x98, gatt_reg);
+ pci_read_config_dword(dev, 0x90, &ctl);
+
+ ctl |= 1;
+ ctl &= ~((1<<4) | (1<<5));
+
+ pci_write_config_dword(dev, 0x90, ctl);
+ }
+}
+
+/*
+ * If fix_up_north_bridges is set, the north bridges have to be fixed up on
+ * resume in the same way as they are handled in gart_iommu_hole_init().
+ */
+static bool fix_up_north_bridges;
+static u32 aperture_order;
+static u32 aperture_alloc;
+
+void set_up_gart_resume(u32 aper_order, u32 aper_alloc)
+{
+ fix_up_north_bridges = true;
+ aperture_order = aper_order;
+ aperture_alloc = aper_alloc;
+}
+
 static int gart_resume(struct sys_device *dev)
 {
+ printk(KERN_INFO "PCI-DMA: Resuming GART IOMMU\n");
+
+ if (fix_up_north_bridges) {
+ int i;
+
+ printk(KERN_INFO "PCI-DMA: Restoring GART aperture settings\n");
+
+ for (i = 0; i < num_k8_northbridges; i++) {
+ struct pci_dev *dev = k8_northbridges[i];
+
+ /*
+ * Don't enable translations just yet.  That is the next
+ * step.  Restore the pre-suspend aperture settings.
+ */
+ pci_write_config_dword(dev, 0x90, aperture_order << 1);
+ pci_write_config_dword(dev, 0x94, aperture_alloc >> 25);
+ }
+ }
+
+ enable_gart_translations();
+
  return 0;
 }
 
 static int gart_suspend(struct sys_device *dev, pm_message_t state)
 {
- return -EINVAL;
+ return 0;
 }
 
 static struct sysdev_class gart_sysdev_class = {
- .name = "gart",
  .suspend = gart_suspend,
  .resume = gart_resume,
 };
@@ -558,21 +614,7 @@ static __init int init_k8_gatt(struct agp_kern_info *info)
  memset(gatt, 0, gatt_size);
  agp_gatt_table = gatt;
 
- for (i = 0; i < num_k8_northbridges; i++) {
- u32 ctl;
- u32 gatt_reg;
-
- dev = k8_northbridges[i];
- gatt_reg = __pa(gatt) >> 12;
- gatt_reg <<= 4;
- pci_write_config_dword(dev, 0x98, gatt_reg);
- pci_read_config_dword(dev, 0x90, &ctl);
-
- ctl |= 1;
- ctl &= ~((1<<4) | (1<<5));
-
- pci_write_config_dword(dev, 0x90, ctl);
- }
+ enable_gart_translations();
 
  error = sysdev_class_register(&gart_sysdev_class);
  if (!error)
diff --git a/include/asm-x86/gart.h b/include/asm-x86/gart.h
index f704c50..1cf5986 100644
--- a/include/asm-x86/gart.h
+++ b/include/asm-x86/gart.h
@@ -10,6 +10,7 @@ extern void gart_iommu_init(void);
 extern void gart_iommu_shutdown(void);
 extern void __init gart_parse_options(char *);
 extern void gart_iommu_hole_init(void);
+extern void set_up_gart_resume(u32, u32);
 extern int fallback_aper_order;
 extern int fallback_aper_force;
 extern int gart_iommu_aperture;
--
1.5.4.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

RE: [patch] fix amd64 ACPI issues

henry.su
In reply to this post by Tim Gardner-2
This patch fixes the s3/s4 issues; could you please apply it to the 8.10
kernel? thanks!

Henry

-----Original Message-----
From: Tim Gardner [mailto:[hidden email]]
Sent: Tuesday, August 19, 2008 4:03 AM
To: Su, Henry
Cc: [hidden email]
Subject: Re: [patch] fix amd64 ACPI issues

Su, Henry wrote:
> Hi,
> The is one patch in kernel upstream which fixes the S3/S4 issues on
> AMD64 platforms with more than 4G memory, could you please backport it
> to the latest Ubuntu8.10 kernel? The git link is:
>
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>
> Thanks.
>
> BRS,
> Henry
>
>

Can you try this? I don't have the right hardware.

rtg
--
Tim Gardner [hidden email]


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix amd64 ACPI issues

Ben Collins-4
Su, Henry wrote:
> This patch fixes the s3/s4 issues; could you please apply it to the 8.10
> kernel? thanks!

NACK. Since we're moving to 2.6.27 in all likely hood, you will get this
anyway.

> Henry
>
> -----Original Message-----
> From: Tim Gardner [mailto:[hidden email]]
> Sent: Tuesday, August 19, 2008 4:03 AM
> To: Su, Henry
> Cc: [hidden email]
> Subject: Re: [patch] fix amd64 ACPI issues
>
> Su, Henry wrote:
>> Hi,
>> The is one patch in kernel upstream which fixes the S3/S4 issues on
>> AMD64 platforms with more than 4G memory, could you please backport it
>> to the latest Ubuntu8.10 kernel? The git link is:
>>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
>> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>>
>> Thanks.
>>
>> BRS,
>> Henry
>>
>>
>
> Can you try this? I don't have the right hardware.
>
> rtg


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

RE: [patch] fix amd64 ACPI issues

henry.su

Hi Ben,
These S3/S4 issues still exist with Ubuntu8.10 Alpha4, could you please
check if the attached patch and the patch in
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
Have been applied in ubuntu8.10 Alpha4 kernel? and I like to check these
patches if you give me the kernel source, thanks!

BRS,
Henry

-----Original Message-----
From: Ben Collins [mailto:[hidden email]]
Sent: Friday, August 22, 2008 11:57 PM
To: Su, Henry
Cc: Kernel team list
Subject: Re: [patch] fix amd64 ACPI issues

Su, Henry wrote:
> This patch fixes the s3/s4 issues; could you please apply it to the
8.10
> kernel? thanks!

NACK. Since we're moving to 2.6.27 in all likely hood, you will get this

anyway.

> Henry
>
> -----Original Message-----
> From: Tim Gardner [mailto:[hidden email]]
> Sent: Tuesday, August 19, 2008 4:03 AM
> To: Su, Henry
> Cc: [hidden email]
> Subject: Re: [patch] fix amd64 ACPI issues
>
> Su, Henry wrote:
>> Hi,
>> The is one patch in kernel upstream which fixes the S3/S4 issues on
>> AMD64 platforms with more than 4G memory, could you please backport
it
>> to the latest Ubuntu8.10 kernel? The git link is:
>>
>
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi

>> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>>
>> Thanks.
>>
>> BRS,
>> Henry
>>
>>
>
> Can you try this? I don't have the right hardware.
>
> rtg


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

fix_hibernation_oops_with_4GB_RAM.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [patch] fix amd64 ACPI issues

Ben Collins-4
Su, Henry wrote:
> Hi Ben,
> These S3/S4 issues still exist with Ubuntu8.10 Alpha4, could you please
> check if the attached patch and the patch in
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
> Have been applied in ubuntu8.10 Alpha4 kernel? and I like to check these
> patches if you give me the kernel source, thanks!

Our current tree is ubuntu-intrepid on http://kernel.ubuntu.com/git

Is this upstream in 2.6.27? If not, then we'll apply the patches.

> BRS,
> Henry
>
> -----Original Message-----
> From: Ben Collins [mailto:[hidden email]]
> Sent: Friday, August 22, 2008 11:57 PM
> To: Su, Henry
> Cc: Kernel team list
> Subject: Re: [patch] fix amd64 ACPI issues
>
> Su, Henry wrote:
>> This patch fixes the s3/s4 issues; could you please apply it to the
> 8.10
>> kernel? thanks!
>
> NACK. Since we're moving to 2.6.27 in all likely hood, you will get this
>
> anyway.
>
>> Henry
>>
>> -----Original Message-----
>> From: Tim Gardner [mailto:[hidden email]]
>> Sent: Tuesday, August 19, 2008 4:03 AM
>> To: Su, Henry
>> Cc: [hidden email]
>> Subject: Re: [patch] fix amd64 ACPI issues
>>
>> Su, Henry wrote:
>>> Hi,
>>> The is one patch in kernel upstream which fixes the S3/S4 issues on
>>> AMD64 platforms with more than 4G memory, could you please backport
> it
>>> to the latest Ubuntu8.10 kernel? The git link is:
>>>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
>>> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>>>
>>> Thanks.
>>>
>>> BRS,
>>> Henry
>>>
>>>
>> Can you try this? I don't have the right hardware.
>>
>> rtg
>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

RE: [patch] fix amd64 ACPI issues

Nath, Arindam
Hi Ben,
       This patch is already there in the kernel-2.6.27-rc1, so with all
possibility, it should go into the kernel-2.6.27 upstream too. Thanks.

Regards,
Arindam

-----Original Message-----
From: Ben Collins [mailto:[hidden email]]
Sent: Wednesday, August 27, 2008 7:17 PM
To: Su, Henry
Cc: Kernel team list; Nath, Arindam
Subject: Re: [patch] fix amd64 ACPI issues

Su, Henry wrote:
> Hi Ben,
> These S3/S4 issues still exist with Ubuntu8.10 Alpha4, could you
please
> check if the attached patch and the patch in
>
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi
> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
> Have been applied in ubuntu8.10 Alpha4 kernel? and I like to check
these
> patches if you give me the kernel source, thanks!

Our current tree is ubuntu-intrepid on http://kernel.ubuntu.com/git

Is this upstream in 2.6.27? If not, then we'll apply the patches.

> BRS,
> Henry
>
> -----Original Message-----
> From: Ben Collins [mailto:[hidden email]]
> Sent: Friday, August 22, 2008 11:57 PM
> To: Su, Henry
> Cc: Kernel team list
> Subject: Re: [patch] fix amd64 ACPI issues
>
> Su, Henry wrote:
>> This patch fixes the s3/s4 issues; could you please apply it to the
> 8.10
>> kernel? thanks!
>
> NACK. Since we're moving to 2.6.27 in all likely hood, you will get
this

>
> anyway.
>
>> Henry
>>
>> -----Original Message-----
>> From: Tim Gardner [mailto:[hidden email]]
>> Sent: Tuesday, August 19, 2008 4:03 AM
>> To: Su, Henry
>> Cc: [hidden email]
>> Subject: Re: [patch] fix amd64 ACPI issues
>>
>> Su, Henry wrote:
>>> Hi,
>>> The is one patch in kernel upstream which fixes the S3/S4 issues on
>>> AMD64 platforms with more than 4G memory, could you please backport
> it
>>> to the latest Ubuntu8.10 kernel? The git link is:
>>>
>
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commi

>>> t;h=6703f6d10dcd3316e03641a5ecaa6c8a04374d98
>>>
>>> Thanks.
>>>
>>> BRS,
>>> Henry
>>>
>>>
>> Can you try this? I don't have the right hardware.
>>
>> rtg
>
>




--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team