[x/azure][PATCH] blk-mq: remove the request_list usage

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[x/azure][PATCH] blk-mq: remove the request_list usage

Marcelo Henrique Cerri
From: Jens Axboe <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1819689

We don't do anything with it, that's just the legacy path.

Reviewed-by: Hannes Reinecke <[hidden email]>
Tested-by: Ming Lei <[hidden email]>
Reviewed-by: Omar Sandoval <[hidden email]>
Signed-off-by: Jens Axboe <[hidden email]>
(backported from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
[[hidden email]: fixed context]
Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 block/blk-mq.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 2f8436314985..caeffd5b59f9 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -501,9 +501,6 @@ void blk_mq_free_request(struct request *rq)
 
  wbt_done(q->rq_wb, &rq->issue_stat);
 
- if (blk_rq_rl(rq))
- blk_put_rl(blk_rq_rl(rq));
-
  clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags);
  clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);
  if (rq->tag != -1)
@@ -1637,8 +1634,6 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
 {
  blk_init_request_from_bio(rq, bio);
 
- blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
-
  blk_account_io_start(rq, true);
 }
 
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[c/azure][PATCH] blk-mq: remove the request_list usage

Marcelo Henrique Cerri
From: Jens Axboe <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1819689

We don't do anything with it, that's just the legacy path.

Reviewed-by: Hannes Reinecke <[hidden email]>
Tested-by: Ming Lei <[hidden email]>
Reviewed-by: Omar Sandoval <[hidden email]>
Signed-off-by: Jens Axboe <[hidden email]>
(cherry picked from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 block/blk-mq.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 90e8058ae557..76702ea84dd5 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -508,9 +508,6 @@ void blk_mq_free_request(struct request *rq)
 
  wbt_done(q->rq_wb, rq);
 
- if (blk_rq_rl(rq))
- blk_put_rl(blk_rq_rl(rq));
-
  WRITE_ONCE(rq->state, MQ_RQ_IDLE);
  if (refcount_dec_and_test(&rq->ref))
  __blk_mq_free_request(rq);
@@ -1626,8 +1623,6 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
 {
  blk_init_request_from_bio(rq, bio);
 
- blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
-
  blk_account_io_start(rq, true);
 }
 
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [c/azure][PATCH] blk-mq: remove the request_list usage

Stefan Bader-2
On 22.04.19 22:32, Marcelo Henrique Cerri wrote:

> From: Jens Axboe <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1819689
>
> We don't do anything with it, that's just the legacy path.
>
> Reviewed-by: Hannes Reinecke <[hidden email]>
> Tested-by: Ming Lei <[hidden email]>
> Reviewed-by: Omar Sandoval <[hidden email]>
> Signed-off-by: Jens Axboe <[hidden email]>
> (cherry picked from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
> Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  block/blk-mq.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 90e8058ae557..76702ea84dd5 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -508,9 +508,6 @@ void blk_mq_free_request(struct request *rq)
>  
>   wbt_done(q->rq_wb, rq);
>  
> - if (blk_rq_rl(rq))
> - blk_put_rl(blk_rq_rl(rq));
> -
>   WRITE_ONCE(rq->state, MQ_RQ_IDLE);
>   if (refcount_dec_and_test(&rq->ref))
>   __blk_mq_free_request(rq);
> @@ -1626,8 +1623,6 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
>  {
>   blk_init_request_from_bio(rq, bio);
>  
> - blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
> -
>   blk_account_io_start(rq, true);
>  }
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [x/azure][PATCH] blk-mq: remove the request_list usage

Kleber Souza
In reply to this post by Marcelo Henrique Cerri
On 4/22/19 10:32 PM, Marcelo Henrique Cerri wrote:

> From: Jens Axboe <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1819689
>
> We don't do anything with it, that's just the legacy path.
>
> Reviewed-by: Hannes Reinecke <[hidden email]>
> Tested-by: Ming Lei <[hidden email]>
> Reviewed-by: Omar Sandoval <[hidden email]>
> Signed-off-by: Jens Axboe <[hidden email]>
> (backported from commit 7ac257b862f2cfba3a909d1051499d390cffad6c)
> [[hidden email]: fixed context]
> Signed-off-by: Marcelo Henrique Cerri <[hidden email]>

For both xenial and cosmic:

Acked-by: Kleber Sacilotto de Souza <[hidden email]>


I have also fixed the bug nominations.

Kleber

> ---
>  block/blk-mq.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 2f8436314985..caeffd5b59f9 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -501,9 +501,6 @@ void blk_mq_free_request(struct request *rq)
>  
>   wbt_done(q->rq_wb, &rq->issue_stat);
>  
> - if (blk_rq_rl(rq))
> - blk_put_rl(blk_rq_rl(rq));
> -
>   clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags);
>   clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);
>   if (rq->tag != -1)
> @@ -1637,8 +1634,6 @@ static void blk_mq_bio_to_request(struct request *rq, struct bio *bio)
>  {
>   blk_init_request_from_bio(rq, bio);
>  
> - blk_rq_set_rl(rq, blk_get_rl(rq->q, bio));
> -
>   blk_account_io_start(rq, true);
>  }
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [x/azure][PATCH] blk-mq: remove the request_list usage

Marcelo Henrique Cerri
In reply to this post by Marcelo Henrique Cerri
--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (499 bytes) Download Attachment