[xenial:linux-azure, disco:linux-azure][PATCH 0/2] [linux-azure] Add ability to change scsi queue depth

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[xenial:linux-azure, disco:linux-azure][PATCH 0/2] [linux-azure] Add ability to change scsi queue depth

Marcelo Henrique Cerri
BugLink: https://bugs.launchpad.net/bugs/1849495

As per bug description. The commit is already present in the 5.3
kernel.

---
Branden Bonaby (1):
  scsi: storvsc: Add ability to change scsi queue depth

 drivers/scsi/storvsc_drv.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[xenial:linux-azure][PATCH 1/1] scsi: storvsc: Add ability to change scsi queue depth

Marcelo Henrique Cerri
From: Branden Bonaby <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1849495

Adding functionality to allow the SCSI queue depth to be changed by
utilizing the "scsi_change_queue_depth" function.

[mkp: checkpatch]

Signed-off-by: Branden Bonaby <[hidden email]>
Reviewed-by: Michael Kelley <[hidden email]>
Reviewed-by: K. Y. Srinivasan <[hidden email]>
Signed-off-by: Martin K. Petersen <[hidden email]>
(cherry picked from commit adfbd028e155fca3bbe33d458f2f27cb657e5792)
Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 drivers/scsi/storvsc_drv.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index b9eabd098419..697cc209aedf 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -387,6 +387,7 @@ enum storvsc_request_type {
 
 static int storvsc_ringbuffer_size = (256 * PAGE_SIZE);
 static u32 max_outstanding_req_per_channel;
+static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth);
 
 static int storvsc_vcpus_per_sub_channel = 4;
 
@@ -1674,6 +1675,7 @@ static struct scsi_host_template scsi_driver = {
  .dma_boundary = PAGE_SIZE-1,
  .no_write_same = 1,
  .track_queue_depth = 1,
+ .change_queue_depth = storvsc_change_queue_depth,
 };
 
 enum {
@@ -1885,6 +1887,15 @@ static int storvsc_probe(struct hv_device *device,
  return ret;
 }
 
+/* Change a scsi target's queue depth */
+static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth)
+{
+ if (queue_depth > scsi_driver.can_queue)
+ queue_depth = scsi_driver.can_queue;
+
+ return scsi_change_queue_depth(sdev, queue_depth);
+}
+
 static int storvsc_remove(struct hv_device *dev)
 {
  struct storvsc_device *stor_device = hv_get_drvdata(dev);
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[disco:linux-azure][PATCH 1/1] scsi: storvsc: Add ability to change scsi queue depth

Marcelo Henrique Cerri
In reply to this post by Marcelo Henrique Cerri
From: Branden Bonaby <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1849495

Adding functionality to allow the SCSI queue depth to be changed by
utilizing the "scsi_change_queue_depth" function.

[mkp: checkpatch]

Signed-off-by: Branden Bonaby <[hidden email]>
Reviewed-by: Michael Kelley <[hidden email]>
Reviewed-by: K. Y. Srinivasan <[hidden email]>
Signed-off-by: Martin K. Petersen <[hidden email]>
(cherry picked from commit adfbd028e155fca3bbe33d458f2f27cb657e5792)
Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
---
 drivers/scsi/storvsc_drv.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 3a7278306d4f..d7033ece5459 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -387,6 +387,7 @@ enum storvsc_request_type {
 
 static int storvsc_ringbuffer_size = (256 * PAGE_SIZE);
 static u32 max_outstanding_req_per_channel;
+static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth);
 
 static int storvsc_vcpus_per_sub_channel = 4;
 
@@ -1711,6 +1712,7 @@ static struct scsi_host_template scsi_driver = {
  .dma_boundary = PAGE_SIZE-1,
  .no_write_same = 1,
  .track_queue_depth = 1,
+ .change_queue_depth = storvsc_change_queue_depth,
 };
 
 enum {
@@ -1923,6 +1925,15 @@ static int storvsc_probe(struct hv_device *device,
  return ret;
 }
 
+/* Change a scsi target's queue depth */
+static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth)
+{
+ if (queue_depth > scsi_driver.can_queue)
+ queue_depth = scsi_driver.can_queue;
+
+ return scsi_change_queue_depth(sdev, queue_depth);
+}
+
 static int storvsc_remove(struct hv_device *dev)
 {
  struct storvsc_device *stor_device = hv_get_drvdata(dev);
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [xenial:linux-azure, disco:linux-azure][PATCH 0/2] [linux-azure] Add ability to change scsi queue depth

Connor Kuehl
In reply to this post by Marcelo Henrique Cerri
On 10/29/19 12:12 PM, Marcelo Henrique Cerri wrote:

> BugLink: https://bugs.launchpad.net/bugs/1849495
>
> As per bug description. The commit is already present in the 5.3
> kernel.
>
> ---
> Branden Bonaby (1):
>    scsi: storvsc: Add ability to change scsi queue depth
>
>   drivers/scsi/storvsc_drv.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>

Acked-by: Connor Kuehl <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [xenial:linux-azure, disco:linux-azure][PATCH 0/2] [linux-azure] Add ability to change scsi queue depth

Sultan Alsawaf
In reply to this post by Marcelo Henrique Cerri
Acked-by: Sultan Alsawaf <[hidden email]>

On Tue, Oct 29, 2019, 12:12 PM Marcelo Henrique Cerri <[hidden email]> wrote:
BugLink: https://bugs.launchpad.net/bugs/1849495

As per bug description. The commit is already present in the 5.3
kernel.

---
Branden Bonaby (1):
  scsi: storvsc: Add ability to change scsi queue depth

 drivers/scsi/storvsc_drv.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [xenial:linux-azure][PATCH 1/1] scsi: storvsc: Add ability to change scsi queue depth

Colin Ian King-2
In reply to this post by Marcelo Henrique Cerri
On 29/10/2019 19:12, Marcelo Henrique Cerri wrote:

> From: Branden Bonaby <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1849495
>
> Adding functionality to allow the SCSI queue depth to be changed by
> utilizing the "scsi_change_queue_depth" function.
>
> [mkp: checkpatch]
>
> Signed-off-by: Branden Bonaby <[hidden email]>
> Reviewed-by: Michael Kelley <[hidden email]>
> Reviewed-by: K. Y. Srinivasan <[hidden email]>
> Signed-off-by: Martin K. Petersen <[hidden email]>
> (cherry picked from commit adfbd028e155fca3bbe33d458f2f27cb657e5792)
> Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
> ---
>  drivers/scsi/storvsc_drv.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index b9eabd098419..697cc209aedf 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -387,6 +387,7 @@ enum storvsc_request_type {
>  
>  static int storvsc_ringbuffer_size = (256 * PAGE_SIZE);
>  static u32 max_outstanding_req_per_channel;
> +static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth);
>  
>  static int storvsc_vcpus_per_sub_channel = 4;
>  
> @@ -1674,6 +1675,7 @@ static struct scsi_host_template scsi_driver = {
>   .dma_boundary = PAGE_SIZE-1,
>   .no_write_same = 1,
>   .track_queue_depth = 1,
> + .change_queue_depth = storvsc_change_queue_depth,
>  };
>  
>  enum {
> @@ -1885,6 +1887,15 @@ static int storvsc_probe(struct hv_device *device,
>   return ret;
>  }
>  
> +/* Change a scsi target's queue depth */
> +static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth)
> +{
> + if (queue_depth > scsi_driver.can_queue)
> + queue_depth = scsi_driver.can_queue;
> +
> + return scsi_change_queue_depth(sdev, queue_depth);
> +}
> +
>  static int storvsc_remove(struct hv_device *dev)
>  {
>   struct storvsc_device *stor_device = hv_get_drvdata(dev);
>

Looks sane to me.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [disco:linux-azure][PATCH 1/1] scsi: storvsc: Add ability to change scsi queue depth

Colin Ian King-2
In reply to this post by Marcelo Henrique Cerri
On 29/10/2019 19:12, Marcelo Henrique Cerri wrote:

> From: Branden Bonaby <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1849495
>
> Adding functionality to allow the SCSI queue depth to be changed by
> utilizing the "scsi_change_queue_depth" function.
>
> [mkp: checkpatch]
>
> Signed-off-by: Branden Bonaby <[hidden email]>
> Reviewed-by: Michael Kelley <[hidden email]>
> Reviewed-by: K. Y. Srinivasan <[hidden email]>
> Signed-off-by: Martin K. Petersen <[hidden email]>
> (cherry picked from commit adfbd028e155fca3bbe33d458f2f27cb657e5792)
> Signed-off-by: Marcelo Henrique Cerri <[hidden email]>
> ---
>  drivers/scsi/storvsc_drv.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3a7278306d4f..d7033ece5459 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -387,6 +387,7 @@ enum storvsc_request_type {
>  
>  static int storvsc_ringbuffer_size = (256 * PAGE_SIZE);
>  static u32 max_outstanding_req_per_channel;
> +static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth);
>  
>  static int storvsc_vcpus_per_sub_channel = 4;
>  
> @@ -1711,6 +1712,7 @@ static struct scsi_host_template scsi_driver = {
>   .dma_boundary = PAGE_SIZE-1,
>   .no_write_same = 1,
>   .track_queue_depth = 1,
> + .change_queue_depth = storvsc_change_queue_depth,
>  };
>  
>  enum {
> @@ -1923,6 +1925,15 @@ static int storvsc_probe(struct hv_device *device,
>   return ret;
>  }
>  
> +/* Change a scsi target's queue depth */
> +static int storvsc_change_queue_depth(struct scsi_device *sdev, int queue_depth)
> +{
> + if (queue_depth > scsi_driver.can_queue)
> + queue_depth = scsi_driver.can_queue;
> +
> + return scsi_change_queue_depth(sdev, queue_depth);
> +}
> +
>  static int storvsc_remove(struct hv_device *dev)
>  {
>   struct storvsc_device *stor_device = hv_get_drvdata(dev);
>

Looks sane to me.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [xenial:linux-azure, disco:linux-azure][PATCH 0/2] [linux-azure] Add ability to change scsi queue depth

Stefan Bader-2
In reply to this post by Marcelo Henrique Cerri
On 29.10.19 20:12, Marcelo Henrique Cerri wrote:

> BugLink: https://bugs.launchpad.net/bugs/1849495
>
> As per bug description. The commit is already present in the 5.3
> kernel.
>
> ---
> Branden Bonaby (1):
>   scsi: storvsc: Add ability to change scsi queue depth
>
>  drivers/scsi/storvsc_drv.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
Applied to xenial+disco/azure/master-next. Thanks.

-Stefan


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment